drm/i915: Remove intel_prepare_page_flip, v3.

Instead of calling prepare_flip right before calling finish_page_flip
do everything from prepare_page_flip in finish_page_flip.

Putting prepare and finish page_flip in a single step removes the need
for INTEL_FLIP_COMPLETE, so it can be removed. This simplifies the code
slightly.

Changes since v1:
- Invert if case to simplify code.
- Add missing barrier.
- Reword commit message.
Changes since v2:
- intel_page_flip_plane is removed.
- work->pending is turned into a bool.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1463490484-19540-5-git-send-email-maarten.lankhorst@linux.intel.com
Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>

1 files changed, 4 insertions, 14 deletions

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 920a5e4abb70..148741646fb0 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1705,10 +1705,8 @@ static void valleyview_pipestat_irq_handler(struct drm_i915_private *dev_priv,
                     intel_pipe_handle_vblank(dev_priv, pipe))
                         intel_check_page_flip(dev_priv, pipe);
 
-                if (pipe_stats[pipe] & PLANE_FLIP_DONE_INT_STATUS_VLV) {
-                        intel_prepare_page_flip(dev_priv, pipe);
+                if (pipe_stats[pipe] & PLANE_FLIP_DONE_INT_STATUS_VLV)
                         intel_finish_page_flip(dev_priv, pipe);
-                }
 
                 if (pipe_stats[pipe] & PIPE_CRC_DONE_INTERRUPT_STATUS)
                         i9xx_pipe_crc_irq_handler(dev_priv, pipe);
@@ -2162,10 +2160,8 @@ static void ilk_display_irq_handler(struct drm_i915_private *dev_priv,
                         i9xx_pipe_crc_irq_handler(dev_priv, pipe);
 
                 /* plane/pipes map 1:1 on ilk+ */
-                if (de_iir & DE_PLANE_FLIP_DONE(pipe)) {
-                        intel_prepare_page_flip(dev_priv, pipe);
+                if (de_iir & DE_PLANE_FLIP_DONE(pipe))
                         intel_finish_page_flip(dev_priv, pipe);
-                }
         }
 
         /* check event from PCH */
@@ -2209,10 +2205,8 @@ static void ivb_display_irq_handler(struct drm_i915_private *dev_priv,
                         intel_check_page_flip(dev_priv, pipe);
 
                 /* plane/pipes map 1:1 on ilk+ */
-                if (de_iir & DE_PLANE_FLIP_DONE_IVB(pipe)) {
-                        intel_prepare_page_flip(dev_priv, pipe);
+                if (de_iir & DE_PLANE_FLIP_DONE_IVB(pipe))
                         intel_finish_page_flip(dev_priv, pipe);
-                }
         }
 
         /* check event from PCH */
@@ -2417,10 +2411,8 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
                 else
                         flip_done &= GEN8_PIPE_PRIMARY_FLIP_DONE;
 
-                if (flip_done) {
-                        intel_prepare_page_flip(dev_priv, pipe);
+                if (flip_done)
                         intel_finish_page_flip(dev_priv, pipe);
-                }
 
                 if (iir & GEN8_PIPE_CDCLK_CRC_DONE)
                         hsw_pipe_crc_irq_handler(dev_priv, pipe);
@@ -3998,7 +3990,6 @@ static bool i8xx_handle_vblank(struct drm_i915_private *dev_priv,
         if (I915_READ16(ISR) & flip_pending)
                 goto check_page_flip;
 
-        intel_prepare_page_flip(dev_priv, plane);
         intel_finish_page_flip(dev_priv, pipe);
         return true;
 
@@ -4188,7 +4179,6 @@ static bool i915_handle_vblank(struct drm_i915_private *dev_priv,
         if (I915_READ(ISR) & flip_pending)
                 goto check_page_flip;
 
-        intel_prepare_page_flip(dev_priv, plane);
         intel_finish_page_flip(dev_priv, pipe);
         return true;