diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-02-14 08:01:12 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-02-14 08:17:27 -0500 |
commit | bf3d149b25f67f241735b91a56b7f070bc0a5407 (patch) | |
tree | 08baa0fc601c826493bd3e23149d79ba3edb9401 /drivers/gpu/drm/i915/i915_gem.c | |
parent | 1ec9e26ddab06459e89a890431b2de064c5d1056 (diff) |
drm/i915: split PIN_GLOBAL out from PIN_MAPPABLE
With abitrary pin flags it makes sense to split out a "please bind
this into global gtt" from the "please allocate in the mappable
range".
Use this unconditionally in our global gtt pin helper since this is
what its callers want. Later patches will drop PIN_MAPPABLE where it's
not strictly needed.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem.c')
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index aa263e371ebc..b3a15c9fa034 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c | |||
@@ -3838,7 +3838,7 @@ i915_gem_object_pin(struct drm_i915_gem_object *obj, | |||
3838 | struct i915_vma *vma; | 3838 | struct i915_vma *vma; |
3839 | int ret; | 3839 | int ret; |
3840 | 3840 | ||
3841 | if (WARN_ON(flags & PIN_MAPPABLE && !i915_is_ggtt(vm))) | 3841 | if (WARN_ON(flags & (PIN_GLOBAL | PIN_MAPPABLE) && !i915_is_ggtt(vm))) |
3842 | return -EINVAL; | 3842 | return -EINVAL; |
3843 | 3843 | ||
3844 | vma = i915_gem_obj_to_vma(obj, vm); | 3844 | vma = i915_gem_obj_to_vma(obj, vm); |
@@ -3872,7 +3872,7 @@ i915_gem_object_pin(struct drm_i915_gem_object *obj, | |||
3872 | vma = i915_gem_obj_to_vma(obj, vm); | 3872 | vma = i915_gem_obj_to_vma(obj, vm); |
3873 | 3873 | ||
3874 | vma->bind_vma(vma, obj->cache_level, | 3874 | vma->bind_vma(vma, obj->cache_level, |
3875 | flags & PIN_MAPPABLE ? GLOBAL_BIND : 0); | 3875 | flags & PIN_GLOBAL ? GLOBAL_BIND : 0); |
3876 | 3876 | ||
3877 | i915_gem_obj_to_vma(obj, vm)->pin_count++; | 3877 | i915_gem_obj_to_vma(obj, vm)->pin_count++; |
3878 | if (flags & PIN_MAPPABLE) | 3878 | if (flags & PIN_MAPPABLE) |