don't open-code generic_file_llseek_size()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

3 files changed, 9 insertions, 58 deletions

diff --git a/drivers/char/generic_nvram.c b/drivers/char/generic_nvram.c
index 6c4f4b5a9dd3..073db9558379 100644
--- a/drivers/char/generic_nvram.c
+++ b/drivers/char/generic_nvram.c
@@ -20,6 +20,7 @@
 #include <linux/fcntl.h>
 #include <linux/init.h>
 #include <linux/mutex.h>
+#include <linux/pagemap.h>
 #include <asm/uaccess.h>
 #include <asm/nvram.h>
 #ifdef CONFIG_PPC_PMAC
@@ -33,24 +34,8 @@ static ssize_t nvram_len;
 
 static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)
 {
-        switch (origin) {
-        case 0:
-                break;
-        case 1:
-                offset += file->f_pos;
-                break;
-        case 2:
-                offset += nvram_len;
-                break;
-        default:
-                offset = -1;
-        }
-        if (offset < 0)
-                return -EINVAL;
-
-        file->f_pos = offset;
-
-        return file->f_pos;
+        return generic_file_llseek_size(file, offset, origin,
+                                        MAX_LFS_FILESIZE, nvram_len);
 }
 
 static ssize_t read_nvram(struct file *file, char __user *buf,
diff --git a/drivers/char/mbcs.c b/drivers/char/mbcs.c
index e5d3e3f7a49b..67d426470e53 100644
--- a/drivers/char/mbcs.c
+++ b/drivers/char/mbcs.c
@@ -26,6 +26,7 @@
 #include <linux/uio.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
+#include <linux/pagemap.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
@@ -451,31 +452,8 @@ mbcs_sram_write(struct file * fp, const char __user *buf, size_t len, loff_t * o
 
 static loff_t mbcs_sram_llseek(struct file * filp, loff_t off, int whence)
 {
-        loff_t newpos;
-
-        switch (whence) {
-        case SEEK_SET:
-                newpos = off;
-                break;
-
-        case SEEK_CUR:
-                newpos = filp->f_pos + off;
-                break;
-
-        case SEEK_END:
-                newpos = MBCS_SRAM_SIZE + off;
-                break;
-
-        default:                /* can't happen */
-                return -EINVAL;
-        }
-
-        if (newpos < 0)
-                return -EINVAL;
-
-        filp->f_pos = newpos;
-
-        return newpos;
+        return generic_file_llseek_size(filp, off, whence, MAX_LFS_FILESIZE,
+                                        MBCS_SRAM_SIZE);
 }
 
 static uint64_t mbcs_pioaddr(struct mbcs_soft *soft, uint64_t offset)
diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
index 97c2d8d433d6..01292328a456 100644
--- a/drivers/char/nvram.c
+++ b/drivers/char/nvram.c
@@ -110,6 +110,7 @@
 #include <linux/io.h>
 #include <linux/uaccess.h>
 #include <linux/mutex.h>
+#include <linux/pagemap.h>
 
 
 static DEFINE_MUTEX(nvram_mutex);
@@ -213,21 +214,8 @@ void nvram_set_checksum(void)
 
 static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)
 {
-        switch (origin) {
-        case 0:
-                /* nothing to do */
-                break;
-        case 1:
-                offset += file->f_pos;
-                break;
-        case 2:
-                offset += NVRAM_BYTES;
-                break;
-        default:
-                return -EINVAL;
-        }
-
-        return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;
+        return generic_file_llseek_size(file, offset, origin, MAX_LFS_FILESIZE,
+                                        NVRAM_BYTES);
 }
 
 static ssize_t nvram_read(struct file *file, char __user *buf,