diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2016-10-25 00:34:13 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-10-25 00:34:13 -0400 |
| commit | 9fe68cad6e74967b88d0c6aeca7d9cd6b6e91942 (patch) | |
| tree | 1b631b339e2cac5a95881d39ee6c51598e166210 /drivers/char | |
| parent | b5cd891716a9ef118ce8d3a367b6b0fa912447fc (diff) | |
| parent | 6d4952d9d9d4dc2bb9c0255d95a09405a1e958f7 (diff) | |
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
Pull crypto fix from Herbert Xu:
"This fixes a regression caused by the stack vmalloc change"
* 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
hwrng: core - Don't use a stack buffer in add_early_randomness()
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/hw_random/core.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index 482794526e8c..d2d2c89de5b4 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c | |||
| @@ -84,14 +84,14 @@ static size_t rng_buffer_size(void) | |||
| 84 | 84 | ||
| 85 | static void add_early_randomness(struct hwrng *rng) | 85 | static void add_early_randomness(struct hwrng *rng) |
| 86 | { | 86 | { |
| 87 | unsigned char bytes[16]; | ||
| 88 | int bytes_read; | 87 | int bytes_read; |
| 88 | size_t size = min_t(size_t, 16, rng_buffer_size()); | ||
| 89 | 89 | ||
| 90 | mutex_lock(&reading_mutex); | 90 | mutex_lock(&reading_mutex); |
| 91 | bytes_read = rng_get_data(rng, bytes, sizeof(bytes), 1); | 91 | bytes_read = rng_get_data(rng, rng_buffer, size, 1); |
| 92 | mutex_unlock(&reading_mutex); | 92 | mutex_unlock(&reading_mutex); |
| 93 | if (bytes_read > 0) | 93 | if (bytes_read > 0) |
| 94 | add_device_randomness(bytes, bytes_read); | 94 | add_device_randomness(rng_buffer, bytes_read); |
| 95 | } | 95 | } |
| 96 | 96 | ||
| 97 | static inline void cleanup_rng(struct kref *kref) | 97 | static inline void cleanup_rng(struct kref *kref) |
