misc: Add attribute groups

Add groups field to struct miscdevice for passing the attribute groups
at device creation.  In this way, the driver can avoid the manual call
of device_create_file() after the device registration, which is
basically a racy operation, in addition to the reduction of manual
device_remove_file() calls.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 3 insertions, 2 deletions

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index c892c296a4de..5bb3a2109ab7 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -207,8 +207,9 @@ int misc_register(struct miscdevice * misc)
 
         dev = MKDEV(MISC_MAJOR, misc->minor);
 
-        misc->this_device = device_create(misc_class, misc->parent, dev,
-                                          misc, "%s", misc->name);
+        misc->this_device =
+                device_create_with_groups(misc_class, misc->parent, dev,
+                                          misc, misc->groups, "%s", misc->name);
         if (IS_ERR(misc->this_device)) {
                 int i = DYNAMIC_MINORS - misc->minor - 1;
                 if (i < DYNAMIC_MINORS && i >= 0)