diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-05-30 15:55:46 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-05-30 15:55:46 -0400 |
commit | 2e4f1db49d97222110b6add9a2c6cf5251a41e35 (patch) | |
tree | 4036354ff6e279c4991e5f9692407423265a5bd0 /drivers/acpi/processor_driver.c | |
parent | 1001b4d4a8ee6b2e7a6078a02ccdf68f91b192bd (diff) |
ACPI / processor: Initialize per_cpu(processors, pr->id) properly
Commit ac212b6 (ACPI / processor: Use common hotplug infrastructure)
forgot about initializing the per-CPU 'processors' variables which
lead to ACPI cpuidle failure to use C-states and caused boot slowdown
on multi-CPU machines.
Fix the problem by adding per_cpu(processors, pr->id) initialization
to acpi_processor_add() and add make acpi_processor_remove() clean it
up as appropriate.
Also modify acpi_processor_stop() so that it doesn't clear
per_cpu(processors, pr->id) on processor driver removal which would
then cause problems to happen when the driver is loaded again.
This version of the patch contains fixes from Yinghai Lu.
Reported-and-tested-by: Yinghai Lu <yinghai@kernel.org>
Reported-and-tested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/processor_driver.c')
-rw-r--r-- | drivers/acpi/processor_driver.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c index ac28f18823b3..d93963f1e8f4 100644 --- a/drivers/acpi/processor_driver.c +++ b/drivers/acpi/processor_driver.c | |||
@@ -78,9 +78,6 @@ static struct device_driver acpi_processor_driver = { | |||
78 | .remove = acpi_processor_stop, | 78 | .remove = acpi_processor_stop, |
79 | }; | 79 | }; |
80 | 80 | ||
81 | DEFINE_PER_CPU(struct acpi_processor *, processors); | ||
82 | EXPORT_PER_CPU_SYMBOL(processors); | ||
83 | |||
84 | static void acpi_processor_notify(acpi_handle handle, u32 event, void *data) | 81 | static void acpi_processor_notify(acpi_handle handle, u32 event, void *data) |
85 | { | 82 | { |
86 | struct acpi_device *device = data; | 83 | struct acpi_device *device = data; |
@@ -268,8 +265,6 @@ static int acpi_processor_stop(struct device *dev) | |||
268 | thermal_cooling_device_unregister(pr->cdev); | 265 | thermal_cooling_device_unregister(pr->cdev); |
269 | pr->cdev = NULL; | 266 | pr->cdev = NULL; |
270 | } | 267 | } |
271 | |||
272 | per_cpu(processors, pr->id) = NULL; | ||
273 | return 0; | 268 | return 0; |
274 | } | 269 | } |
275 | 270 | ||