diff options
author | Thierry Reding <thierry.reding@avionic-design.de> | 2013-01-21 05:08:56 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-25 15:21:45 -0500 |
commit | 7c390a7e956b4bf7b7d6dba4dfb93299c4f0879a (patch) | |
tree | b7ea5ba40b42106a5f3106ff55e576b083f14bf6 /arch/mips/lantiq | |
parent | 5857bd98dbd0080e6b27b51087cc9ec24f426e8b (diff) |
MIPS: Convert to devm_ioremap_resource()
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/mips/lantiq')
-rw-r--r-- | arch/mips/lantiq/xway/dma.c | 5 | ||||
-rw-r--r-- | arch/mips/lantiq/xway/gptu.c | 8 |
2 files changed, 6 insertions, 7 deletions
diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c index e44a1866653f..08f7ebd9c774 100644 --- a/arch/mips/lantiq/xway/dma.c +++ b/arch/mips/lantiq/xway/dma.c | |||
@@ -21,6 +21,7 @@ | |||
21 | #include <linux/dma-mapping.h> | 21 | #include <linux/dma-mapping.h> |
22 | #include <linux/module.h> | 22 | #include <linux/module.h> |
23 | #include <linux/clk.h> | 23 | #include <linux/clk.h> |
24 | #include <linux/err.h> | ||
24 | 25 | ||
25 | #include <lantiq_soc.h> | 26 | #include <lantiq_soc.h> |
26 | #include <xway_dma.h> | 27 | #include <xway_dma.h> |
@@ -223,8 +224,8 @@ ltq_dma_init(struct platform_device *pdev) | |||
223 | panic("Failed to get dma resource"); | 224 | panic("Failed to get dma resource"); |
224 | 225 | ||
225 | /* remap dma register range */ | 226 | /* remap dma register range */ |
226 | ltq_dma_membase = devm_request_and_ioremap(&pdev->dev, res); | 227 | ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res); |
227 | if (!ltq_dma_membase) | 228 | if (IS_ERR(ltq_dma_membase)) |
228 | panic("Failed to remap dma resource"); | 229 | panic("Failed to remap dma resource"); |
229 | 230 | ||
230 | /* power up and reset the dma engine */ | 231 | /* power up and reset the dma engine */ |
diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c index e30b1ed1b936..9861c8669fab 100644 --- a/arch/mips/lantiq/xway/gptu.c +++ b/arch/mips/lantiq/xway/gptu.c | |||
@@ -150,11 +150,9 @@ static int gptu_probe(struct platform_device *pdev) | |||
150 | } | 150 | } |
151 | 151 | ||
152 | /* remap gptu register range */ | 152 | /* remap gptu register range */ |
153 | gptu_membase = devm_request_and_ioremap(&pdev->dev, res); | 153 | gptu_membase = devm_ioremap_resource(&pdev->dev, res); |
154 | if (!gptu_membase) { | 154 | if (IS_ERR(gptu_membase)) |
155 | dev_err(&pdev->dev, "Failed to remap resource\n"); | 155 | return PTR_ERR(gptu_membase); |
156 | return -ENOMEM; | ||
157 | } | ||
158 | 156 | ||
159 | /* enable our clock */ | 157 | /* enable our clock */ |
160 | clk = clk_get(&pdev->dev, NULL); | 158 | clk = clk_get(&pdev->dev, NULL); |