aboutsummaryrefslogtreecommitdiffstats
path: root/arch/ia64
diff options
context:
space:
mode:
authorLi Bin <huawei.libin@huawei.com>2015-12-04 02:27:43 -0500
committerSteven Rostedt <rostedt@goodmis.org>2015-12-23 14:27:23 -0500
commitcbbe12c43d8208b531c7be4d28a69c8137d19f21 (patch)
treefb58c27eb11c87ceb1480e6e8dda5e1e68469917 /arch/ia64
parent97e9b4fca52bf4e2f7eed9463a0722f8e7afbe90 (diff)
ia64: ftrace: Fix the comments for ftrace_modify_code()
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will no longer do any modifications to that module's text, the update to make functions be traced or not is done under the ftrace_lock mutex as well. And by now, __init section codes should not been modified by ftrace, because it is black listed in recordmcount.c and ignored by ftrace. Link: http://lkml.kernel.org/r/1449214067-12177-2-git-send-email-huawei.libin@huawei.com Cc: linux-ia64@vger.kernel.org Acked-by: Tony Luck <tony.luck@intel.com> Suggested-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Li Bin <huawei.libin@huawei.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'arch/ia64')
-rw-r--r--arch/ia64/kernel/ftrace.c12
1 files changed, 5 insertions, 7 deletions
diff --git a/arch/ia64/kernel/ftrace.c b/arch/ia64/kernel/ftrace.c
index 3b0c2aa07857..cee411e647ca 100644
--- a/arch/ia64/kernel/ftrace.c
+++ b/arch/ia64/kernel/ftrace.c
@@ -97,13 +97,11 @@ ftrace_modify_code(unsigned long ip, unsigned char *old_code,
97 unsigned char replaced[MCOUNT_INSN_SIZE]; 97 unsigned char replaced[MCOUNT_INSN_SIZE];
98 98
99 /* 99 /*
100 * Note: Due to modules and __init, code can 100 * Note:
101 * disappear and change, we need to protect against faulting 101 * We are paranoid about modifying text, as if a bug was to happen, it
102 * as well as code changing. We do this by using the 102 * could cause us to read or write to someplace that could cause harm.
103 * probe_kernel_* functions. 103 * Carefully read and modify the code with probe_kernel_*(), and make
104 * 104 * sure what we read is what we expected it to be before modifying it.
105 * No real locking needed, this code is run through
106 * kstop_machine, or before SMP starts.
107 */ 105 */
108 106
109 if (!do_check) 107 if (!do_check)