diff options
author | Stefan Wahren <stefan.wahren@i2se.com> | 2015-12-01 17:55:40 -0500 |
---|---|---|
committer | Thierry Reding <thierry.reding@gmail.com> | 2015-12-16 10:45:10 -0500 |
commit | fd13c14426299e75983a0cd3edf53dfa4083a70a (patch) | |
tree | 1698122b905b9bfbaa364b11dc38ad9ac435674b | |
parent | ebe88b6ae41ff8f2b48608b6019c4341aa24bcea (diff) |
pwm: bcm2835: Prevent division by zero
It's possible that the PWM clock becomes an orphan. So better check the
result of clk_get_rate() in order to prevent a division by zero.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
-rw-r--r-- | drivers/pwm/pwm-bcm2835.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c index 174cca92f690..31a6992a445c 100644 --- a/drivers/pwm/pwm-bcm2835.c +++ b/drivers/pwm/pwm-bcm2835.c | |||
@@ -65,7 +65,15 @@ static int bcm2835_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, | |||
65 | int duty_ns, int period_ns) | 65 | int duty_ns, int period_ns) |
66 | { | 66 | { |
67 | struct bcm2835_pwm *pc = to_bcm2835_pwm(chip); | 67 | struct bcm2835_pwm *pc = to_bcm2835_pwm(chip); |
68 | unsigned long scaler = NSEC_PER_SEC / clk_get_rate(pc->clk); | 68 | unsigned long rate = clk_get_rate(pc->clk); |
69 | unsigned long scaler; | ||
70 | |||
71 | if (!rate) { | ||
72 | dev_err(pc->dev, "failed to get clock rate\n"); | ||
73 | return -EINVAL; | ||
74 | } | ||
75 | |||
76 | scaler = NSEC_PER_SEC / rate; | ||
69 | 77 | ||
70 | if (period_ns <= MIN_PERIOD) { | 78 | if (period_ns <= MIN_PERIOD) { |
71 | dev_err(pc->dev, "period %d not supported, minimum %d\n", | 79 | dev_err(pc->dev, "period %d not supported, minimum %d\n", |