aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kuleshov <kuleshovmail@gmail.com>2016-05-20 19:57:35 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2016-05-20 20:58:30 -0400
commitf705ac4b39f30a6a5f8411a42114758f4d4655bc (patch)
tree9a08e6acd82c775da9622427c604c17c24a60c7b
parent495367c051fb200a42636bdc63be78ca1713a85a (diff)
mm/memblock.c: move memblock_{add,reserve}_region into memblock_{add,reserve}
memblock_add_region() and memblock_reserve_region() do nothing specific before the call of memblock_add_range(), only print debug output. We can do the same in memblock_add() and memblock_reserve() since both memblock_add_region() and memblock_reserve_region() are not used by anybody outside of memblock.c and memblock_{add,reserve}() have the same set of flags and nids. Since memblock_add_region() and memblock_reserve_region() will be inlined, there will not be functional changes, but will improve code readability a little. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Pekka Enberg <penberg@kernel.org> Cc: Tony Luck <tony.luck@intel.com> Cc: Tang Chen <tangchen@cn.fujitsu.com> Cc: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/memblock.c28
1 files changed, 6 insertions, 22 deletions
diff --git a/mm/memblock.c b/mm/memblock.c
index b570dddb4cb9..3b93daa46fc5 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -606,22 +606,14 @@ int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
606 return memblock_add_range(&memblock.memory, base, size, nid, 0); 606 return memblock_add_range(&memblock.memory, base, size, nid, 0);
607} 607}
608 608
609static int __init_memblock memblock_add_region(phys_addr_t base, 609int __init_memblock memblock_add(phys_addr_t base, phys_addr_t size)
610 phys_addr_t size,
611 int nid,
612 unsigned long flags)
613{ 610{
614 memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n", 611 memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n",
615 (unsigned long long)base, 612 (unsigned long long)base,
616 (unsigned long long)base + size - 1, 613 (unsigned long long)base + size - 1,
617 flags, (void *)_RET_IP_); 614 0UL, (void *)_RET_IP_);
618
619 return memblock_add_range(&memblock.memory, base, size, nid, flags);
620}
621 615
622int __init_memblock memblock_add(phys_addr_t base, phys_addr_t size) 616 return memblock_add_range(&memblock.memory, base, size, MAX_NUMNODES, 0);
623{
624 return memblock_add_region(base, size, MAX_NUMNODES, 0);
625} 617}
626 618
627/** 619/**
@@ -732,22 +724,14 @@ int __init_memblock memblock_free(phys_addr_t base, phys_addr_t size)
732 return memblock_remove_range(&memblock.reserved, base, size); 724 return memblock_remove_range(&memblock.reserved, base, size);
733} 725}
734 726
735static int __init_memblock memblock_reserve_region(phys_addr_t base, 727int __init_memblock memblock_reserve(phys_addr_t base, phys_addr_t size)
736 phys_addr_t size,
737 int nid,
738 unsigned long flags)
739{ 728{
740 memblock_dbg("memblock_reserve: [%#016llx-%#016llx] flags %#02lx %pF\n", 729 memblock_dbg("memblock_reserve: [%#016llx-%#016llx] flags %#02lx %pF\n",
741 (unsigned long long)base, 730 (unsigned long long)base,
742 (unsigned long long)base + size - 1, 731 (unsigned long long)base + size - 1,
743 flags, (void *)_RET_IP_); 732 0UL, (void *)_RET_IP_);
744
745 return memblock_add_range(&memblock.reserved, base, size, nid, flags);
746}
747 733
748int __init_memblock memblock_reserve(phys_addr_t base, phys_addr_t size) 734 return memblock_add_range(&memblock.reserved, base, size, MAX_NUMNODES, 0);
749{
750 return memblock_reserve_region(base, size, MAX_NUMNODES, 0);
751} 735}
752 736
753/** 737/**