diff options
author | Laxman Dewangan <ldewangan@nvidia.com> | 2016-02-24 04:14:07 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2016-04-20 18:03:28 -0400 |
commit | f1daa8a1a96812372f3afda90c6dc29d62f7f9b3 (patch) | |
tree | f91580cb3efda6fe59177b3b78c16997410dea98 | |
parent | 45078ea03f169ddb1bf13aceba748c4bfca524ac (diff) |
pinctrl: tegra: Use devm_pinctrl_register() for pinctrl registration
Use devm_pinctrl_register() for pin control registration and remove
need of .remove callback.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra.c | 12 | ||||
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra.h | 2 | ||||
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra114.c | 1 | ||||
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra124.c | 1 | ||||
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra20.c | 1 | ||||
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra210.c | 1 | ||||
-rw-r--r-- | drivers/pinctrl/tegra/pinctrl-tegra30.c | 1 |
7 files changed, 1 insertions, 18 deletions
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 053d62016e5a..861baf29ef70 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c | |||
@@ -735,7 +735,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev, | |||
735 | return PTR_ERR(pmx->regs[i]); | 735 | return PTR_ERR(pmx->regs[i]); |
736 | } | 736 | } |
737 | 737 | ||
738 | pmx->pctl = pinctrl_register(&tegra_pinctrl_desc, &pdev->dev, pmx); | 738 | pmx->pctl = devm_pinctrl_register(&pdev->dev, &tegra_pinctrl_desc, pmx); |
739 | if (IS_ERR(pmx->pctl)) { | 739 | if (IS_ERR(pmx->pctl)) { |
740 | dev_err(&pdev->dev, "Couldn't register pinctrl driver\n"); | 740 | dev_err(&pdev->dev, "Couldn't register pinctrl driver\n"); |
741 | return PTR_ERR(pmx->pctl); | 741 | return PTR_ERR(pmx->pctl); |
@@ -753,13 +753,3 @@ int tegra_pinctrl_probe(struct platform_device *pdev, | |||
753 | return 0; | 753 | return 0; |
754 | } | 754 | } |
755 | EXPORT_SYMBOL_GPL(tegra_pinctrl_probe); | 755 | EXPORT_SYMBOL_GPL(tegra_pinctrl_probe); |
756 | |||
757 | int tegra_pinctrl_remove(struct platform_device *pdev) | ||
758 | { | ||
759 | struct tegra_pmx *pmx = platform_get_drvdata(pdev); | ||
760 | |||
761 | pinctrl_unregister(pmx->pctl); | ||
762 | |||
763 | return 0; | ||
764 | } | ||
765 | EXPORT_SYMBOL_GPL(tegra_pinctrl_remove); | ||
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.h b/drivers/pinctrl/tegra/pinctrl-tegra.h index 20b893443d0b..d2ced17382b5 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.h +++ b/drivers/pinctrl/tegra/pinctrl-tegra.h | |||
@@ -195,6 +195,4 @@ struct tegra_pinctrl_soc_data { | |||
195 | 195 | ||
196 | int tegra_pinctrl_probe(struct platform_device *pdev, | 196 | int tegra_pinctrl_probe(struct platform_device *pdev, |
197 | const struct tegra_pinctrl_soc_data *soc_data); | 197 | const struct tegra_pinctrl_soc_data *soc_data); |
198 | int tegra_pinctrl_remove(struct platform_device *pdev); | ||
199 | |||
200 | #endif | 198 | #endif |
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra114.c b/drivers/pinctrl/tegra/pinctrl-tegra114.c index b831dcfa5359..4851d169f4c7 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra114.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra114.c | |||
@@ -1865,7 +1865,6 @@ static struct platform_driver tegra114_pinctrl_driver = { | |||
1865 | .of_match_table = tegra114_pinctrl_of_match, | 1865 | .of_match_table = tegra114_pinctrl_of_match, |
1866 | }, | 1866 | }, |
1867 | .probe = tegra114_pinctrl_probe, | 1867 | .probe = tegra114_pinctrl_probe, |
1868 | .remove = tegra_pinctrl_remove, | ||
1869 | }; | 1868 | }; |
1870 | module_platform_driver(tegra114_pinctrl_driver); | 1869 | module_platform_driver(tegra114_pinctrl_driver); |
1871 | 1870 | ||
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra124.c b/drivers/pinctrl/tegra/pinctrl-tegra124.c index 199d301f7c3e..a0ce723a9482 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra124.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra124.c | |||
@@ -2077,7 +2077,6 @@ static struct platform_driver tegra124_pinctrl_driver = { | |||
2077 | .of_match_table = tegra124_pinctrl_of_match, | 2077 | .of_match_table = tegra124_pinctrl_of_match, |
2078 | }, | 2078 | }, |
2079 | .probe = tegra124_pinctrl_probe, | 2079 | .probe = tegra124_pinctrl_probe, |
2080 | .remove = tegra_pinctrl_remove, | ||
2081 | }; | 2080 | }; |
2082 | module_platform_driver(tegra124_pinctrl_driver); | 2081 | module_platform_driver(tegra124_pinctrl_driver); |
2083 | 2082 | ||
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra20.c b/drivers/pinctrl/tegra/pinctrl-tegra20.c index a2d0b98d72b3..09bad6980ad1 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra20.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra20.c | |||
@@ -2245,7 +2245,6 @@ static struct platform_driver tegra20_pinctrl_driver = { | |||
2245 | .of_match_table = tegra20_pinctrl_of_match, | 2245 | .of_match_table = tegra20_pinctrl_of_match, |
2246 | }, | 2246 | }, |
2247 | .probe = tegra20_pinctrl_probe, | 2247 | .probe = tegra20_pinctrl_probe, |
2248 | .remove = tegra_pinctrl_remove, | ||
2249 | }; | 2248 | }; |
2250 | module_platform_driver(tegra20_pinctrl_driver); | 2249 | module_platform_driver(tegra20_pinctrl_driver); |
2251 | 2250 | ||
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra210.c b/drivers/pinctrl/tegra/pinctrl-tegra210.c index 825bf62d939a..2d856af389ef 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra210.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra210.c | |||
@@ -1583,7 +1583,6 @@ static struct platform_driver tegra210_pinctrl_driver = { | |||
1583 | .of_match_table = tegra210_pinctrl_of_match, | 1583 | .of_match_table = tegra210_pinctrl_of_match, |
1584 | }, | 1584 | }, |
1585 | .probe = tegra210_pinctrl_probe, | 1585 | .probe = tegra210_pinctrl_probe, |
1586 | .remove = tegra_pinctrl_remove, | ||
1587 | }; | 1586 | }; |
1588 | module_platform_driver(tegra210_pinctrl_driver); | 1587 | module_platform_driver(tegra210_pinctrl_driver); |
1589 | 1588 | ||
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra30.c b/drivers/pinctrl/tegra/pinctrl-tegra30.c index 4dc9642c914a..fb7817fea2d9 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra30.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra30.c | |||
@@ -2500,7 +2500,6 @@ static struct platform_driver tegra30_pinctrl_driver = { | |||
2500 | .of_match_table = tegra30_pinctrl_of_match, | 2500 | .of_match_table = tegra30_pinctrl_of_match, |
2501 | }, | 2501 | }, |
2502 | .probe = tegra30_pinctrl_probe, | 2502 | .probe = tegra30_pinctrl_probe, |
2503 | .remove = tegra_pinctrl_remove, | ||
2504 | }; | 2503 | }; |
2505 | module_platform_driver(tegra30_pinctrl_driver); | 2504 | module_platform_driver(tegra30_pinctrl_driver); |
2506 | 2505 | ||