diff options
author | Johannes Thumshirn <jthumshirn@suse.de> | 2016-05-10 09:14:28 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2016-06-09 16:28:28 -0400 |
commit | edb50a5403d2e2d2b2b63a8365c4378c9c300ed6 (patch) | |
tree | b35cad3dc3b2dc6d5fb41cc99fe3bd180ab8e4e6 | |
parent | 1decabc1a70b97ef7412224df3dcb59d1227e3af (diff) |
NVMe: Only release requested regions
The NVMe driver only requests the PCIe device's memory regions but releases
all possible regions (including eventual I/O regions). This leads to a stale
warning entry in dmesg about freeing non existent resources.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r-- | drivers/nvme/host/pci.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 78dca3193ca4..befac5b19490 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c | |||
@@ -1679,9 +1679,14 @@ static int nvme_pci_enable(struct nvme_dev *dev) | |||
1679 | 1679 | ||
1680 | static void nvme_dev_unmap(struct nvme_dev *dev) | 1680 | static void nvme_dev_unmap(struct nvme_dev *dev) |
1681 | { | 1681 | { |
1682 | struct pci_dev *pdev = to_pci_dev(dev->dev); | ||
1683 | int bars; | ||
1684 | |||
1682 | if (dev->bar) | 1685 | if (dev->bar) |
1683 | iounmap(dev->bar); | 1686 | iounmap(dev->bar); |
1684 | pci_release_regions(to_pci_dev(dev->dev)); | 1687 | |
1688 | bars = pci_select_bars(pdev, IORESOURCE_MEM); | ||
1689 | pci_release_selected_regions(pdev, bars); | ||
1685 | } | 1690 | } |
1686 | 1691 | ||
1687 | static void nvme_pci_disable(struct nvme_dev *dev) | 1692 | static void nvme_pci_disable(struct nvme_dev *dev) |
@@ -1924,7 +1929,7 @@ static int nvme_dev_map(struct nvme_dev *dev) | |||
1924 | 1929 | ||
1925 | return 0; | 1930 | return 0; |
1926 | release: | 1931 | release: |
1927 | pci_release_regions(pdev); | 1932 | pci_release_selected_regions(pdev, bars); |
1928 | return -ENODEV; | 1933 | return -ENODEV; |
1929 | } | 1934 | } |
1930 | 1935 | ||