diff options
author | NeilBrown <neilb@suse.com> | 2016-03-09 16:59:28 -0500 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2016-03-09 17:59:41 -0500 |
commit | ec56151d382c2140851b4f25203af9016ba84fea (patch) | |
tree | f01c52c76c50dfd8c26e0f727d60aced5c7f0ac6 | |
parent | 55155291b32d24371256adbcc67f9f53cf3f314f (diff) |
nvdimm/blk: don't allocate unused major device number
When alloc_disk(0) is used ->major is completely ignored, all devices
are allocated with a "major" of BLOCK_EXT_MAJOR.
So don't allocate nd_blk_major
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r-- | drivers/nvdimm/blk.c | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c index 91a336ea8c4f..e9ff9229d942 100644 --- a/drivers/nvdimm/blk.c +++ b/drivers/nvdimm/blk.c | |||
@@ -31,8 +31,6 @@ struct nd_blk_device { | |||
31 | u32 internal_lbasize; | 31 | u32 internal_lbasize; |
32 | }; | 32 | }; |
33 | 33 | ||
34 | static int nd_blk_major; | ||
35 | |||
36 | static u32 nd_blk_meta_size(struct nd_blk_device *blk_dev) | 34 | static u32 nd_blk_meta_size(struct nd_blk_device *blk_dev) |
37 | { | 35 | { |
38 | return blk_dev->nsblk->lbasize - blk_dev->sector_size; | 36 | return blk_dev->nsblk->lbasize - blk_dev->sector_size; |
@@ -264,7 +262,6 @@ static int nd_blk_attach_disk(struct nd_namespace_common *ndns, | |||
264 | } | 262 | } |
265 | 263 | ||
266 | disk->driverfs_dev = &ndns->dev; | 264 | disk->driverfs_dev = &ndns->dev; |
267 | disk->major = nd_blk_major; | ||
268 | disk->first_minor = 0; | 265 | disk->first_minor = 0; |
269 | disk->fops = &nd_blk_fops; | 266 | disk->fops = &nd_blk_fops; |
270 | disk->private_data = blk_dev; | 267 | disk->private_data = blk_dev; |
@@ -358,25 +355,12 @@ static struct nd_device_driver nd_blk_driver = { | |||
358 | 355 | ||
359 | static int __init nd_blk_init(void) | 356 | static int __init nd_blk_init(void) |
360 | { | 357 | { |
361 | int rc; | 358 | return nd_driver_register(&nd_blk_driver); |
362 | |||
363 | rc = register_blkdev(0, "nd_blk"); | ||
364 | if (rc < 0) | ||
365 | return rc; | ||
366 | |||
367 | nd_blk_major = rc; | ||
368 | rc = nd_driver_register(&nd_blk_driver); | ||
369 | |||
370 | if (rc < 0) | ||
371 | unregister_blkdev(nd_blk_major, "nd_blk"); | ||
372 | |||
373 | return rc; | ||
374 | } | 359 | } |
375 | 360 | ||
376 | static void __exit nd_blk_exit(void) | 361 | static void __exit nd_blk_exit(void) |
377 | { | 362 | { |
378 | driver_unregister(&nd_blk_driver.drv); | 363 | driver_unregister(&nd_blk_driver.drv); |
379 | unregister_blkdev(nd_blk_major, "nd_blk"); | ||
380 | } | 364 | } |
381 | 365 | ||
382 | MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>"); | 366 | MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>"); |