diff options
author | Arnd Bergmann <arnd@arndb.de> | 2016-09-14 18:17:39 -0400 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2016-09-14 18:17:39 -0400 |
commit | e747ea14de075172212823cbcb4a07a8ccd55c35 (patch) | |
tree | bd3c648103446933fcc295f70a646cbf4e35eeae | |
parent | 132166589c670cd9f9a8ac7b3676f72fff35d81b (diff) | |
parent | 7922118f8f3e76eb6534e9221a6c9f496c0ae699 (diff) |
Merge tag 'at91-ab-4.9-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux into next/drivers
Pull "at91 drivers for 4.9" from Alexandre Belloni:
- Coccinelle fixes for atmel-ebi and atmel-sdramc
* tag 'at91-ab-4.9-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux:
memory: atmel-sdramc: fix a possible NULL dereference
memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code
-rw-r--r-- | drivers/memory/atmel-ebi.c | 10 | ||||
-rw-r--r-- | drivers/memory/atmel-sdramc.c | 4 |
2 files changed, 3 insertions, 11 deletions
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c index f87ad6f5d2dc..b5ed3bd082b5 100644 --- a/drivers/memory/atmel-ebi.c +++ b/drivers/memory/atmel-ebi.c | |||
@@ -410,10 +410,7 @@ static int at91sam9_ebi_init(struct at91_ebi *ebi) | |||
410 | 410 | ||
411 | field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC); | 411 | field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC); |
412 | fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field); | 412 | fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field); |
413 | if (IS_ERR(fields->mode)) | 413 | return PTR_ERR_OR_ZERO(fields->mode); |
414 | return PTR_ERR(fields->mode); | ||
415 | |||
416 | return 0; | ||
417 | } | 414 | } |
418 | 415 | ||
419 | static int sama5d3_ebi_init(struct at91_ebi *ebi) | 416 | static int sama5d3_ebi_init(struct at91_ebi *ebi) |
@@ -441,10 +438,7 @@ static int sama5d3_ebi_init(struct at91_ebi *ebi) | |||
441 | 438 | ||
442 | field.reg = SAMA5_SMC_MODE(SAMA5_SMC_GENERIC); | 439 | field.reg = SAMA5_SMC_MODE(SAMA5_SMC_GENERIC); |
443 | fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field); | 440 | fields->mode = devm_regmap_field_alloc(ebi->dev, ebi->smc, field); |
444 | if (IS_ERR(fields->mode)) | 441 | return PTR_ERR_OR_ZERO(fields->mode); |
445 | return PTR_ERR(fields->mode); | ||
446 | |||
447 | return 0; | ||
448 | } | 442 | } |
449 | 443 | ||
450 | static int at91_ebi_dev_setup(struct at91_ebi *ebi, struct device_node *np, | 444 | static int at91_ebi_dev_setup(struct at91_ebi *ebi, struct device_node *np, |
diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c index 53a341f3b305..12080b05e3e6 100644 --- a/drivers/memory/atmel-sdramc.c +++ b/drivers/memory/atmel-sdramc.c | |||
@@ -53,12 +53,10 @@ static const struct of_device_id atmel_ramc_of_match[] = { | |||
53 | 53 | ||
54 | static int atmel_ramc_probe(struct platform_device *pdev) | 54 | static int atmel_ramc_probe(struct platform_device *pdev) |
55 | { | 55 | { |
56 | const struct of_device_id *match; | ||
57 | const struct at91_ramc_caps *caps; | 56 | const struct at91_ramc_caps *caps; |
58 | struct clk *clk; | 57 | struct clk *clk; |
59 | 58 | ||
60 | match = of_match_device(atmel_ramc_of_match, &pdev->dev); | 59 | caps = of_device_get_match_data(&pdev->dev); |
61 | caps = match->data; | ||
62 | 60 | ||
63 | if (caps->has_ddrck) { | 61 | if (caps->has_ddrck) { |
64 | clk = devm_clk_get(&pdev->dev, "ddrck"); | 62 | clk = devm_clk_get(&pdev->dev, "ddrck"); |