diff options
author | Arnd Bergmann <arnd@arndb.de> | 2015-12-17 10:35:20 -0500 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2015-12-17 10:39:08 -0500 |
commit | e45a1e18a57ccc2457429f3bd42d93330c0fee3c (patch) | |
tree | 7fb629bc8c9235dff8c10f5110a415d8d8a2f20e | |
parent | 3081dc9eff32519bc3298c6dba0b877675d4c1cd (diff) |
ARM: defconfig: use correct debug_ll settings
The debug-ll infrastructure can be configured in two ways, either
by selecting a platform specific debug option, or by picking one
of the generic options (8250 or pl01x typically). For compatibility
with multiplatform kernels, we have changed a couple of platforms
to use the former method now when they used to use the latter.
Unfortunately, this broke the defconfigs because now they still
enable CONFIG_DEBUG_LL_UART_PL01X or CONFIG_DEBUG_LL_UART_8250,
and we no longer configure the correct register addresses
automatically.
Embarrassingly, this was only found in linux-next when the
defconfig builds turned up errors for multiple people, and I
had not caught those in my own tests, which were done using
the randconfig fixes patchset on top, and that has a workaround
to avoid a build error when the addresses are not configured.
The error was something like:
.config:2010:warning: symbol value '' invalid for DEBUG_UART_PHYS
.config:2011:warning: symbol value '' invalid for DEBUG_UART_VIRT
This patch avoids the problem by removing the respective
statements from the defconfig files. Any out of tree defconfig
files on the platforms I have changed will have to do the same
change or run into the build error above. Any users that have
a full .config already set the correct DEBUG_UART_PHYS/VIRT
addresses and do not need to change anything.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4db22c1 ("ARM: debug-ll: rework integrator/versatile handling")
Fixes: f06455f ("ARM: debug-ll: rework ep93xx handling")
Fixes: c047f52 ("ARM: debug-ll: reorganize mvebu debug uart config")
Fixes: 59bd4c3 ("ARM: debug-ll: rework lpc32xx handling")
-rw-r--r-- | arch/arm/configs/ep93xx_defconfig | 1 | ||||
-rw-r--r-- | arch/arm/configs/lpc32xx_defconfig | 1 | ||||
-rw-r--r-- | arch/arm/configs/mv78xx0_defconfig | 1 | ||||
-rw-r--r-- | arch/arm/configs/orion5x_defconfig | 1 | ||||
-rw-r--r-- | arch/arm/configs/versatile_defconfig | 1 |
5 files changed, 0 insertions, 5 deletions
diff --git a/arch/arm/configs/ep93xx_defconfig b/arch/arm/configs/ep93xx_defconfig index a7846d64b396..158dde87f5d0 100644 --- a/arch/arm/configs/ep93xx_defconfig +++ b/arch/arm/configs/ep93xx_defconfig | |||
@@ -132,6 +132,5 @@ CONFIG_DEBUG_SPINLOCK=y | |||
132 | CONFIG_DEBUG_MUTEXES=y | 132 | CONFIG_DEBUG_MUTEXES=y |
133 | CONFIG_DEBUG_USER=y | 133 | CONFIG_DEBUG_USER=y |
134 | CONFIG_DEBUG_LL=y | 134 | CONFIG_DEBUG_LL=y |
135 | CONFIG_DEBUG_LL_UART_PL01X=y | ||
136 | # CONFIG_CRYPTO_ANSI_CPRNG is not set | 135 | # CONFIG_CRYPTO_ANSI_CPRNG is not set |
137 | CONFIG_LIBCRC32C=y | 136 | CONFIG_LIBCRC32C=y |
diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig index c100b7df5441..9f56ca3985ae 100644 --- a/arch/arm/configs/lpc32xx_defconfig +++ b/arch/arm/configs/lpc32xx_defconfig | |||
@@ -204,7 +204,6 @@ CONFIG_DEBUG_INFO=y | |||
204 | # CONFIG_FTRACE is not set | 204 | # CONFIG_FTRACE is not set |
205 | # CONFIG_ARM_UNWIND is not set | 205 | # CONFIG_ARM_UNWIND is not set |
206 | CONFIG_DEBUG_LL=y | 206 | CONFIG_DEBUG_LL=y |
207 | CONFIG_DEBUG_LL_UART_8250=y | ||
208 | CONFIG_EARLY_PRINTK=y | 207 | CONFIG_EARLY_PRINTK=y |
209 | CONFIG_CRYPTO_ANSI_CPRNG=y | 208 | CONFIG_CRYPTO_ANSI_CPRNG=y |
210 | # CONFIG_CRYPTO_HW is not set | 209 | # CONFIG_CRYPTO_HW is not set |
diff --git a/arch/arm/configs/mv78xx0_defconfig b/arch/arm/configs/mv78xx0_defconfig index fcdffa7d9d78..a0345e1ce172 100644 --- a/arch/arm/configs/mv78xx0_defconfig +++ b/arch/arm/configs/mv78xx0_defconfig | |||
@@ -135,7 +135,6 @@ CONFIG_SYSCTL_SYSCALL_CHECK=y | |||
135 | CONFIG_DEBUG_USER=y | 135 | CONFIG_DEBUG_USER=y |
136 | CONFIG_DEBUG_ERRORS=y | 136 | CONFIG_DEBUG_ERRORS=y |
137 | CONFIG_DEBUG_LL=y | 137 | CONFIG_DEBUG_LL=y |
138 | CONFIG_DEBUG_LL_UART_8250=y | ||
139 | CONFIG_CRYPTO_CBC=m | 138 | CONFIG_CRYPTO_CBC=m |
140 | CONFIG_CRYPTO_ECB=m | 139 | CONFIG_CRYPTO_ECB=m |
141 | CONFIG_CRYPTO_PCBC=m | 140 | CONFIG_CRYPTO_PCBC=m |
diff --git a/arch/arm/configs/orion5x_defconfig b/arch/arm/configs/orion5x_defconfig index 6ddca8875cb5..5876ce7af130 100644 --- a/arch/arm/configs/orion5x_defconfig +++ b/arch/arm/configs/orion5x_defconfig | |||
@@ -162,7 +162,6 @@ CONFIG_LATENCYTOP=y | |||
162 | # CONFIG_FTRACE is not set | 162 | # CONFIG_FTRACE is not set |
163 | CONFIG_DEBUG_USER=y | 163 | CONFIG_DEBUG_USER=y |
164 | CONFIG_DEBUG_LL=y | 164 | CONFIG_DEBUG_LL=y |
165 | CONFIG_DEBUG_LL_UART_8250=y | ||
166 | CONFIG_CRYPTO_CBC=m | 165 | CONFIG_CRYPTO_CBC=m |
167 | CONFIG_CRYPTO_ECB=m | 166 | CONFIG_CRYPTO_ECB=m |
168 | CONFIG_CRYPTO_PCBC=m | 167 | CONFIG_CRYPTO_PCBC=m |
diff --git a/arch/arm/configs/versatile_defconfig b/arch/arm/configs/versatile_defconfig index 01f402ddb1e7..64bef9775bb6 100644 --- a/arch/arm/configs/versatile_defconfig +++ b/arch/arm/configs/versatile_defconfig | |||
@@ -82,6 +82,5 @@ CONFIG_MAGIC_SYSRQ=y | |||
82 | CONFIG_DEBUG_KERNEL=y | 82 | CONFIG_DEBUG_KERNEL=y |
83 | CONFIG_DEBUG_USER=y | 83 | CONFIG_DEBUG_USER=y |
84 | CONFIG_DEBUG_LL=y | 84 | CONFIG_DEBUG_LL=y |
85 | CONFIG_DEBUG_LL_UART_PL01X=y | ||
86 | CONFIG_FONTS=y | 85 | CONFIG_FONTS=y |
87 | CONFIG_FONT_ACORN_8x8=y | 86 | CONFIG_FONT_ACORN_8x8=y |