diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-12-19 21:51:23 -0500 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2014-03-15 13:19:00 -0400 |
| commit | e39a8b4f9ec67e4152032ff31eeccf4d7251833f (patch) | |
| tree | 215bac561fd709448a8e3a22f07da01cb301f730 | |
| parent | ad469a57643b322dc7a3bfc482e265e1e88f735a (diff) | |
[SCSI] bfa: fix missing unlock on error in bfad_iocmd_cfg_trunk()
Add the missing unlock before return from function bfad_iocmd_cfg_trunk()
in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Vijaya Mohan Guvva <vmohan@brocade.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/bfa/bfad_bsg.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c index 157f6044a9bb..8994fb857ee9 100644 --- a/drivers/scsi/bfa/bfad_bsg.c +++ b/drivers/scsi/bfa/bfad_bsg.c | |||
| @@ -2304,8 +2304,10 @@ bfad_iocmd_cfg_trunk(struct bfad_s *bfad, void *cmd, unsigned int v_cmd) | |||
| 2304 | 2304 | ||
| 2305 | spin_lock_irqsave(&bfad->bfad_lock, flags); | 2305 | spin_lock_irqsave(&bfad->bfad_lock, flags); |
| 2306 | 2306 | ||
| 2307 | if (bfa_fcport_is_dport(&bfad->bfa)) | 2307 | if (bfa_fcport_is_dport(&bfad->bfa)) { |
| 2308 | spin_unlock_irqrestore(&bfad->bfad_lock, flags); | ||
| 2308 | return BFA_STATUS_DPORT_ERR; | 2309 | return BFA_STATUS_DPORT_ERR; |
| 2310 | } | ||
| 2309 | 2311 | ||
| 2310 | if ((fcport->cfg.topology == BFA_PORT_TOPOLOGY_LOOP) || | 2312 | if ((fcport->cfg.topology == BFA_PORT_TOPOLOGY_LOOP) || |
| 2311 | (fcport->topology == BFA_PORT_TOPOLOGY_LOOP)) | 2313 | (fcport->topology == BFA_PORT_TOPOLOGY_LOOP)) |