s390/zcrypt: Fix cryptographic device id in kernel messages

Currently, on card response failures a combination of card domain and
domain id is recorded in the kernel messages.

According to the message description only the card id will be recorded.
The domain id is not relevant, since the whole card including all domains
is set offline.

Signed-off-by: Ingo Tuchscherer <ingo.tuchscherer@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

3 files changed, 24 insertions, 20 deletions

diff --git a/drivers/s390/crypto/zcrypt_error.h b/drivers/s390/crypto/zcrypt_error.h
index 7b23f43c7b08..de1b6c1d172c 100644
--- a/drivers/s390/crypto/zcrypt_error.h
+++ b/drivers/s390/crypto/zcrypt_error.h
@@ -112,9 +112,10 @@ static inline int convert_error(struct zcrypt_device *zdev,
                 atomic_set(&zcrypt_rescan_req, 1);
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%drc%d",
-                        zdev->ap_dev->qid, zdev->online, ehdr->reply_code);
+                        AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online,
+                        ehdr->reply_code);
                 return -EAGAIN;
         case REP82_ERROR_TRANSPORT_FAIL:
         case REP82_ERROR_MACHINE_FAILURE:
@@ -123,16 +124,18 @@ static inline int convert_error(struct zcrypt_device *zdev,
                 atomic_set(&zcrypt_rescan_req, 1);
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%drc%d",
-                        zdev->ap_dev->qid, zdev->online, ehdr->reply_code);
+                        AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online,
+                        ehdr->reply_code);
                 return -EAGAIN;
         default:
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%drc%d",
-                        zdev->ap_dev->qid, zdev->online, ehdr->reply_code);
+                        AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online,
+                        ehdr->reply_code);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
 }
diff --git a/drivers/s390/crypto/zcrypt_msgtype50.c b/drivers/s390/crypto/zcrypt_msgtype50.c
index 74edf2934e7c..eedfaa2cf715 100644
--- a/drivers/s390/crypto/zcrypt_msgtype50.c
+++ b/drivers/s390/crypto/zcrypt_msgtype50.c
@@ -336,9 +336,10 @@ static int convert_type80(struct zcrypt_device *zdev,
                 /* The result is too short, the CEX2A card may not do that.. */
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%drc%d",
-                               zdev->ap_dev->qid, zdev->online, t80h->code);
+                               AP_QID_DEVICE(zdev->ap_dev->qid),
+                               zdev->online, t80h->code);
 
                 return -EAGAIN; /* repeat the request on a different device. */
         }
@@ -368,9 +369,9 @@ static int convert_response(struct zcrypt_device *zdev,
         default: /* Unknown response type, this should NEVER EVER happen */
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%dfail",
-                               zdev->ap_dev->qid, zdev->online);
+                               AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
 }
diff --git a/drivers/s390/crypto/zcrypt_msgtype6.c b/drivers/s390/crypto/zcrypt_msgtype6.c
index 9a2dd472c1cc..21959719daef 100644
--- a/drivers/s390/crypto/zcrypt_msgtype6.c
+++ b/drivers/s390/crypto/zcrypt_msgtype6.c
@@ -572,9 +572,9 @@ static int convert_type86_ica(struct zcrypt_device *zdev,
                         return -EINVAL;
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%drc%d",
-                               zdev->ap_dev->qid, zdev->online,
+                               AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online,
                                msg->hdr.reply_code);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
@@ -715,9 +715,9 @@ static int convert_response_ica(struct zcrypt_device *zdev,
         default: /* Unknown response type, this should NEVER EVER happen */
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%dfail",
-                               zdev->ap_dev->qid, zdev->online);
+                               AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
 }
@@ -747,9 +747,9 @@ static int convert_response_xcrb(struct zcrypt_device *zdev,
                 xcRB->status = 0x0008044DL; /* HDD_InvalidParm */
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%dfail",
-                               zdev->ap_dev->qid, zdev->online);
+                               AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
 }
@@ -773,9 +773,9 @@ static int convert_response_ep11_xcrb(struct zcrypt_device *zdev,
         default: /* Unknown response type, this should NEVER EVER happen */
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%dfail",
-                               zdev->ap_dev->qid, zdev->online);
+                               AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
 }
@@ -800,9 +800,9 @@ static int convert_response_rng(struct zcrypt_device *zdev,
         default: /* Unknown response type, this should NEVER EVER happen */
                 zdev->online = 0;
                 pr_err("Cryptographic device %x failed and was set offline\n",
-                       zdev->ap_dev->qid);
+                       AP_QID_DEVICE(zdev->ap_dev->qid));
                 ZCRYPT_DBF_DEV(DBF_ERR, zdev, "dev%04xo%dfail",
-                               zdev->ap_dev->qid, zdev->online);
+                               AP_QID_DEVICE(zdev->ap_dev->qid), zdev->online);
                 return -EAGAIN; /* repeat the request on a different device. */
         }
 }