aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLiam Breck <liam@networkimprov.net>2017-01-18 12:26:48 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-05-14 08:00:14 -0400
commitd8d6aedd54ce583b31aceef491adb2419f2b4ac6 (patch)
treee8a362a68de3471a7687e4f8bb3daf1c98ba5fd5
parent89e8bd3add69debe228842e73b1df9925b44eb6e (diff)
power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING
commit 767eee362fd72bb2ca44cc80419ca4b38c6d8369 upstream. The interrupt signal is TRIGGER_FALLING. This is is specified in the data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us pulse to host to report charger device status and fault." Also the direction can be seen in the data sheet Figure 37 "BQ24190 with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k pull-up resistor installed for the sample configurations. Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger") Signed-off-by: Liam Breck <kernel@networkimprov.net> Acked-by: Mark Greer <mgreer@animalcreek.com> Acked-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Sebastian Reichel <sre@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/power/supply/bq24190_charger.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index e9584330aeed..21a149f8046e 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -1394,7 +1394,7 @@ static int bq24190_probe(struct i2c_client *client,
1394 1394
1395 ret = devm_request_threaded_irq(dev, bdi->irq, NULL, 1395 ret = devm_request_threaded_irq(dev, bdi->irq, NULL,
1396 bq24190_irq_handler_thread, 1396 bq24190_irq_handler_thread,
1397 IRQF_TRIGGER_RISING | IRQF_ONESHOT, 1397 IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
1398 "bq24190-charger", bdi); 1398 "bq24190-charger", bdi);
1399 if (ret < 0) { 1399 if (ret < 0) {
1400 dev_err(dev, "Can't set up irq handler\n"); 1400 dev_err(dev, "Can't set up irq handler\n");