aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaxman Dewangan <ldewangan@nvidia.com>2016-02-24 04:14:07 -0500
committerLinus Walleij <linus.walleij@linaro.org>2016-04-20 18:03:18 -0400
commitd39de3139180ff90d43a5f4093ada4b31af40e9d (patch)
treeb867a740ec573c01f580a12d7a75f122c17ea50e
parent67ec8d7b484639040b7a75b289a2a1d1763e3430 (diff)
pinctrl: spear: Use devm_pinctrl_register() for pinctrl registration
Use devm_pinctrl_register() for pin control registration and remove need of .remove callback. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Cc: Viresh Kumar <vireshk@kernel.org> Cc: spear-devel@list.st.com Cc: linux-arm-kernel@lists.infradead.org Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear.c11
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear.h1
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear1310.c6
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear1340.c6
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear300.c6
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear310.c6
-rw-r--r--drivers/pinctrl/spear/pinctrl-spear320.c6
7 files changed, 1 insertions, 41 deletions
diff --git a/drivers/pinctrl/spear/pinctrl-spear.c b/drivers/pinctrl/spear/pinctrl-spear.c
index 0afaf79a4e51..4db52ba38d8d 100644
--- a/drivers/pinctrl/spear/pinctrl-spear.c
+++ b/drivers/pinctrl/spear/pinctrl-spear.c
@@ -395,7 +395,7 @@ int spear_pinctrl_probe(struct platform_device *pdev,
395 spear_pinctrl_desc.pins = machdata->pins; 395 spear_pinctrl_desc.pins = machdata->pins;
396 spear_pinctrl_desc.npins = machdata->npins; 396 spear_pinctrl_desc.npins = machdata->npins;
397 397
398 pmx->pctl = pinctrl_register(&spear_pinctrl_desc, &pdev->dev, pmx); 398 pmx->pctl = devm_pinctrl_register(&pdev->dev, &spear_pinctrl_desc, pmx);
399 if (IS_ERR(pmx->pctl)) { 399 if (IS_ERR(pmx->pctl)) {
400 dev_err(&pdev->dev, "Couldn't register pinctrl driver\n"); 400 dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
401 return PTR_ERR(pmx->pctl); 401 return PTR_ERR(pmx->pctl);
@@ -403,12 +403,3 @@ int spear_pinctrl_probe(struct platform_device *pdev,
403 403
404 return 0; 404 return 0;
405} 405}
406
407int spear_pinctrl_remove(struct platform_device *pdev)
408{
409 struct spear_pmx *pmx = platform_get_drvdata(pdev);
410
411 pinctrl_unregister(pmx->pctl);
412
413 return 0;
414}
diff --git a/drivers/pinctrl/spear/pinctrl-spear.h b/drivers/pinctrl/spear/pinctrl-spear.h
index 27c2cc8d83ad..aa5cf7032231 100644
--- a/drivers/pinctrl/spear/pinctrl-spear.h
+++ b/drivers/pinctrl/spear/pinctrl-spear.h
@@ -197,7 +197,6 @@ void pmx_init_gpio_pingroup_addr(struct spear_gpio_pingroup *gpio_pingroup,
197 unsigned count, u16 reg); 197 unsigned count, u16 reg);
198int spear_pinctrl_probe(struct platform_device *pdev, 198int spear_pinctrl_probe(struct platform_device *pdev,
199 struct spear_pinctrl_machdata *machdata); 199 struct spear_pinctrl_machdata *machdata);
200int spear_pinctrl_remove(struct platform_device *pdev);
201 200
202#define SPEAR_PIN_0_TO_101 \ 201#define SPEAR_PIN_0_TO_101 \
203 PINCTRL_PIN(0, "PLGPIO0"), \ 202 PINCTRL_PIN(0, "PLGPIO0"), \
diff --git a/drivers/pinctrl/spear/pinctrl-spear1310.c b/drivers/pinctrl/spear/pinctrl-spear1310.c
index 92611bb757ac..18210681c737 100644
--- a/drivers/pinctrl/spear/pinctrl-spear1310.c
+++ b/drivers/pinctrl/spear/pinctrl-spear1310.c
@@ -2704,18 +2704,12 @@ static int spear1310_pinctrl_probe(struct platform_device *pdev)
2704 return spear_pinctrl_probe(pdev, &spear1310_machdata); 2704 return spear_pinctrl_probe(pdev, &spear1310_machdata);
2705} 2705}
2706 2706
2707static int spear1310_pinctrl_remove(struct platform_device *pdev)
2708{
2709 return spear_pinctrl_remove(pdev);
2710}
2711
2712static struct platform_driver spear1310_pinctrl_driver = { 2707static struct platform_driver spear1310_pinctrl_driver = {
2713 .driver = { 2708 .driver = {
2714 .name = DRIVER_NAME, 2709 .name = DRIVER_NAME,
2715 .of_match_table = spear1310_pinctrl_of_match, 2710 .of_match_table = spear1310_pinctrl_of_match,
2716 }, 2711 },
2717 .probe = spear1310_pinctrl_probe, 2712 .probe = spear1310_pinctrl_probe,
2718 .remove = spear1310_pinctrl_remove,
2719}; 2713};
2720 2714
2721static int __init spear1310_pinctrl_init(void) 2715static int __init spear1310_pinctrl_init(void)
diff --git a/drivers/pinctrl/spear/pinctrl-spear1340.c b/drivers/pinctrl/spear/pinctrl-spear1340.c
index f842e9dc40d0..c01fb23ee636 100644
--- a/drivers/pinctrl/spear/pinctrl-spear1340.c
+++ b/drivers/pinctrl/spear/pinctrl-spear1340.c
@@ -2020,18 +2020,12 @@ static int spear1340_pinctrl_probe(struct platform_device *pdev)
2020 return spear_pinctrl_probe(pdev, &spear1340_machdata); 2020 return spear_pinctrl_probe(pdev, &spear1340_machdata);
2021} 2021}
2022 2022
2023static int spear1340_pinctrl_remove(struct platform_device *pdev)
2024{
2025 return spear_pinctrl_remove(pdev);
2026}
2027
2028static struct platform_driver spear1340_pinctrl_driver = { 2023static struct platform_driver spear1340_pinctrl_driver = {
2029 .driver = { 2024 .driver = {
2030 .name = DRIVER_NAME, 2025 .name = DRIVER_NAME,
2031 .of_match_table = spear1340_pinctrl_of_match, 2026 .of_match_table = spear1340_pinctrl_of_match,
2032 }, 2027 },
2033 .probe = spear1340_pinctrl_probe, 2028 .probe = spear1340_pinctrl_probe,
2034 .remove = spear1340_pinctrl_remove,
2035}; 2029};
2036 2030
2037static int __init spear1340_pinctrl_init(void) 2031static int __init spear1340_pinctrl_init(void)
diff --git a/drivers/pinctrl/spear/pinctrl-spear300.c b/drivers/pinctrl/spear/pinctrl-spear300.c
index d998a2ccff48..111148daa3f1 100644
--- a/drivers/pinctrl/spear/pinctrl-spear300.c
+++ b/drivers/pinctrl/spear/pinctrl-spear300.c
@@ -677,18 +677,12 @@ static int spear300_pinctrl_probe(struct platform_device *pdev)
677 return 0; 677 return 0;
678} 678}
679 679
680static int spear300_pinctrl_remove(struct platform_device *pdev)
681{
682 return spear_pinctrl_remove(pdev);
683}
684
685static struct platform_driver spear300_pinctrl_driver = { 680static struct platform_driver spear300_pinctrl_driver = {
686 .driver = { 681 .driver = {
687 .name = DRIVER_NAME, 682 .name = DRIVER_NAME,
688 .of_match_table = spear300_pinctrl_of_match, 683 .of_match_table = spear300_pinctrl_of_match,
689 }, 684 },
690 .probe = spear300_pinctrl_probe, 685 .probe = spear300_pinctrl_probe,
691 .remove = spear300_pinctrl_remove,
692}; 686};
693 687
694static int __init spear300_pinctrl_init(void) 688static int __init spear300_pinctrl_init(void)
diff --git a/drivers/pinctrl/spear/pinctrl-spear310.c b/drivers/pinctrl/spear/pinctrl-spear310.c
index 609b18aceb16..a7b000062985 100644
--- a/drivers/pinctrl/spear/pinctrl-spear310.c
+++ b/drivers/pinctrl/spear/pinctrl-spear310.c
@@ -400,18 +400,12 @@ static int spear310_pinctrl_probe(struct platform_device *pdev)
400 return 0; 400 return 0;
401} 401}
402 402
403static int spear310_pinctrl_remove(struct platform_device *pdev)
404{
405 return spear_pinctrl_remove(pdev);
406}
407
408static struct platform_driver spear310_pinctrl_driver = { 403static struct platform_driver spear310_pinctrl_driver = {
409 .driver = { 404 .driver = {
410 .name = DRIVER_NAME, 405 .name = DRIVER_NAME,
411 .of_match_table = spear310_pinctrl_of_match, 406 .of_match_table = spear310_pinctrl_of_match,
412 }, 407 },
413 .probe = spear310_pinctrl_probe, 408 .probe = spear310_pinctrl_probe,
414 .remove = spear310_pinctrl_remove,
415}; 409};
416 410
417static int __init spear310_pinctrl_init(void) 411static int __init spear310_pinctrl_init(void)
diff --git a/drivers/pinctrl/spear/pinctrl-spear320.c b/drivers/pinctrl/spear/pinctrl-spear320.c
index c07114431bd4..e2b3817701dc 100644
--- a/drivers/pinctrl/spear/pinctrl-spear320.c
+++ b/drivers/pinctrl/spear/pinctrl-spear320.c
@@ -3441,18 +3441,12 @@ static int spear320_pinctrl_probe(struct platform_device *pdev)
3441 return 0; 3441 return 0;
3442} 3442}
3443 3443
3444static int spear320_pinctrl_remove(struct platform_device *pdev)
3445{
3446 return spear_pinctrl_remove(pdev);
3447}
3448
3449static struct platform_driver spear320_pinctrl_driver = { 3444static struct platform_driver spear320_pinctrl_driver = {
3450 .driver = { 3445 .driver = {
3451 .name = DRIVER_NAME, 3446 .name = DRIVER_NAME,
3452 .of_match_table = spear320_pinctrl_of_match, 3447 .of_match_table = spear320_pinctrl_of_match,
3453 }, 3448 },
3454 .probe = spear320_pinctrl_probe, 3449 .probe = spear320_pinctrl_probe,
3455 .remove = spear320_pinctrl_remove,
3456}; 3450};
3457 3451
3458static int __init spear320_pinctrl_init(void) 3452static int __init spear320_pinctrl_init(void)