diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2011-07-25 20:12:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-07-25 23:57:09 -0400 |
commit | c9d8c3d0896bfa5b57531ecc41a85ffbc6d87dbe (patch) | |
tree | 0de7519c20e066c820d37ff32be319745e7a2f8e | |
parent | be8f684d73d8d916847e996bf69cef14352872c6 (diff) |
mm/memblock.c: avoid abuse of RED_INACTIVE
RED_INACTIVE is a slab thing, and reusing it for memblock was
inappropriate, because memblock is dealing with phys_addr_t's which have a
Kconfigurable sizeof().
Create a new poison type for this application. Fixes the sparse warning
warning: cast truncates bits from constant value (9f911029d74e35b becomes 9d74e35b)
Reported-by: H Hartley Sweeten <hartleys@visionengravers.com>
Tested-by: H Hartley Sweeten <hartleys@visionengravers.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/linux/poison.h | 6 | ||||
-rw-r--r-- | mm/memblock.c | 8 |
2 files changed, 10 insertions, 4 deletions
diff --git a/include/linux/poison.h b/include/linux/poison.h index 2110a81c5e2a..79159de0e341 100644 --- a/include/linux/poison.h +++ b/include/linux/poison.h | |||
@@ -40,6 +40,12 @@ | |||
40 | #define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */ | 40 | #define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */ |
41 | #define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */ | 41 | #define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */ |
42 | 42 | ||
43 | #ifdef CONFIG_PHYS_ADDR_T_64BIT | ||
44 | #define MEMBLOCK_INACTIVE 0x3a84fb0144c9e71bULL | ||
45 | #else | ||
46 | #define MEMBLOCK_INACTIVE 0x44c9e71bUL | ||
47 | #endif | ||
48 | |||
43 | #define SLUB_RED_INACTIVE 0xbb | 49 | #define SLUB_RED_INACTIVE 0xbb |
44 | #define SLUB_RED_ACTIVE 0xcc | 50 | #define SLUB_RED_ACTIVE 0xcc |
45 | 51 | ||
diff --git a/mm/memblock.c b/mm/memblock.c index a0562d1a6ad4..ccbf97339592 100644 --- a/mm/memblock.c +++ b/mm/memblock.c | |||
@@ -758,9 +758,9 @@ void __init memblock_analyze(void) | |||
758 | 758 | ||
759 | /* Check marker in the unused last array entry */ | 759 | /* Check marker in the unused last array entry */ |
760 | WARN_ON(memblock_memory_init_regions[INIT_MEMBLOCK_REGIONS].base | 760 | WARN_ON(memblock_memory_init_regions[INIT_MEMBLOCK_REGIONS].base |
761 | != (phys_addr_t)RED_INACTIVE); | 761 | != MEMBLOCK_INACTIVE); |
762 | WARN_ON(memblock_reserved_init_regions[INIT_MEMBLOCK_REGIONS].base | 762 | WARN_ON(memblock_reserved_init_regions[INIT_MEMBLOCK_REGIONS].base |
763 | != (phys_addr_t)RED_INACTIVE); | 763 | != MEMBLOCK_INACTIVE); |
764 | 764 | ||
765 | memblock.memory_size = 0; | 765 | memblock.memory_size = 0; |
766 | 766 | ||
@@ -786,8 +786,8 @@ void __init memblock_init(void) | |||
786 | memblock.reserved.max = INIT_MEMBLOCK_REGIONS; | 786 | memblock.reserved.max = INIT_MEMBLOCK_REGIONS; |
787 | 787 | ||
788 | /* Write a marker in the unused last array entry */ | 788 | /* Write a marker in the unused last array entry */ |
789 | memblock.memory.regions[INIT_MEMBLOCK_REGIONS].base = (phys_addr_t)RED_INACTIVE; | 789 | memblock.memory.regions[INIT_MEMBLOCK_REGIONS].base = MEMBLOCK_INACTIVE; |
790 | memblock.reserved.regions[INIT_MEMBLOCK_REGIONS].base = (phys_addr_t)RED_INACTIVE; | 790 | memblock.reserved.regions[INIT_MEMBLOCK_REGIONS].base = MEMBLOCK_INACTIVE; |
791 | 791 | ||
792 | /* Create a dummy zero size MEMBLOCK which will get coalesced away later. | 792 | /* Create a dummy zero size MEMBLOCK which will get coalesced away later. |
793 | * This simplifies the memblock_add() code below... | 793 | * This simplifies the memblock_add() code below... |