aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChunming Zhou <David1.Zhou@amd.com>2015-12-10 02:50:02 -0500
committerAlex Deucher <alexander.deucher@amd.com>2015-12-14 19:42:11 -0500
commitc648ed7c5c7f0e3bb4ab11bf08bccf99b42a4cbb (patch)
treea795fe668e3c3459ecf53cc5823ee09b41e8c8e2
parente8deea2d4bb441751a4c1730495fa9810a208de5 (diff)
drm/amdgpu: handle error case for ctx
Properly handle ctx init failure. Signed-off-by: Chunming Zhou <David1.Zhou@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
index c1f2308b4115..15e341634536 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
@@ -56,7 +56,6 @@ int amdgpu_ctx_init(struct amdgpu_device *adev, enum amd_sched_priority pri,
56 for (j = 0; j < i; j++) 56 for (j = 0; j < i; j++)
57 amd_sched_entity_fini(&adev->rings[j]->sched, 57 amd_sched_entity_fini(&adev->rings[j]->sched,
58 &ctx->rings[j].entity); 58 &ctx->rings[j].entity);
59 kfree(ctx);
60 return r; 59 return r;
61 } 60 }
62 } 61 }
@@ -103,8 +102,12 @@ static int amdgpu_ctx_alloc(struct amdgpu_device *adev,
103 } 102 }
104 *id = (uint32_t)r; 103 *id = (uint32_t)r;
105 r = amdgpu_ctx_init(adev, AMD_SCHED_PRIORITY_NORMAL, ctx); 104 r = amdgpu_ctx_init(adev, AMD_SCHED_PRIORITY_NORMAL, ctx);
105 if (r) {
106 idr_remove(&mgr->ctx_handles, *id);
107 *id = 0;
108 kfree(ctx);
109 }
106 mutex_unlock(&mgr->lock); 110 mutex_unlock(&mgr->lock);
107
108 return r; 111 return r;
109} 112}
110 113