diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2016-10-04 16:36:19 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-10-04 16:36:19 -0400 |
commit | c35bcfd8e4e11bdff2ffab823a13a59968426b15 (patch) | |
tree | fa3df11bfa937a8e5c456b445ccff085e70e78ed | |
parent | ce866e2d182b9e00e29e7a2eed4db908257d7f79 (diff) | |
parent | d67fd44f697dff293d7cdc29af929241b669affe (diff) |
Merge tag 'locks-v4.9-1' of git://git.samba.org/jlayton/linux
Pull file locking updates from Jeff Layton:
"Only a single patch from Nikolay this cycle, with a small change to
better handle /proc/locks in a containerized host"
* tag 'locks-v4.9-1' of git://git.samba.org/jlayton/linux:
locks: Filter /proc/locks output on proc pid ns
-rw-r--r-- | fs/locks.c | 21 |
1 files changed, 18 insertions, 3 deletions
diff --git a/fs/locks.c b/fs/locks.c index 133fb2543d21..90ec67108b22 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -2603,9 +2603,20 @@ static void lock_get_status(struct seq_file *f, struct file_lock *fl, | |||
2603 | struct inode *inode = NULL; | 2603 | struct inode *inode = NULL; |
2604 | unsigned int fl_pid; | 2604 | unsigned int fl_pid; |
2605 | 2605 | ||
2606 | if (fl->fl_nspid) | 2606 | if (fl->fl_nspid) { |
2607 | fl_pid = pid_vnr(fl->fl_nspid); | 2607 | struct pid_namespace *proc_pidns = file_inode(f->file)->i_sb->s_fs_info; |
2608 | else | 2608 | |
2609 | /* Don't let fl_pid change based on who is reading the file */ | ||
2610 | fl_pid = pid_nr_ns(fl->fl_nspid, proc_pidns); | ||
2611 | |||
2612 | /* | ||
2613 | * If there isn't a fl_pid don't display who is waiting on | ||
2614 | * the lock if we are called from locks_show, or if we are | ||
2615 | * called from __show_fd_info - skip lock entirely | ||
2616 | */ | ||
2617 | if (fl_pid == 0) | ||
2618 | return; | ||
2619 | } else | ||
2609 | fl_pid = fl->fl_pid; | 2620 | fl_pid = fl->fl_pid; |
2610 | 2621 | ||
2611 | if (fl->fl_file != NULL) | 2622 | if (fl->fl_file != NULL) |
@@ -2677,9 +2688,13 @@ static int locks_show(struct seq_file *f, void *v) | |||
2677 | { | 2688 | { |
2678 | struct locks_iterator *iter = f->private; | 2689 | struct locks_iterator *iter = f->private; |
2679 | struct file_lock *fl, *bfl; | 2690 | struct file_lock *fl, *bfl; |
2691 | struct pid_namespace *proc_pidns = file_inode(f->file)->i_sb->s_fs_info; | ||
2680 | 2692 | ||
2681 | fl = hlist_entry(v, struct file_lock, fl_link); | 2693 | fl = hlist_entry(v, struct file_lock, fl_link); |
2682 | 2694 | ||
2695 | if (fl->fl_nspid && !pid_nr_ns(fl->fl_nspid, proc_pidns)) | ||
2696 | return 0; | ||
2697 | |||
2683 | lock_get_status(f, fl, iter->li_pos, ""); | 2698 | lock_get_status(f, fl, iter->li_pos, ""); |
2684 | 2699 | ||
2685 | list_for_each_entry(bfl, &fl->fl_block, fl_block) | 2700 | list_for_each_entry(bfl, &fl->fl_block, fl_block) |