aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Hocko <mhocko@suse.com>2016-05-23 19:26:17 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2016-05-23 20:04:14 -0400
commitb5637051f1ed48f68370234e879d40d8dd4ab087 (patch)
tree2e070c386b74fa8170b577f765e556e3e4d65d30
parent2267c2999b49682ae4801dab3b1ac96584f57da0 (diff)
drm/amdgpu: make amdgpu_mn_get wait for mmap_sem killable
amdgpu_mn_get which is called during ioct path relies on mmap_sem for write. If the waiting task gets killed by the oom killer it would block oom_reaper from asynchronous address space reclaim and reduce the chances of timely OOM resolving. Wait for the lock in the killable mode and return with EINTR if the task got killed while waiting. [arnd@arndb.de: use ERR_PTR() to return from amdgpu_mn_get] Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Christian König <christian.koenig@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
index 9f4a45cd2aab..32fa7b7913f7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
@@ -232,7 +232,10 @@ static struct amdgpu_mn *amdgpu_mn_get(struct amdgpu_device *adev)
232 int r; 232 int r;
233 233
234 mutex_lock(&adev->mn_lock); 234 mutex_lock(&adev->mn_lock);
235 down_write(&mm->mmap_sem); 235 if (down_write_killable(&mm->mmap_sem)) {
236 mutex_unlock(&adev->mn_lock);
237 return ERR_PTR(-EINTR);
238 }
236 239
237 hash_for_each_possible(adev->mn_hash, rmn, node, (unsigned long)mm) 240 hash_for_each_possible(adev->mn_hash, rmn, node, (unsigned long)mm)
238 if (rmn->mm == mm) 241 if (rmn->mm == mm)