aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarlos Palminha <CARLOS.PALMINHA@synopsys.com>2016-02-16 09:17:45 -0500
committerDaniel Vetter <daniel.vetter@ffwll.ch>2016-03-04 11:58:34 -0500
commitafe7ef916652ec34fb35a038f6faeafef98c988a (patch)
treee9b2533752debeb1c8b249e8d22cd5b236e40bad
parent1323963f96d30e15fa6972511048fe90bc15c958 (diff)
drm/gma: removed optional dummy crtc mode_fixup function.
This patch set nukes all the dummy crtc mode_fixup implementations. (made on top of Daniel topic/drm-misc branch) Signed-off-by: Carlos Palminha <palminha@synopsys.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/gma500/cdv_intel_display.c13
-rw-r--r--drivers/gpu/drm/gma500/gma_display.c7
-rw-r--r--drivers/gpu/drm/gma500/gma_display.h3
-rw-r--r--drivers/gpu/drm/gma500/mdfld_intel_display.c2
-rw-r--r--drivers/gpu/drm/gma500/oaktrail_crtc.c1
-rw-r--r--drivers/gpu/drm/gma500/psb_intel_display.c1
6 files changed, 6 insertions, 21 deletions
diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
index 6126546295e9..17db4b4749d5 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_display.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
@@ -116,7 +116,7 @@ static const struct gma_limit_t cdv_intel_limits[] = {
116 .p1 = {.min = 1, .max = 10}, 116 .p1 = {.min = 1, .max = 10},
117 .p2 = {.dot_limit = 225000, .p2_slow = 10, .p2_fast = 10}, 117 .p2 = {.dot_limit = 225000, .p2_slow = 10, .p2_fast = 10},
118 .find_pll = cdv_intel_find_dp_pll, 118 .find_pll = cdv_intel_find_dp_pll,
119 } 119 }
120}; 120};
121 121
122#define _wait_for(COND, MS, W) ({ \ 122#define _wait_for(COND, MS, W) ({ \
@@ -245,7 +245,7 @@ cdv_dpll_set_clock_cdv(struct drm_device *dev, struct drm_crtc *crtc,
245 /* We don't know what the other fields of these regs are, so 245 /* We don't know what the other fields of these regs are, so
246 * leave them in place. 246 * leave them in place.
247 */ 247 */
248 /* 248 /*
249 * The BIT 14:13 of 0x8010/0x8030 is used to select the ref clk 249 * The BIT 14:13 of 0x8010/0x8030 is used to select the ref clk
250 * for the pipe A/B. Display spec 1.06 has wrong definition. 250 * for the pipe A/B. Display spec 1.06 has wrong definition.
251 * Correct definition is like below: 251 * Correct definition is like below:
@@ -256,7 +256,7 @@ cdv_dpll_set_clock_cdv(struct drm_device *dev, struct drm_crtc *crtc,
256 * 256 *
257 * if DPLLA sets 01 and DPLLB sets 02, both use clk from DPLLA 257 * if DPLLA sets 01 and DPLLB sets 02, both use clk from DPLLA
258 * 258 *
259 */ 259 */
260 ret = cdv_sb_read(dev, ref_sfr, &ref_value); 260 ret = cdv_sb_read(dev, ref_sfr, &ref_value);
261 if (ret) 261 if (ret)
262 return ret; 262 return ret;
@@ -646,7 +646,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
646 * for DP/eDP. When using SSC clock, the ref clk is 100MHz.Otherwise 646 * for DP/eDP. When using SSC clock, the ref clk is 100MHz.Otherwise
647 * it will be 27MHz. From the VBIOS code it seems that the pipe A choose 647 * it will be 27MHz. From the VBIOS code it seems that the pipe A choose
648 * 27MHz for DP/eDP while the Pipe B chooses the 100MHz. 648 * 27MHz for DP/eDP while the Pipe B chooses the 100MHz.
649 */ 649 */
650 if (pipe == 0) 650 if (pipe == 0)
651 refclk = 27000; 651 refclk = 27000;
652 else 652 else
@@ -659,7 +659,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
659 } 659 }
660 660
661 drm_mode_debug_printmodeline(adjusted_mode); 661 drm_mode_debug_printmodeline(adjusted_mode);
662 662
663 limit = gma_crtc->clock_funcs->limit(crtc, refclk); 663 limit = gma_crtc->clock_funcs->limit(crtc, refclk);
664 664
665 ok = limit->find_pll(limit, crtc, adjusted_mode->clock, refclk, 665 ok = limit->find_pll(limit, crtc, adjusted_mode->clock, refclk,
@@ -721,7 +721,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
721 pipeconf |= PIPE_6BPC; 721 pipeconf |= PIPE_6BPC;
722 } else 722 } else
723 pipeconf |= PIPE_8BPC; 723 pipeconf |= PIPE_8BPC;
724 724
725 /* Set up the display plane register */ 725 /* Set up the display plane register */
726 dspcntr = DISPPLANE_GAMMA_ENABLE; 726 dspcntr = DISPPLANE_GAMMA_ENABLE;
727 727
@@ -974,7 +974,6 @@ struct drm_display_mode *cdv_intel_crtc_mode_get(struct drm_device *dev,
974 974
975const struct drm_crtc_helper_funcs cdv_intel_helper_funcs = { 975const struct drm_crtc_helper_funcs cdv_intel_helper_funcs = {
976 .dpms = gma_crtc_dpms, 976 .dpms = gma_crtc_dpms,
977 .mode_fixup = gma_crtc_mode_fixup,
978 .mode_set = cdv_intel_crtc_mode_set, 977 .mode_set = cdv_intel_crtc_mode_set,
979 .mode_set_base = gma_pipe_set_base, 978 .mode_set_base = gma_pipe_set_base,
980 .prepare = gma_crtc_prepare, 979 .prepare = gma_crtc_prepare,
diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
index 927082148d4d..5bf765de2517 100644
--- a/drivers/gpu/drm/gma500/gma_display.c
+++ b/drivers/gpu/drm/gma500/gma_display.c
@@ -478,13 +478,6 @@ int gma_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
478 return 0; 478 return 0;
479} 479}
480 480
481bool gma_crtc_mode_fixup(struct drm_crtc *crtc,
482 const struct drm_display_mode *mode,
483 struct drm_display_mode *adjusted_mode)
484{
485 return true;
486}
487
488void gma_crtc_prepare(struct drm_crtc *crtc) 481void gma_crtc_prepare(struct drm_crtc *crtc)
489{ 482{
490 const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private; 483 const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
diff --git a/drivers/gpu/drm/gma500/gma_display.h b/drivers/gpu/drm/gma500/gma_display.h
index 78b9f986a6e5..b2491c65f053 100644
--- a/drivers/gpu/drm/gma500/gma_display.h
+++ b/drivers/gpu/drm/gma500/gma_display.h
@@ -75,9 +75,6 @@ extern void gma_crtc_load_lut(struct drm_crtc *crtc);
75extern void gma_crtc_gamma_set(struct drm_crtc *crtc, u16 *red, u16 *green, 75extern void gma_crtc_gamma_set(struct drm_crtc *crtc, u16 *red, u16 *green,
76 u16 *blue, u32 start, u32 size); 76 u16 *blue, u32 start, u32 size);
77extern void gma_crtc_dpms(struct drm_crtc *crtc, int mode); 77extern void gma_crtc_dpms(struct drm_crtc *crtc, int mode);
78extern bool gma_crtc_mode_fixup(struct drm_crtc *crtc,
79 const struct drm_display_mode *mode,
80 struct drm_display_mode *adjusted_mode);
81extern void gma_crtc_prepare(struct drm_crtc *crtc); 78extern void gma_crtc_prepare(struct drm_crtc *crtc);
82extern void gma_crtc_commit(struct drm_crtc *crtc); 79extern void gma_crtc_commit(struct drm_crtc *crtc);
83extern void gma_crtc_disable(struct drm_crtc *crtc); 80extern void gma_crtc_disable(struct drm_crtc *crtc);
diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
index acd38344b302..92e3f93ee682 100644
--- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
+++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
@@ -1026,10 +1026,8 @@ mrst_crtc_mode_set_exit:
1026 1026
1027const struct drm_crtc_helper_funcs mdfld_helper_funcs = { 1027const struct drm_crtc_helper_funcs mdfld_helper_funcs = {
1028 .dpms = mdfld_crtc_dpms, 1028 .dpms = mdfld_crtc_dpms,
1029 .mode_fixup = gma_crtc_mode_fixup,
1030 .mode_set = mdfld_crtc_mode_set, 1029 .mode_set = mdfld_crtc_mode_set,
1031 .mode_set_base = mdfld__intel_pipe_set_base, 1030 .mode_set_base = mdfld__intel_pipe_set_base,
1032 .prepare = gma_crtc_prepare, 1031 .prepare = gma_crtc_prepare,
1033 .commit = gma_crtc_commit, 1032 .commit = gma_crtc_commit,
1034}; 1033};
1035
diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
index 1048f0c7c6ce..da9fd34b9550 100644
--- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
+++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
@@ -657,7 +657,6 @@ pipe_set_base_exit:
657 657
658const struct drm_crtc_helper_funcs oaktrail_helper_funcs = { 658const struct drm_crtc_helper_funcs oaktrail_helper_funcs = {
659 .dpms = oaktrail_crtc_dpms, 659 .dpms = oaktrail_crtc_dpms,
660 .mode_fixup = gma_crtc_mode_fixup,
661 .mode_set = oaktrail_crtc_mode_set, 660 .mode_set = oaktrail_crtc_mode_set,
662 .mode_set_base = oaktrail_pipe_set_base, 661 .mode_set_base = oaktrail_pipe_set_base,
663 .prepare = gma_crtc_prepare, 662 .prepare = gma_crtc_prepare,
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
index dcdbc37e55e1..398015be87e4 100644
--- a/drivers/gpu/drm/gma500/psb_intel_display.c
+++ b/drivers/gpu/drm/gma500/psb_intel_display.c
@@ -430,7 +430,6 @@ struct drm_display_mode *psb_intel_crtc_mode_get(struct drm_device *dev,
430 430
431const struct drm_crtc_helper_funcs psb_intel_helper_funcs = { 431const struct drm_crtc_helper_funcs psb_intel_helper_funcs = {
432 .dpms = gma_crtc_dpms, 432 .dpms = gma_crtc_dpms,
433 .mode_fixup = gma_crtc_mode_fixup,
434 .mode_set = psb_intel_crtc_mode_set, 433 .mode_set = psb_intel_crtc_mode_set,
435 .mode_set_base = gma_pipe_set_base, 434 .mode_set_base = gma_pipe_set_base,
436 .prepare = gma_crtc_prepare, 435 .prepare = gma_crtc_prepare,