diff options
author | Guillaume Nault <g.nault@alphalink.fr> | 2015-11-19 06:53:21 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-11-20 11:31:26 -0500 |
commit | a8acce6aa584aa731a2bed240bcd8dc955f01414 (patch) | |
tree | 6be6919c595cac8d7a394fdcc29a5f9e4d68e4b2 | |
parent | 8734e485fed5fc5ce8b03aebfc2681e2de662838 (diff) |
ppp: remove PPPOX_ZOMBIE socket state
PPPOX_ZOMBIE is never set anymore.
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ppp/pppoe.c | 4 | ||||
-rw-r--r-- | drivers/net/ppp/pppox.c | 2 | ||||
-rw-r--r-- | include/linux/if_pppox.h | 1 |
3 files changed, 3 insertions, 4 deletions
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index 1dedfbf1d423..277e6827d7cd 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c | |||
@@ -311,7 +311,7 @@ static void pppoe_flush_dev(struct net_device *dev) | |||
311 | lock_sock(sk); | 311 | lock_sock(sk); |
312 | 312 | ||
313 | if (po->pppoe_dev == dev && | 313 | if (po->pppoe_dev == dev && |
314 | sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND | PPPOX_ZOMBIE)) { | 314 | sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND)) { |
315 | pppox_unbind_sock(sk); | 315 | pppox_unbind_sock(sk); |
316 | sk->sk_state_change(sk); | 316 | sk->sk_state_change(sk); |
317 | po->pppoe_dev = NULL; | 317 | po->pppoe_dev = NULL; |
@@ -775,7 +775,7 @@ static int pppoe_ioctl(struct socket *sock, unsigned int cmd, | |||
775 | struct pppox_sock *relay_po; | 775 | struct pppox_sock *relay_po; |
776 | 776 | ||
777 | err = -EBUSY; | 777 | err = -EBUSY; |
778 | if (sk->sk_state & (PPPOX_BOUND | PPPOX_ZOMBIE | PPPOX_DEAD)) | 778 | if (sk->sk_state & (PPPOX_BOUND | PPPOX_DEAD)) |
779 | break; | 779 | break; |
780 | 780 | ||
781 | err = -ENOTCONN; | 781 | err = -ENOTCONN; |
diff --git a/drivers/net/ppp/pppox.c b/drivers/net/ppp/pppox.c index 0e1b30622477..0200de74eebc 100644 --- a/drivers/net/ppp/pppox.c +++ b/drivers/net/ppp/pppox.c | |||
@@ -58,7 +58,7 @@ void pppox_unbind_sock(struct sock *sk) | |||
58 | { | 58 | { |
59 | /* Clear connection to ppp device, if attached. */ | 59 | /* Clear connection to ppp device, if attached. */ |
60 | 60 | ||
61 | if (sk->sk_state & (PPPOX_BOUND | PPPOX_CONNECTED | PPPOX_ZOMBIE)) { | 61 | if (sk->sk_state & (PPPOX_BOUND | PPPOX_CONNECTED)) { |
62 | ppp_unregister_channel(&pppox_sk(sk)->chan); | 62 | ppp_unregister_channel(&pppox_sk(sk)->chan); |
63 | sk->sk_state = PPPOX_DEAD; | 63 | sk->sk_state = PPPOX_DEAD; |
64 | } | 64 | } |
diff --git a/include/linux/if_pppox.h b/include/linux/if_pppox.h index b49cf923becc..ba7a9b0c7c57 100644 --- a/include/linux/if_pppox.h +++ b/include/linux/if_pppox.h | |||
@@ -91,7 +91,6 @@ enum { | |||
91 | PPPOX_CONNECTED = 1, /* connection established ==TCP_ESTABLISHED */ | 91 | PPPOX_CONNECTED = 1, /* connection established ==TCP_ESTABLISHED */ |
92 | PPPOX_BOUND = 2, /* bound to ppp device */ | 92 | PPPOX_BOUND = 2, /* bound to ppp device */ |
93 | PPPOX_RELAY = 4, /* forwarding is enabled */ | 93 | PPPOX_RELAY = 4, /* forwarding is enabled */ |
94 | PPPOX_ZOMBIE = 8, /* dead, but still bound to ppp device */ | ||
95 | PPPOX_DEAD = 16 /* dead, useless, please clean me up!*/ | 94 | PPPOX_DEAD = 16 /* dead, useless, please clean me up!*/ |
96 | }; | 95 | }; |
97 | 96 | ||