aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYazen Ghannam <Yazen.Ghannam@amd.com>2016-09-12 03:59:40 -0400
committerThomas Gleixner <tglx@linutronix.de>2016-09-13 09:23:14 -0400
commita884675b873a0185d2626d1f304987c94cef6d74 (patch)
tree8b413a3614883cdf845911bbac82040e04fd3404
parent4f29b73bae158e3635b8f289f77376b054904ef5 (diff)
x86/MCE/AMD, EDAC: Handle reserved bank 4 on Fam17h properly
Bank 4 is reserved on family 0x17 and shouldn't generate any MCE records. However, broken hardware and software is not something unheard of so warn about bank 4 errors. They shouldn't be coming from bank 4 naturally but users can still use mce_amd_inj to simulate errors from it for testing purposed. Also, avoid special handling in the injector mce_amd_inj like it is being done on the older families. [ bp: Rewrite commit message and merge into one patch. Use boot_cpu_data. ] Signed-off-by: Yazen Ghannam <Yazen.Ghannam@amd.com> Signed-off-by: Borislav Petkov <bp@suse.de> Reviewed-by: Aravind Gopalakrishnan <aravindksg.lkml@gmail.com> Link: http://lkml.kernel.org/r/1473384591-5323-1-git-send-email-Yazen.Ghannam@amd.com Link: http://lkml.kernel.org/r/1473384591-5323-2-git-send-email-Yazen.Ghannam@amd.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--arch/x86/ras/mce_amd_inj.c4
-rw-r--r--drivers/edac/mce_amd.c3
2 files changed, 6 insertions, 1 deletions
diff --git a/arch/x86/ras/mce_amd_inj.c b/arch/x86/ras/mce_amd_inj.c
index ff8eb1a9ce6d..f4b442cc8a3e 100644
--- a/arch/x86/ras/mce_amd_inj.c
+++ b/arch/x86/ras/mce_amd_inj.c
@@ -308,7 +308,9 @@ static void do_inject(void)
308 * only on the node base core. Refer to D18F3x44[NbMcaToMstCpuEn] for 308 * only on the node base core. Refer to D18F3x44[NbMcaToMstCpuEn] for
309 * Fam10h and later BKDGs. 309 * Fam10h and later BKDGs.
310 */ 310 */
311 if (static_cpu_has(X86_FEATURE_AMD_DCM) && b == 4) { 311 if (static_cpu_has(X86_FEATURE_AMD_DCM) &&
312 b == 4 &&
313 boot_cpu_data.x86 < 0x17) {
312 toggle_nb_mca_mst_cpu(amd_get_nb_id(cpu)); 314 toggle_nb_mca_mst_cpu(amd_get_nb_id(cpu));
313 cpu = get_nbc_for_node(amd_get_nb_id(cpu)); 315 cpu = get_nbc_for_node(amd_get_nb_id(cpu));
314 } 316 }
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index e8855a4f92d9..daaac2c79ca7 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -859,6 +859,9 @@ static void decode_smca_errors(struct mce *m)
859 if (m->bank >= ARRAY_SIZE(smca_banks)) 859 if (m->bank >= ARRAY_SIZE(smca_banks))
860 return; 860 return;
861 861
862 if (boot_cpu_data.x86 >= 0x17 && m->bank == 4)
863 pr_emerg(HW_ERR "Bank 4 is reserved on Fam17h.\n");
864
862 type = smca_banks[m->bank].type; 865 type = smca_banks[m->bank].type;
863 if (!type) 866 if (!type)
864 return; 867 return;