aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSeongJae Park <sj38.park@gmail.com>2016-08-21 03:54:39 -0400
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2016-08-22 13:06:16 -0400
commita56fefa2605cf8e125ef09451487f30336128028 (patch)
tree9be98a7cc020828aabf66f2e1fd09d0dae8ba1ce
parent472213a675e21185416101a77102253f93713fa9 (diff)
rcuperf: Consistently insert space between flag and message
A few rcuperf dmesg output messages have no space between the flag and the start of the message. In contrast, every other messages consistently supplies a single space. This difference makes rcuperf dmesg output hard to read and to mechanically parse. This commit therefore fixes this problem by modifying a pr_alert() call and PERFOUT_STRING() macro function to provide that single space. Signed-off-by: SeongJae Park <sj38.park@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r--kernel/rcu/rcuperf.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index d38ab08a3fe7..123ccbd22449 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -52,7 +52,7 @@ MODULE_AUTHOR("Paul E. McKenney <paulmck@linux.vnet.ibm.com>");
52 52
53#define PERF_FLAG "-perf:" 53#define PERF_FLAG "-perf:"
54#define PERFOUT_STRING(s) \ 54#define PERFOUT_STRING(s) \
55 pr_alert("%s" PERF_FLAG s "\n", perf_type) 55 pr_alert("%s" PERF_FLAG " %s\n", perf_type, s)
56#define VERBOSE_PERFOUT_STRING(s) \ 56#define VERBOSE_PERFOUT_STRING(s) \
57 do { if (verbose) pr_alert("%s" PERF_FLAG " %s\n", perf_type, s); } while (0) 57 do { if (verbose) pr_alert("%s" PERF_FLAG " %s\n", perf_type, s); } while (0)
58#define VERBOSE_PERFOUT_ERRSTRING(s) \ 58#define VERBOSE_PERFOUT_ERRSTRING(s) \
@@ -400,9 +400,8 @@ rcu_perf_writer(void *arg)
400 sp.sched_priority = 0; 400 sp.sched_priority = 0;
401 sched_setscheduler_nocheck(current, 401 sched_setscheduler_nocheck(current,
402 SCHED_NORMAL, &sp); 402 SCHED_NORMAL, &sp);
403 pr_alert("%s" PERF_FLAG 403 pr_alert("%s%s rcu_perf_writer %ld has %d measurements\n",
404 "rcu_perf_writer %ld has %d measurements\n", 404 perf_type, PERF_FLAG, me, MIN_MEAS);
405 perf_type, me, MIN_MEAS);
406 if (atomic_inc_return(&n_rcu_perf_writer_finished) >= 405 if (atomic_inc_return(&n_rcu_perf_writer_finished) >=
407 nrealwriters) { 406 nrealwriters) {
408 schedule_timeout_interruptible(10); 407 schedule_timeout_interruptible(10);