diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2016-09-11 09:06:06 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2016-09-12 21:13:30 -0400 |
commit | a217726a7df146fcfea6f37cbbc80849083260b6 (patch) | |
tree | 989c8eeaa246a039613ce4c9f5aaaffb56b6ce0d | |
parent | f75ee9a8816824683e22aee2790f43a9fc43c613 (diff) |
ACPI / APD: constify local structures
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.
Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | drivers/acpi/acpi_apd.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 1f30fffe1efb..d58fbf7f04e6 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c | |||
@@ -72,7 +72,7 @@ static int acpi_apd_setup(struct apd_private_data *pdata) | |||
72 | } | 72 | } |
73 | 73 | ||
74 | #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE | 74 | #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE |
75 | static struct apd_device_desc cz_i2c_desc = { | 75 | static const struct apd_device_desc cz_i2c_desc = { |
76 | .setup = acpi_apd_setup, | 76 | .setup = acpi_apd_setup, |
77 | .fixed_clk_rate = 133000000, | 77 | .fixed_clk_rate = 133000000, |
78 | }; | 78 | }; |
@@ -84,7 +84,7 @@ static struct property_entry uart_properties[] = { | |||
84 | { }, | 84 | { }, |
85 | }; | 85 | }; |
86 | 86 | ||
87 | static struct apd_device_desc cz_uart_desc = { | 87 | static const struct apd_device_desc cz_uart_desc = { |
88 | .setup = acpi_apd_setup, | 88 | .setup = acpi_apd_setup, |
89 | .fixed_clk_rate = 48000000, | 89 | .fixed_clk_rate = 48000000, |
90 | .properties = uart_properties, | 90 | .properties = uart_properties, |
@@ -92,12 +92,12 @@ static struct apd_device_desc cz_uart_desc = { | |||
92 | #endif | 92 | #endif |
93 | 93 | ||
94 | #ifdef CONFIG_ARM64 | 94 | #ifdef CONFIG_ARM64 |
95 | static struct apd_device_desc xgene_i2c_desc = { | 95 | static const struct apd_device_desc xgene_i2c_desc = { |
96 | .setup = acpi_apd_setup, | 96 | .setup = acpi_apd_setup, |
97 | .fixed_clk_rate = 100000000, | 97 | .fixed_clk_rate = 100000000, |
98 | }; | 98 | }; |
99 | 99 | ||
100 | static struct apd_device_desc vulcan_spi_desc = { | 100 | static const struct apd_device_desc vulcan_spi_desc = { |
101 | .setup = acpi_apd_setup, | 101 | .setup = acpi_apd_setup, |
102 | .fixed_clk_rate = 133000000, | 102 | .fixed_clk_rate = 133000000, |
103 | }; | 103 | }; |