libcxgb,iw_cxgb4,cxgbit: add cxgb_mk_tid_release()

Add cxgb_mk_tid_release() to remove duplicate code
to form CPL_TID_RELEASE hardware command.

Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 19 insertions, 15 deletions

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index b9d77df0a2f6..b818bd6d1fb5 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -240,15 +240,13 @@ int c4iw_ofld_send(struct c4iw_rdev *rdev, struct sk_buff *skb)
 
 static void release_tid(struct c4iw_rdev *rdev, u32 hwtid, struct sk_buff *skb)
 {
-        struct cpl_tid_release *req;
+        u32 len = roundup(sizeof(struct cpl_tid_release), 16);
 
-        skb = get_skb(skb, sizeof *req, GFP_KERNEL);
+        skb = get_skb(skb, len, GFP_KERNEL);
         if (!skb)
                 return;
-        req = (struct cpl_tid_release *) skb_put(skb, sizeof(*req));
-        INIT_TP_WR(req, hwtid);
-        OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_TID_RELEASE, hwtid));
-        set_wr_txq(skb, CPL_PRIORITY_SETUP, 0);
+
+        cxgb_mk_tid_release(skb, len, hwtid, 0);
         c4iw_ofld_send(rdev, skb);
         return;
 }
diff --git a/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h
index ecf3baa940b9..fbb973e9ec29 100644
--- a/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h
+++ b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h
@@ -83,4 +83,17 @@ static inline u32 cxgb_compute_wscale(u32 win)
                 wscale++;
         return wscale;
 }
+
+static inline void
+cxgb_mk_tid_release(struct sk_buff *skb, u32 len, u32 tid, u16 chan)
+{
+        struct cpl_tid_release *req;
+
+        req = (struct cpl_tid_release *)__skb_put(skb, len);
+        memset(req, 0, len);
+
+        INIT_TP_WR(req, tid);
+        OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_TID_RELEASE, tid));
+        set_wr_txq(skb, CPL_PRIORITY_SETUP, chan);
+}
 #endif
diff --git a/drivers/target/iscsi/cxgbit/cxgbit_cm.c b/drivers/target/iscsi/cxgbit/cxgbit_cm.c
index cd29c91d01fc..994058f0c4e0 100644
--- a/drivers/target/iscsi/cxgbit/cxgbit_cm.c
+++ b/drivers/target/iscsi/cxgbit/cxgbit_cm.c
@@ -961,21 +961,14 @@ int cxgbit_ofld_send(struct cxgbit_device *cdev, struct sk_buff *skb)
 
 static void cxgbit_release_tid(struct cxgbit_device *cdev, u32 tid)
 {
-        struct cpl_tid_release *req;
-        unsigned int len = roundup(sizeof(*req), 16);
+        u32 len = roundup(sizeof(struct cpl_tid_release), 16);
         struct sk_buff *skb;
 
         skb = alloc_skb(len, GFP_ATOMIC);
         if (!skb)
                 return;
 
-        req = (struct cpl_tid_release *)__skb_put(skb, len);
-        memset(req, 0, len);
-
-        INIT_TP_WR(req, tid);
-        OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(
-                   CPL_TID_RELEASE, tid));
-        set_wr_txq(skb, CPL_PRIORITY_SETUP, 0);
+        cxgb_mk_tid_release(skb, len, tid, 0);
         cxgbit_ofld_send(cdev, skb);
 }