aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-06-10 11:06:34 -0400
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-06-10 11:06:34 -0400
commit9d605e6359f0808581b89350c643208586f41a06 (patch)
treed817ee2e9b8028d60a881f70afabed0f10c3b5b1
parenta96762da0cfcbe27f18febb84797269cd9faf791 (diff)
[media] mantis: cleanup CodingStyle issues due to last commit
Commit a96762da0cfc('[media] mantis: add remote control support') introduced some new CodingStyle issues. Fix them. No functional changes. Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r--drivers/media/pci/mantis/hopper_cards.c7
-rw-r--r--drivers/media/pci/mantis/mantis_cards.c30
-rw-r--r--drivers/media/pci/mantis/mantis_input.c8
-rw-r--r--drivers/media/pci/mantis/mantis_input.h10
-rw-r--r--drivers/media/pci/mantis/mantis_uart.c5
5 files changed, 28 insertions, 32 deletions
diff --git a/drivers/media/pci/mantis/hopper_cards.c b/drivers/media/pci/mantis/hopper_cards.c
index 97b7a3220dbd..68b5800030b7 100644
--- a/drivers/media/pci/mantis/hopper_cards.c
+++ b/drivers/media/pci/mantis/hopper_cards.c
@@ -107,7 +107,8 @@ static irqreturn_t hopper_irq_handler(int irq, void *dev_id)
107 if (stat & MANTIS_INT_IRQ1) { 107 if (stat & MANTIS_INT_IRQ1) {
108 dprintk(MANTIS_DEBUG, 0, "<%s>", label[2]); 108 dprintk(MANTIS_DEBUG, 0, "<%s>", label[2]);
109 spin_lock(&mantis->intmask_lock); 109 spin_lock(&mantis->intmask_lock);
110 mmwrite(mmread(MANTIS_INT_MASK) & ~MANTIS_INT_IRQ1, MANTIS_INT_MASK); 110 mmwrite(mmread(MANTIS_INT_MASK) & ~MANTIS_INT_IRQ1,
111 MANTIS_INT_MASK);
111 spin_unlock(&mantis->intmask_lock); 112 spin_unlock(&mantis->intmask_lock);
112 schedule_work(&mantis->uart_work); 113 schedule_work(&mantis->uart_work);
113 } 114 }
@@ -169,7 +170,7 @@ static int hopper_pci_probe(struct pci_dev *pdev,
169 goto fail0; 170 goto fail0;
170 } 171 }
171 172
172 drvdata = (struct mantis_pci_drvdata *) pci_id->driver_data; 173 drvdata = (void *)pci_id->driver_data;
173 mantis->num = devs; 174 mantis->num = devs;
174 mantis->verbose = verbose; 175 mantis->verbose = verbose;
175 mantis->pdev = pdev; 176 mantis->pdev = pdev;
@@ -256,7 +257,7 @@ static void hopper_pci_remove(struct pci_dev *pdev)
256 257
257static struct pci_device_id hopper_pci_table[] = { 258static struct pci_device_id hopper_pci_table[] = {
258 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_3028_DVB_T, &vp3028_config, 259 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_3028_DVB_T, &vp3028_config,
259 NULL), 260 NULL),
260 { } 261 { }
261}; 262};
262 263
diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis/mantis_cards.c
index 6b64bfd938b6..cdefffc16d9e 100644
--- a/drivers/media/pci/mantis/mantis_cards.c
+++ b/drivers/media/pci/mantis/mantis_cards.c
@@ -117,7 +117,8 @@ static irqreturn_t mantis_irq_handler(int irq, void *dev_id)
117 if (stat & MANTIS_INT_IRQ1) { 117 if (stat & MANTIS_INT_IRQ1) {
118 dprintk(MANTIS_DEBUG, 0, "<%s>", label[2]); 118 dprintk(MANTIS_DEBUG, 0, "<%s>", label[2]);
119 spin_lock(&mantis->intmask_lock); 119 spin_lock(&mantis->intmask_lock);
120 mmwrite(mmread(MANTIS_INT_MASK) & ~MANTIS_INT_IRQ1, MANTIS_INT_MASK); 120 mmwrite(mmread(MANTIS_INT_MASK) & ~MANTIS_INT_IRQ1,
121 MANTIS_INT_MASK);
121 spin_unlock(&mantis->intmask_lock); 122 spin_unlock(&mantis->intmask_lock);
122 schedule_work(&mantis->uart_work); 123 schedule_work(&mantis->uart_work);
123 } 124 }
@@ -178,7 +179,7 @@ static int mantis_pci_probe(struct pci_dev *pdev,
178 return -ENOMEM; 179 return -ENOMEM;
179 } 180 }
180 181
181 drvdata = (struct mantis_pci_drvdata *) pci_id->driver_data; 182 drvdata = (void *)pci_id->driver_data;
182 mantis->num = devs; 183 mantis->num = devs;
183 mantis->verbose = verbose; 184 mantis->verbose = verbose;
184 mantis->pdev = pdev; 185 mantis->pdev = pdev;
@@ -227,7 +228,8 @@ static int mantis_pci_probe(struct pci_dev *pdev,
227 228
228 err = mantis_input_init(mantis); 229 err = mantis_input_init(mantis);
229 if (err < 0) { 230 if (err < 0) {
230 dprintk(MANTIS_ERROR, 1, "ERROR: Mantis DVB initialization failed <%d>", err); 231 dprintk(MANTIS_ERROR, 1,
232 "ERROR: Mantis DVB initialization failed <%d>", err);
231 goto err_dvb_exit; 233 goto err_dvb_exit;
232 } 234 }
233 235
@@ -281,27 +283,27 @@ static void mantis_pci_remove(struct pci_dev *pdev)
281 283
282static struct pci_device_id mantis_pci_table[] = { 284static struct pci_device_id mantis_pci_table[] = {
283 MAKE_ENTRY(TECHNISAT, CABLESTAR_HD2, &vp2040_config, 285 MAKE_ENTRY(TECHNISAT, CABLESTAR_HD2, &vp2040_config,
284 RC_MAP_TECHNISAT_TS35), 286 RC_MAP_TECHNISAT_TS35),
285 MAKE_ENTRY(TECHNISAT, SKYSTAR_HD2_10, &vp1041_config, 287 MAKE_ENTRY(TECHNISAT, SKYSTAR_HD2_10, &vp1041_config,
286 NULL), 288 NULL),
287 MAKE_ENTRY(TECHNISAT, SKYSTAR_HD2_20, &vp1041_config, 289 MAKE_ENTRY(TECHNISAT, SKYSTAR_HD2_20, &vp1041_config,
288 NULL), 290 NULL),
289 MAKE_ENTRY(TERRATEC, CINERGY_C, &vp2040_config, 291 MAKE_ENTRY(TERRATEC, CINERGY_C, &vp2040_config,
290 RC_MAP_TERRATEC_CINERGY_C_PCI), 292 RC_MAP_TERRATEC_CINERGY_C_PCI),
291 MAKE_ENTRY(TERRATEC, CINERGY_S2_PCI_HD, &vp1041_config, 293 MAKE_ENTRY(TERRATEC, CINERGY_S2_PCI_HD, &vp1041_config,
292 RC_MAP_TERRATEC_CINERGY_S2_HD), 294 RC_MAP_TERRATEC_CINERGY_S2_HD),
293 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_1033_DVB_S, &vp1033_config, 295 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_1033_DVB_S, &vp1033_config,
294 NULL), 296 NULL),
295 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_1034_DVB_S, &vp1034_config, 297 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_1034_DVB_S, &vp1034_config,
296 NULL), 298 NULL),
297 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_1041_DVB_S2, &vp1041_config, 299 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_1041_DVB_S2, &vp1041_config,
298 RC_MAP_TWINHAN_DTV_CAB_CI), 300 RC_MAP_TWINHAN_DTV_CAB_CI),
299 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2033_DVB_C, &vp2033_config, 301 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2033_DVB_C, &vp2033_config,
300 RC_MAP_TWINHAN_DTV_CAB_CI), 302 RC_MAP_TWINHAN_DTV_CAB_CI),
301 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2040_DVB_C, &vp2040_config, 303 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2040_DVB_C, &vp2040_config,
302 NULL), 304 NULL),
303 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_3030_DVB_T, &vp3030_config, 305 MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_3030_DVB_T, &vp3030_config,
304 NULL), 306 NULL),
305 { } 307 { }
306}; 308};
307 309
diff --git a/drivers/media/pci/mantis/mantis_input.c b/drivers/media/pci/mantis/mantis_input.c
index abf0ddfef0cb..7f7f1d4d7bb1 100644
--- a/drivers/media/pci/mantis/mantis_input.c
+++ b/drivers/media/pci/mantis/mantis_input.c
@@ -12,10 +12,6 @@
12 but WITHOUT ANY WARRANTY; without even the implied warranty of 12 but WITHOUT ANY WARRANTY; without even the implied warranty of
13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 GNU General Public License for more details. 14 GNU General Public License for more details.
15
16 You should have received a copy of the GNU General Public License
17 along with this program; if not, write to the Free Software
18 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
19*/ 15*/
20 16
21#include <media/rc-core.h> 17#include <media/rc-core.h>
@@ -51,9 +47,9 @@ int mantis_input_init(struct mantis_pci *mantis)
51 } 47 }
52 48
53 snprintf(mantis->input_name, sizeof(mantis->input_name), 49 snprintf(mantis->input_name, sizeof(mantis->input_name),
54 "Mantis %s IR receiver", mantis->hwconfig->model_name); 50 "Mantis %s IR receiver", mantis->hwconfig->model_name);
55 snprintf(mantis->input_phys, sizeof(mantis->input_phys), 51 snprintf(mantis->input_phys, sizeof(mantis->input_phys),
56 "pci-%s/ir0", pci_name(mantis->pdev)); 52 "pci-%s/ir0", pci_name(mantis->pdev));
57 53
58 dev->input_name = mantis->input_name; 54 dev->input_name = mantis->input_name;
59 dev->input_phys = mantis->input_phys; 55 dev->input_phys = mantis->input_phys;
diff --git a/drivers/media/pci/mantis/mantis_input.h b/drivers/media/pci/mantis/mantis_input.h
index 3bbde8b11ce1..0fbd92987c02 100644
--- a/drivers/media/pci/mantis/mantis_input.h
+++ b/drivers/media/pci/mantis/mantis_input.h
@@ -12,17 +12,13 @@
12 but WITHOUT ANY WARRANTY; without even the implied warranty of 12 but WITHOUT ANY WARRANTY; without even the implied warranty of
13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 GNU General Public License for more details. 14 GNU General Public License for more details.
15
16 You should have received a copy of the GNU General Public License
17 along with this program; if not, write to the Free Software
18 Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
19*/ 15*/
20 16
21#ifndef __MANTIS_INPUT_H 17#ifndef __MANTIS_INPUT_H
22#define __MANTIS_INPUT_H 18#define __MANTIS_INPUT_H
23 19
24extern int mantis_input_init(struct mantis_pci *mantis); 20int mantis_input_init(struct mantis_pci *mantis);
25extern void mantis_input_exit(struct mantis_pci *mantis); 21void mantis_input_exit(struct mantis_pci *mantis);
26extern void mantis_input_process(struct mantis_pci *mantis, int scancode); 22void mantis_input_process(struct mantis_pci *mantis, int scancode);
27 23
28#endif /* __MANTIS_UART_H */ 24#endif /* __MANTIS_UART_H */
diff --git a/drivers/media/pci/mantis/mantis_uart.c b/drivers/media/pci/mantis/mantis_uart.c
index 483410948995..f1c96aec8c7b 100644
--- a/drivers/media/pci/mantis/mantis_uart.c
+++ b/drivers/media/pci/mantis/mantis_uart.c
@@ -70,6 +70,7 @@ static void mantis_uart_read(struct mantis_pci *mantis)
70 dprintk(MANTIS_DEBUG, 1, "UART Reading ..."); 70 dprintk(MANTIS_DEBUG, 1, "UART Reading ...");
71 for (i = 0; i < (config->bytes + 1); i++) { 71 for (i = 0; i < (config->bytes + 1); i++) {
72 int data = mmread(MANTIS_UART_RXD); 72 int data = mmread(MANTIS_UART_RXD);
73
73 dprintk(MANTIS_DEBUG, 0, " <%02x>", data); 74 dprintk(MANTIS_DEBUG, 0, " <%02x>", data);
74 75
75 scancode = (scancode << 8) | (data & 0x3f); 76 scancode = (scancode << 8) | (data & 0x3f);
@@ -98,8 +99,8 @@ static void mantis_uart_work(struct work_struct *work)
98 dprintk(MANTIS_ERROR, 1, "RX Fifo FULL"); 99 dprintk(MANTIS_ERROR, 1, "RX Fifo FULL");
99 100
100 /* 101 /*
101 * MANTIS_UART_RXFIFO_DATA is only set if at least config->bytes + 1 bytes 102 * MANTIS_UART_RXFIFO_DATA is only set if at least
102 * are in the FIFO. 103 * config->bytes + 1 bytes are in the FIFO.
103 */ 104 */
104 while (stat & MANTIS_UART_RXFIFO_DATA) { 105 while (stat & MANTIS_UART_RXFIFO_DATA) {
105 mantis_uart_read(mantis); 106 mantis_uart_read(mantis);