aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-09-02 18:52:11 -0400
committerArnd Bergmann <arnd@arndb.de>2016-09-02 18:52:11 -0400
commit9064a1c77dd3a5c7288b0254a336d6f4073cd996 (patch)
tree18d84e2dabc88c0882c2f6cf7e3ce2d8ac17d312
parent7d3ef43f1f99d4250ff120c8965b3e5cd81b3c71 (diff)
parent23540d6e2f3193b946c4de43e3f9654fa6d23fe7 (diff)
Merge commit 'http://github.com/rogerq/linux gpmc-omap-v4.8-rc1' into next/drivers
This is also going to be part of v4.8 and sent as a bugfix, merging it here to avoid a small conflict against the other gpmc changes. Signed-off-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/memory/omap-gpmc.c21
1 files changed, 7 insertions, 14 deletions
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index c2c32edfed95..5457c361ad58 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2183,7 +2183,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
2183 return 0; 2183 return 0;
2184} 2184}
2185 2185
2186static int gpmc_probe_dt_children(struct platform_device *pdev) 2186static void gpmc_probe_dt_children(struct platform_device *pdev)
2187{ 2187{
2188 int ret; 2188 int ret;
2189 struct device_node *child; 2189 struct device_node *child;
@@ -2198,11 +2198,11 @@ static int gpmc_probe_dt_children(struct platform_device *pdev)
2198 else 2198 else
2199 ret = gpmc_probe_generic_child(pdev, child); 2199 ret = gpmc_probe_generic_child(pdev, child);
2200 2200
2201 if (ret) 2201 if (ret) {
2202 return ret; 2202 dev_err(&pdev->dev, "failed to probe DT child '%s': %d\n",
2203 child->name, ret);
2204 }
2203 } 2205 }
2204
2205 return 0;
2206} 2206}
2207#else 2207#else
2208static int gpmc_probe_dt(struct platform_device *pdev) 2208static int gpmc_probe_dt(struct platform_device *pdev)
@@ -2210,9 +2210,8 @@ static int gpmc_probe_dt(struct platform_device *pdev)
2210 return 0; 2210 return 0;
2211} 2211}
2212 2212
2213static int gpmc_probe_dt_children(struct platform_device *pdev) 2213static void gpmc_probe_dt_children(struct platform_device *pdev)
2214{ 2214{
2215 return 0;
2216} 2215}
2217#endif /* CONFIG_OF */ 2216#endif /* CONFIG_OF */
2218 2217
@@ -2362,16 +2361,10 @@ static int gpmc_probe(struct platform_device *pdev)
2362 goto gpio_init_failed; 2361 goto gpio_init_failed;
2363 } 2362 }
2364 2363
2365 rc = gpmc_probe_dt_children(pdev); 2364 gpmc_probe_dt_children(pdev);
2366 if (rc < 0) {
2367 dev_err(gpmc->dev, "failed to probe DT children\n");
2368 goto dt_children_failed;
2369 }
2370 2365
2371 return 0; 2366 return 0;
2372 2367
2373dt_children_failed:
2374 gpmc_free_irq(gpmc);
2375gpio_init_failed: 2368gpio_init_failed:
2376 gpmc_mem_exit(); 2369 gpmc_mem_exit();
2377 pm_runtime_put_sync(&pdev->dev); 2370 pm_runtime_put_sync(&pdev->dev);