diff options
author | Andreas Gruenbacher <agruen@linbit.com> | 2010-12-19 17:53:14 -0500 |
---|---|---|
committer | Philipp Reisner <philipp.reisner@linbit.com> | 2012-11-08 10:44:50 -0500 |
commit | 8f7bed77740c7418074e6ba82c646a7dd035e6cf (patch) | |
tree | d3e429d72b8330e128dee76613b06b2e21d64d98 | |
parent | 0da34df0d05d004c1ec40f4c30a325d8727b0b33 (diff) |
drbd: Rename various functions from *_oos_* to *_out_of_sync_* for clarity
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
-rw-r--r-- | drivers/block/drbd/drbd_int.h | 8 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_main.c | 2 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_receiver.c | 6 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_req.c | 6 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_req.h | 2 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_worker.c | 14 |
6 files changed, 19 insertions, 19 deletions
diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index 300e85ef94da..837ac36f2d30 100644 --- a/drivers/block/drbd/drbd_int.h +++ b/drivers/block/drbd/drbd_int.h | |||
@@ -1191,7 +1191,7 @@ extern void drbd_send_ack_dp(struct drbd_conf *mdev, enum drbd_packet cmd, | |||
1191 | struct p_data *dp, int data_size); | 1191 | struct p_data *dp, int data_size); |
1192 | extern int drbd_send_ack_ex(struct drbd_conf *mdev, enum drbd_packet cmd, | 1192 | extern int drbd_send_ack_ex(struct drbd_conf *mdev, enum drbd_packet cmd, |
1193 | sector_t sector, int blksize, u64 block_id); | 1193 | sector_t sector, int blksize, u64 block_id); |
1194 | extern int drbd_send_oos(struct drbd_conf *mdev, struct drbd_request *req); | 1194 | extern int drbd_send_out_of_sync(struct drbd_conf *, struct drbd_request *); |
1195 | extern int drbd_send_block(struct drbd_conf *, enum drbd_packet, | 1195 | extern int drbd_send_block(struct drbd_conf *, enum drbd_packet, |
1196 | struct drbd_peer_request *); | 1196 | struct drbd_peer_request *); |
1197 | extern int drbd_send_dblock(struct drbd_conf *mdev, struct drbd_request *req); | 1197 | extern int drbd_send_dblock(struct drbd_conf *mdev, struct drbd_request *req); |
@@ -1528,10 +1528,10 @@ extern int drbd_resync_finished(struct drbd_conf *mdev); | |||
1528 | /* maybe rather drbd_main.c ? */ | 1528 | /* maybe rather drbd_main.c ? */ |
1529 | extern int drbd_md_sync_page_io(struct drbd_conf *mdev, | 1529 | extern int drbd_md_sync_page_io(struct drbd_conf *mdev, |
1530 | struct drbd_backing_dev *bdev, sector_t sector, int rw); | 1530 | struct drbd_backing_dev *bdev, sector_t sector, int rw); |
1531 | extern void drbd_ov_oos_found(struct drbd_conf*, sector_t, int); | 1531 | extern void drbd_ov_out_of_sync_found(struct drbd_conf *, sector_t, int); |
1532 | extern void drbd_rs_controller_reset(struct drbd_conf *mdev); | 1532 | extern void drbd_rs_controller_reset(struct drbd_conf *mdev); |
1533 | 1533 | ||
1534 | static inline void ov_oos_print(struct drbd_conf *mdev) | 1534 | static inline void ov_out_of_sync_print(struct drbd_conf *mdev) |
1535 | { | 1535 | { |
1536 | if (mdev->ov_last_oos_size) { | 1536 | if (mdev->ov_last_oos_size) { |
1537 | dev_err(DEV, "Out of sync: start=%llu, size=%lu (sectors)\n", | 1537 | dev_err(DEV, "Out of sync: start=%llu, size=%lu (sectors)\n", |
@@ -1562,7 +1562,7 @@ extern int w_send_read_req(struct drbd_work *, int); | |||
1562 | extern int w_prev_work_done(struct drbd_work *, int); | 1562 | extern int w_prev_work_done(struct drbd_work *, int); |
1563 | extern int w_e_reissue(struct drbd_work *, int); | 1563 | extern int w_e_reissue(struct drbd_work *, int); |
1564 | extern int w_restart_disk_io(struct drbd_work *, int); | 1564 | extern int w_restart_disk_io(struct drbd_work *, int); |
1565 | extern int w_send_oos(struct drbd_work *, int); | 1565 | extern int w_send_out_of_sync(struct drbd_work *, int); |
1566 | extern int w_start_resync(struct drbd_work *, int); | 1566 | extern int w_start_resync(struct drbd_work *, int); |
1567 | 1567 | ||
1568 | extern void resync_timer_fn(unsigned long data); | 1568 | extern void resync_timer_fn(unsigned long data); |
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 43b9b7a067bd..f633c0bd52e4 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c | |||
@@ -1652,7 +1652,7 @@ int drbd_send_block(struct drbd_conf *mdev, enum drbd_packet cmd, | |||
1652 | return err; | 1652 | return err; |
1653 | } | 1653 | } |
1654 | 1654 | ||
1655 | int drbd_send_oos(struct drbd_conf *mdev, struct drbd_request *req) | 1655 | int drbd_send_out_of_sync(struct drbd_conf *mdev, struct drbd_request *req) |
1656 | { | 1656 | { |
1657 | struct p_block_desc p; | 1657 | struct p_block_desc p; |
1658 | 1658 | ||
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 5fc536727afe..fc05d9614664 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c | |||
@@ -4699,9 +4699,9 @@ static int got_OVResult(struct drbd_conf *mdev, enum drbd_packet cmd) | |||
4699 | update_peer_seq(mdev, be32_to_cpu(p->seq_num)); | 4699 | update_peer_seq(mdev, be32_to_cpu(p->seq_num)); |
4700 | 4700 | ||
4701 | if (be64_to_cpu(p->block_id) == ID_OUT_OF_SYNC) | 4701 | if (be64_to_cpu(p->block_id) == ID_OUT_OF_SYNC) |
4702 | drbd_ov_oos_found(mdev, sector, size); | 4702 | drbd_ov_out_of_sync_found(mdev, sector, size); |
4703 | else | 4703 | else |
4704 | ov_oos_print(mdev); | 4704 | ov_out_of_sync_print(mdev); |
4705 | 4705 | ||
4706 | if (!get_ldev(mdev)) | 4706 | if (!get_ldev(mdev)) |
4707 | return true; | 4707 | return true; |
@@ -4723,7 +4723,7 @@ static int got_OVResult(struct drbd_conf *mdev, enum drbd_packet cmd) | |||
4723 | drbd_queue_work_front(&mdev->tconn->data.work, w); | 4723 | drbd_queue_work_front(&mdev->tconn->data.work, w); |
4724 | } else { | 4724 | } else { |
4725 | dev_err(DEV, "kmalloc(w) failed."); | 4725 | dev_err(DEV, "kmalloc(w) failed."); |
4726 | ov_oos_print(mdev); | 4726 | ov_out_of_sync_print(mdev); |
4727 | drbd_resync_finished(mdev); | 4727 | drbd_resync_finished(mdev); |
4728 | } | 4728 | } |
4729 | } | 4729 | } |
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 3430dab85720..e380ffb7f4fc 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c | |||
@@ -477,7 +477,7 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what, | |||
477 | 477 | ||
478 | case QUEUE_FOR_SEND_OOS: | 478 | case QUEUE_FOR_SEND_OOS: |
479 | req->rq_state |= RQ_NET_QUEUED; | 479 | req->rq_state |= RQ_NET_QUEUED; |
480 | req->w.cb = w_send_oos; | 480 | req->w.cb = w_send_out_of_sync; |
481 | drbd_queue_work(&mdev->tconn->data.work, &req->w); | 481 | drbd_queue_work(&mdev->tconn->data.work, &req->w); |
482 | break; | 482 | break; |
483 | 483 | ||
@@ -786,7 +786,7 @@ int __drbd_make_request(struct drbd_conf *mdev, struct bio *bio, unsigned long s | |||
786 | } | 786 | } |
787 | 787 | ||
788 | remote = remote && drbd_should_do_remote(mdev->state); | 788 | remote = remote && drbd_should_do_remote(mdev->state); |
789 | send_oos = rw == WRITE && drbd_should_send_oos(mdev->state); | 789 | send_oos = rw == WRITE && drbd_should_send_out_of_sync(mdev->state); |
790 | D_ASSERT(!(remote && send_oos)); | 790 | D_ASSERT(!(remote && send_oos)); |
791 | 791 | ||
792 | if (!(local || remote) && !is_susp(mdev->state)) { | 792 | if (!(local || remote) && !is_susp(mdev->state)) { |
@@ -842,7 +842,7 @@ allocate_barrier: | |||
842 | 842 | ||
843 | if (remote || send_oos) { | 843 | if (remote || send_oos) { |
844 | remote = drbd_should_do_remote(mdev->state); | 844 | remote = drbd_should_do_remote(mdev->state); |
845 | send_oos = rw == WRITE && drbd_should_send_oos(mdev->state); | 845 | send_oos = rw == WRITE && drbd_should_send_out_of_sync(mdev->state); |
846 | D_ASSERT(!(remote && send_oos)); | 846 | D_ASSERT(!(remote && send_oos)); |
847 | 847 | ||
848 | if (!(remote || send_oos)) | 848 | if (!(remote || send_oos)) |
diff --git a/drivers/block/drbd/drbd_req.h b/drivers/block/drbd/drbd_req.h index 8c8c2588c4b9..7fb3e06369d2 100644 --- a/drivers/block/drbd/drbd_req.h +++ b/drivers/block/drbd/drbd_req.h | |||
@@ -305,7 +305,7 @@ static inline bool drbd_should_do_remote(union drbd_state s) | |||
305 | That is equivalent since before 96 IO was frozen in the C_WF_BITMAP* | 305 | That is equivalent since before 96 IO was frozen in the C_WF_BITMAP* |
306 | states. */ | 306 | states. */ |
307 | } | 307 | } |
308 | static inline bool drbd_should_send_oos(union drbd_state s) | 308 | static inline bool drbd_should_send_out_of_sync(union drbd_state s) |
309 | { | 309 | { |
310 | return s.conn == C_AHEAD || s.conn == C_WF_BITMAP_S; | 310 | return s.conn == C_AHEAD || s.conn == C_WF_BITMAP_S; |
311 | /* pdsk = D_INCONSISTENT as a consequence. Protocol 96 check not necessary | 311 | /* pdsk = D_INCONSISTENT as a consequence. Protocol 96 check not necessary |
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index 0f0beec9a19d..185cd25b18dd 100644 --- a/drivers/block/drbd/drbd_worker.c +++ b/drivers/block/drbd/drbd_worker.c | |||
@@ -714,7 +714,7 @@ int w_ov_finished(struct drbd_work *w, int cancel) | |||
714 | { | 714 | { |
715 | struct drbd_conf *mdev = w->mdev; | 715 | struct drbd_conf *mdev = w->mdev; |
716 | kfree(w); | 716 | kfree(w); |
717 | ov_oos_print(mdev); | 717 | ov_out_of_sync_print(mdev); |
718 | drbd_resync_finished(mdev); | 718 | drbd_resync_finished(mdev); |
719 | 719 | ||
720 | return 0; | 720 | return 0; |
@@ -1102,7 +1102,7 @@ out: | |||
1102 | return err; | 1102 | return err; |
1103 | } | 1103 | } |
1104 | 1104 | ||
1105 | void drbd_ov_oos_found(struct drbd_conf *mdev, sector_t sector, int size) | 1105 | void drbd_ov_out_of_sync_found(struct drbd_conf *mdev, sector_t sector, int size) |
1106 | { | 1106 | { |
1107 | if (mdev->ov_last_oos_start + mdev->ov_last_oos_size == sector) { | 1107 | if (mdev->ov_last_oos_start + mdev->ov_last_oos_size == sector) { |
1108 | mdev->ov_last_oos_size += size>>9; | 1108 | mdev->ov_last_oos_size += size>>9; |
@@ -1158,9 +1158,9 @@ int w_e_end_ov_reply(struct drbd_work *w, int cancel) | |||
1158 | * drbd_pp_alloc due to pp_in_use > max_buffers. */ | 1158 | * drbd_pp_alloc due to pp_in_use > max_buffers. */ |
1159 | drbd_free_ee(mdev, peer_req); | 1159 | drbd_free_ee(mdev, peer_req); |
1160 | if (!eq) | 1160 | if (!eq) |
1161 | drbd_ov_oos_found(mdev, sector, size); | 1161 | drbd_ov_out_of_sync_found(mdev, sector, size); |
1162 | else | 1162 | else |
1163 | ov_oos_print(mdev); | 1163 | ov_out_of_sync_print(mdev); |
1164 | 1164 | ||
1165 | err = drbd_send_ack_ex(mdev, P_OV_RESULT, sector, size, | 1165 | err = drbd_send_ack_ex(mdev, P_OV_RESULT, sector, size, |
1166 | eq ? ID_IN_SYNC : ID_OUT_OF_SYNC); | 1166 | eq ? ID_IN_SYNC : ID_OUT_OF_SYNC); |
@@ -1174,7 +1174,7 @@ int w_e_end_ov_reply(struct drbd_work *w, int cancel) | |||
1174 | drbd_advance_rs_marks(mdev, mdev->ov_left); | 1174 | drbd_advance_rs_marks(mdev, mdev->ov_left); |
1175 | 1175 | ||
1176 | if (mdev->ov_left == 0) { | 1176 | if (mdev->ov_left == 0) { |
1177 | ov_oos_print(mdev); | 1177 | ov_out_of_sync_print(mdev); |
1178 | drbd_resync_finished(mdev); | 1178 | drbd_resync_finished(mdev); |
1179 | } | 1179 | } |
1180 | 1180 | ||
@@ -1230,7 +1230,7 @@ int w_send_write_hint(struct drbd_work *w, int cancel) | |||
1230 | return drbd_send_short_cmd(mdev, P_UNPLUG_REMOTE); | 1230 | return drbd_send_short_cmd(mdev, P_UNPLUG_REMOTE); |
1231 | } | 1231 | } |
1232 | 1232 | ||
1233 | int w_send_oos(struct drbd_work *w, int cancel) | 1233 | int w_send_out_of_sync(struct drbd_work *w, int cancel) |
1234 | { | 1234 | { |
1235 | struct drbd_request *req = container_of(w, struct drbd_request, w); | 1235 | struct drbd_request *req = container_of(w, struct drbd_request, w); |
1236 | struct drbd_conf *mdev = w->mdev; | 1236 | struct drbd_conf *mdev = w->mdev; |
@@ -1241,7 +1241,7 @@ int w_send_oos(struct drbd_work *w, int cancel) | |||
1241 | return 0; | 1241 | return 0; |
1242 | } | 1242 | } |
1243 | 1243 | ||
1244 | err = drbd_send_oos(mdev, req); | 1244 | err = drbd_send_out_of_sync(mdev, req); |
1245 | req_mod(req, OOS_HANDED_TO_NETWORK); | 1245 | req_mod(req, OOS_HANDED_TO_NETWORK); |
1246 | 1246 | ||
1247 | return err; | 1247 | return err; |