aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan-Marek Glogowski <glogow@fbihome.de>2017-02-20 06:25:58 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-04-12 06:41:11 -0400
commit8446cb1adf95fd12289865ec9f21c7d877d0be04 (patch)
tree82bbfc4930fd592082e11a0494746cf7be9aba8f
parent57e1e90dda74f87bef31bcc5eea89f775b7b3c69 (diff)
Reset TreeId to zero on SMB2 TREE_CONNECT
commit 806a28efe9b78ffae5e2757e1ee924b8e50c08ab upstream. Currently the cifs module breaks the CIFS specs on reconnect as described in http://msdn.microsoft.com/en-us/library/cc246529.aspx: "TreeId (4 bytes): Uniquely identifies the tree connect for the command. This MUST be 0 for the SMB2 TREE_CONNECT Request." Signed-off-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Aurelien Aptel <aaptel@suse.com> Tested-by: Aurelien Aptel <aaptel@suse.com> Signed-off-by: Steve French <smfrench@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/cifs/smb2pdu.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 87457227812c..bdd32925a15e 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -1104,6 +1104,10 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree,
1104 return -EINVAL; 1104 return -EINVAL;
1105 } 1105 }
1106 1106
1107 /* SMB2 TREE_CONNECT request must be called with TreeId == 0 */
1108 if (tcon)
1109 tcon->tid = 0;
1110
1107 rc = small_smb2_init(SMB2_TREE_CONNECT, tcon, (void **) &req); 1111 rc = small_smb2_init(SMB2_TREE_CONNECT, tcon, (void **) &req);
1108 if (rc) { 1112 if (rc) {
1109 kfree(unc_path); 1113 kfree(unc_path);