diff options
author | Fam Zheng <famz@redhat.com> | 2017-03-28 00:41:26 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-21 03:31:21 -0400 |
commit | 82d181d7540fed18ee48487d252dc60920c16d18 (patch) | |
tree | 2f68475d4196a8ab5f3b6de7e1b63a45fcb1ce18 | |
parent | c80c158bfe613d346d48803462bf55d8f35d228e (diff) |
scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable
commit 6780414519f91c2a84da9baa963a940ac916f803 upstream.
If device reports a small max_xfer_blocks and a zero opt_xfer_blocks, we
end up using BLK_DEF_MAX_SECTORS, which is wrong and r/w of that size
may get error.
[mkp: tweaked to avoid setting rw_max twice and added typecast]
Fixes: ca369d51b3e ("block/sd: Fix device-imposed transfer length limits")
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/scsi/sd.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 51e56296f465..e0796b2e0d2f 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c | |||
@@ -2877,7 +2877,8 @@ static int sd_revalidate_disk(struct gendisk *disk) | |||
2877 | q->limits.io_opt = logical_to_bytes(sdp, sdkp->opt_xfer_blocks); | 2877 | q->limits.io_opt = logical_to_bytes(sdp, sdkp->opt_xfer_blocks); |
2878 | rw_max = logical_to_sectors(sdp, sdkp->opt_xfer_blocks); | 2878 | rw_max = logical_to_sectors(sdp, sdkp->opt_xfer_blocks); |
2879 | } else | 2879 | } else |
2880 | rw_max = BLK_DEF_MAX_SECTORS; | 2880 | rw_max = min_not_zero(logical_to_sectors(sdp, dev_max), |
2881 | (sector_t)BLK_DEF_MAX_SECTORS); | ||
2881 | 2882 | ||
2882 | /* Combine with controller limits */ | 2883 | /* Combine with controller limits */ |
2883 | q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q)); | 2884 | q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q)); |