aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobert Baldyga <r.baldyga@samsung.com>2015-09-16 06:11:01 -0400
committerFelipe Balbi <balbi@ti.com>2015-09-27 11:54:31 -0400
commit6e4bfc54083b2b0eff45ad2001f2a3bee9074dcc (patch)
tree9c9e5650eca4557d357c9616b530092473cd3c3a
parentd62bf8c16570eb44e2ea3fc5c1f6a8ab83e52778 (diff)
usb: gadget: u_ether: eliminate abuse of ep->driver data
Since ep->driver_data is not used for endpoint claiming, neither for enabled/disabled state storing, we can reduce number of places where we read or modify it's value, as now it has no particular meaning for function or framework logic. In case of u_ether we only need to store in ep->driver_data pointer to struct eth_dev, as it's used in rx_complete() and tx_complete() callbacks. All other uses of ep->driver_data are now meaningless and can be safely removed. Signed-off-by: Robert Baldyga <r.baldyga@samsung.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/gadget/function/u_ether.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 6828ea294024..6554322af2c1 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -1149,7 +1149,6 @@ void gether_disconnect(struct gether *link)
1149 spin_lock(&dev->req_lock); 1149 spin_lock(&dev->req_lock);
1150 } 1150 }
1151 spin_unlock(&dev->req_lock); 1151 spin_unlock(&dev->req_lock);
1152 link->in_ep->driver_data = NULL;
1153 link->in_ep->desc = NULL; 1152 link->in_ep->desc = NULL;
1154 1153
1155 usb_ep_disable(link->out_ep); 1154 usb_ep_disable(link->out_ep);
@@ -1164,7 +1163,6 @@ void gether_disconnect(struct gether *link)
1164 spin_lock(&dev->req_lock); 1163 spin_lock(&dev->req_lock);
1165 } 1164 }
1166 spin_unlock(&dev->req_lock); 1165 spin_unlock(&dev->req_lock);
1167 link->out_ep->driver_data = NULL;
1168 link->out_ep->desc = NULL; 1166 link->out_ep->desc = NULL;
1169 1167
1170 /* finish forgetting about this USB link episode */ 1168 /* finish forgetting about this USB link episode */