diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-07-06 08:02:09 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2016-07-12 11:33:43 -0400 |
commit | 69555af2ce32a31d11666e5fe20628b35fdf7ef3 (patch) | |
tree | bf8f78689a6ab8ec0c4c064a2ebbcc65bccb1a89 | |
parent | e76debd996c6c0296fbdcba275b4f875e07a0eff (diff) |
nvmet: fix return value check in nvmet_subsys_alloc()
In case of error, the function kstrndup() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r-- | drivers/nvme/target/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index e0b3f0166722..8a891ca53367 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c | |||
@@ -895,7 +895,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn, | |||
895 | subsys->type = type; | 895 | subsys->type = type; |
896 | subsys->subsysnqn = kstrndup(subsysnqn, NVMF_NQN_SIZE, | 896 | subsys->subsysnqn = kstrndup(subsysnqn, NVMF_NQN_SIZE, |
897 | GFP_KERNEL); | 897 | GFP_KERNEL); |
898 | if (IS_ERR(subsys->subsysnqn)) { | 898 | if (!subsys->subsysnqn) { |
899 | kfree(subsys); | 899 | kfree(subsys); |
900 | return NULL; | 900 | return NULL; |
901 | } | 901 | } |