aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWang Shilong <wangsl-fnst@cn.fujitsu.com>2013-04-11 03:08:55 -0400
committerJosef Bacik <jbacik@fusionio.com>2013-05-06 15:54:43 -0400
commit692206b153ea0d08d6015521ed27a6739cbf6f9f (patch)
treea37afdd2c3d0b159550865c3c78e338010031af8
parent1149ab6bd48cf3b00c59e4f8ff79fbb1cf15b94b (diff)
Btrfs: make __merge_refs() return type be void
__merge_refs() always return 0, it is unnecessary for the caller to check the return value. Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
-rw-r--r--fs/btrfs/backref.c11
1 files changed, 3 insertions, 8 deletions
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 66f44c7534d0..7f448b8325a1 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -443,7 +443,7 @@ static int __add_missing_keys(struct btrfs_fs_info *fs_info,
443 * having a parent). 443 * having a parent).
444 * mode = 2: merge identical parents 444 * mode = 2: merge identical parents
445 */ 445 */
446static int __merge_refs(struct list_head *head, int mode) 446static void __merge_refs(struct list_head *head, int mode)
447{ 447{
448 struct list_head *pos1; 448 struct list_head *pos1;
449 449
@@ -489,7 +489,6 @@ static int __merge_refs(struct list_head *head, int mode)
489 } 489 }
490 490
491 } 491 }
492 return 0;
493} 492}
494 493
495/* 494/*
@@ -884,18 +883,14 @@ again:
884 if (ret) 883 if (ret)
885 goto out; 884 goto out;
886 885
887 ret = __merge_refs(&prefs, 1); 886 __merge_refs(&prefs, 1);
888 if (ret)
889 goto out;
890 887
891 ret = __resolve_indirect_refs(fs_info, search_commit_root, time_seq, 888 ret = __resolve_indirect_refs(fs_info, search_commit_root, time_seq,
892 &prefs, extent_item_pos); 889 &prefs, extent_item_pos);
893 if (ret) 890 if (ret)
894 goto out; 891 goto out;
895 892
896 ret = __merge_refs(&prefs, 2); 893 __merge_refs(&prefs, 2);
897 if (ret)
898 goto out;
899 894
900 while (!list_empty(&prefs)) { 895 while (!list_empty(&prefs)) {
901 ref = list_first_entry(&prefs, struct __prelim_ref, list); 896 ref = list_first_entry(&prefs, struct __prelim_ref, list);