aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans Verkuil <hans.verkuil@cisco.com>2016-08-02 07:11:00 -0400
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2016-08-22 12:09:06 -0400
commit62148f0930a8e9bd5c5614f8387222f0220d7d47 (patch)
treed58c85b8e8114a39b7680008241213c817d7ba24
parentfa8410b355251fd30341662a40ac6b22d3e38468 (diff)
[media] cec: rename cec_devnode fhs_lock to just lock
This lock will be used to protect more than just the fhs list. So rename it to just 'lock'. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
-rw-r--r--drivers/staging/media/cec/cec-adap.c12
-rw-r--r--drivers/staging/media/cec/cec-api.c8
-rw-r--r--drivers/staging/media/cec/cec-core.c6
-rw-r--r--include/media/cec.h2
4 files changed, 14 insertions, 14 deletions
diff --git a/drivers/staging/media/cec/cec-adap.c b/drivers/staging/media/cec/cec-adap.c
index b2393bbacb26..9dcb784b8d6a 100644
--- a/drivers/staging/media/cec/cec-adap.c
+++ b/drivers/staging/media/cec/cec-adap.c
@@ -124,10 +124,10 @@ static void cec_queue_event(struct cec_adapter *adap,
124 u64 ts = ktime_get_ns(); 124 u64 ts = ktime_get_ns();
125 struct cec_fh *fh; 125 struct cec_fh *fh;
126 126
127 mutex_lock(&adap->devnode.fhs_lock); 127 mutex_lock(&adap->devnode.lock);
128 list_for_each_entry(fh, &adap->devnode.fhs, list) 128 list_for_each_entry(fh, &adap->devnode.fhs, list)
129 cec_queue_event_fh(fh, ev, ts); 129 cec_queue_event_fh(fh, ev, ts);
130 mutex_unlock(&adap->devnode.fhs_lock); 130 mutex_unlock(&adap->devnode.lock);
131} 131}
132 132
133/* 133/*
@@ -191,12 +191,12 @@ static void cec_queue_msg_monitor(struct cec_adapter *adap,
191 u32 monitor_mode = valid_la ? CEC_MODE_MONITOR : 191 u32 monitor_mode = valid_la ? CEC_MODE_MONITOR :
192 CEC_MODE_MONITOR_ALL; 192 CEC_MODE_MONITOR_ALL;
193 193
194 mutex_lock(&adap->devnode.fhs_lock); 194 mutex_lock(&adap->devnode.lock);
195 list_for_each_entry(fh, &adap->devnode.fhs, list) { 195 list_for_each_entry(fh, &adap->devnode.fhs, list) {
196 if (fh->mode_follower >= monitor_mode) 196 if (fh->mode_follower >= monitor_mode)
197 cec_queue_msg_fh(fh, msg); 197 cec_queue_msg_fh(fh, msg);
198 } 198 }
199 mutex_unlock(&adap->devnode.fhs_lock); 199 mutex_unlock(&adap->devnode.lock);
200} 200}
201 201
202/* 202/*
@@ -207,12 +207,12 @@ static void cec_queue_msg_followers(struct cec_adapter *adap,
207{ 207{
208 struct cec_fh *fh; 208 struct cec_fh *fh;
209 209
210 mutex_lock(&adap->devnode.fhs_lock); 210 mutex_lock(&adap->devnode.lock);
211 list_for_each_entry(fh, &adap->devnode.fhs, list) { 211 list_for_each_entry(fh, &adap->devnode.fhs, list) {
212 if (fh->mode_follower == CEC_MODE_FOLLOWER) 212 if (fh->mode_follower == CEC_MODE_FOLLOWER)
213 cec_queue_msg_fh(fh, msg); 213 cec_queue_msg_fh(fh, msg);
214 } 214 }
215 mutex_unlock(&adap->devnode.fhs_lock); 215 mutex_unlock(&adap->devnode.lock);
216} 216}
217 217
218/* Notify userspace of an adapter state change. */ 218/* Notify userspace of an adapter state change. */
diff --git a/drivers/staging/media/cec/cec-api.c b/drivers/staging/media/cec/cec-api.c
index 7be7615a0fdf..4e2696a34ddb 100644
--- a/drivers/staging/media/cec/cec-api.c
+++ b/drivers/staging/media/cec/cec-api.c
@@ -508,14 +508,14 @@ static int cec_open(struct inode *inode, struct file *filp)
508 508
509 filp->private_data = fh; 509 filp->private_data = fh;
510 510
511 mutex_lock(&devnode->fhs_lock); 511 mutex_lock(&devnode->lock);
512 /* Queue up initial state events */ 512 /* Queue up initial state events */
513 ev_state.state_change.phys_addr = adap->phys_addr; 513 ev_state.state_change.phys_addr = adap->phys_addr;
514 ev_state.state_change.log_addr_mask = adap->log_addrs.log_addr_mask; 514 ev_state.state_change.log_addr_mask = adap->log_addrs.log_addr_mask;
515 cec_queue_event_fh(fh, &ev_state, 0); 515 cec_queue_event_fh(fh, &ev_state, 0);
516 516
517 list_add(&fh->list, &devnode->fhs); 517 list_add(&fh->list, &devnode->fhs);
518 mutex_unlock(&devnode->fhs_lock); 518 mutex_unlock(&devnode->lock);
519 519
520 return 0; 520 return 0;
521} 521}
@@ -540,9 +540,9 @@ static int cec_release(struct inode *inode, struct file *filp)
540 cec_monitor_all_cnt_dec(adap); 540 cec_monitor_all_cnt_dec(adap);
541 mutex_unlock(&adap->lock); 541 mutex_unlock(&adap->lock);
542 542
543 mutex_lock(&devnode->fhs_lock); 543 mutex_lock(&devnode->lock);
544 list_del(&fh->list); 544 list_del(&fh->list);
545 mutex_unlock(&devnode->fhs_lock); 545 mutex_unlock(&devnode->lock);
546 546
547 /* Unhook pending transmits from this filehandle. */ 547 /* Unhook pending transmits from this filehandle. */
548 mutex_lock(&adap->lock); 548 mutex_lock(&adap->lock);
diff --git a/drivers/staging/media/cec/cec-core.c b/drivers/staging/media/cec/cec-core.c
index 112a5fae12f5..73792d078462 100644
--- a/drivers/staging/media/cec/cec-core.c
+++ b/drivers/staging/media/cec/cec-core.c
@@ -117,7 +117,7 @@ static int __must_check cec_devnode_register(struct cec_devnode *devnode,
117 117
118 /* Initialization */ 118 /* Initialization */
119 INIT_LIST_HEAD(&devnode->fhs); 119 INIT_LIST_HEAD(&devnode->fhs);
120 mutex_init(&devnode->fhs_lock); 120 mutex_init(&devnode->lock);
121 121
122 /* Part 1: Find a free minor number */ 122 /* Part 1: Find a free minor number */
123 mutex_lock(&cec_devnode_lock); 123 mutex_lock(&cec_devnode_lock);
@@ -181,10 +181,10 @@ static void cec_devnode_unregister(struct cec_devnode *devnode)
181 if (!devnode->registered || devnode->unregistered) 181 if (!devnode->registered || devnode->unregistered)
182 return; 182 return;
183 183
184 mutex_lock(&devnode->fhs_lock); 184 mutex_lock(&devnode->lock);
185 list_for_each_entry(fh, &devnode->fhs, list) 185 list_for_each_entry(fh, &devnode->fhs, list)
186 wake_up_interruptible(&fh->wait); 186 wake_up_interruptible(&fh->wait);
187 mutex_unlock(&devnode->fhs_lock); 187 mutex_unlock(&devnode->lock);
188 188
189 devnode->registered = false; 189 devnode->registered = false;
190 devnode->unregistered = true; 190 devnode->unregistered = true;
diff --git a/include/media/cec.h b/include/media/cec.h
index dc7854b855f3..fdb5d600e4bb 100644
--- a/include/media/cec.h
+++ b/include/media/cec.h
@@ -57,8 +57,8 @@ struct cec_devnode {
57 int minor; 57 int minor;
58 bool registered; 58 bool registered;
59 bool unregistered; 59 bool unregistered;
60 struct mutex fhs_lock;
61 struct list_head fhs; 60 struct list_head fhs;
61 struct mutex lock;
62}; 62};
63 63
64struct cec_adapter; 64struct cec_adapter;