diff options
author | Christophe Jaillet <christophe.jaillet@wanadoo.fr> | 2016-07-02 08:31:05 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-07-04 18:22:33 -0400 |
commit | 5d4de16c6db6ecc51a549bfbf7ca1c11c82a4240 (patch) | |
tree | e7240e5433646492b3d695a53a644d82afcc06e1 | |
parent | 61cc535de36838bf4cfe08c8c4eeaad1ca4a89b1 (diff) |
net/mlx4: Fix some indent inconsistancy
Silent a few smatch warnings about indentation.
This include the removal of a 'return' statement in 'resource_tracker.c'.
This 'return' will still be performed when breaking out of the
corresponding 'switch' block.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/intf.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/main.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/mcg.c | 8 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/mr.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 22 |
5 files changed, 17 insertions, 19 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c b/drivers/net/ethernet/mellanox/mlx4/intf.c index dec77d6f0ac9..7ae1cdad9bf0 100644 --- a/drivers/net/ethernet/mellanox/mlx4/intf.c +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c | |||
@@ -147,7 +147,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable) | |||
147 | if (enable) { | 147 | if (enable) { |
148 | dev->flags |= MLX4_FLAG_BONDED; | 148 | dev->flags |= MLX4_FLAG_BONDED; |
149 | } else { | 149 | } else { |
150 | ret = mlx4_virt2phy_port_map(dev, 1, 2); | 150 | ret = mlx4_virt2phy_port_map(dev, 1, 2); |
151 | if (ret) { | 151 | if (ret) { |
152 | mlx4_err(dev, "Fail to reset port map\n"); | 152 | mlx4_err(dev, "Fail to reset port map\n"); |
153 | return ret; | 153 | return ret; |
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index b673a5fc6b6c..75dd2e3d3059 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c | |||
@@ -2600,7 +2600,7 @@ static int mlx4_setup_hca(struct mlx4_dev *dev) | |||
2600 | err = mlx4_init_uar_table(dev); | 2600 | err = mlx4_init_uar_table(dev); |
2601 | if (err) { | 2601 | if (err) { |
2602 | mlx4_err(dev, "Failed to initialize user access region table, aborting\n"); | 2602 | mlx4_err(dev, "Failed to initialize user access region table, aborting\n"); |
2603 | return err; | 2603 | return err; |
2604 | } | 2604 | } |
2605 | 2605 | ||
2606 | err = mlx4_uar_alloc(dev, &priv->driver_uar); | 2606 | err = mlx4_uar_alloc(dev, &priv->driver_uar); |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c index f2d0920018a5..94b891c118c1 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c | |||
@@ -618,8 +618,8 @@ static int remove_promisc_qp(struct mlx4_dev *dev, u8 port, | |||
618 | err = mlx4_READ_ENTRY(dev, | 618 | err = mlx4_READ_ENTRY(dev, |
619 | entry->index, | 619 | entry->index, |
620 | mailbox); | 620 | mailbox); |
621 | if (err) | 621 | if (err) |
622 | goto out_mailbox; | 622 | goto out_mailbox; |
623 | members_count = | 623 | members_count = |
624 | be32_to_cpu(mgm->members_count) & | 624 | be32_to_cpu(mgm->members_count) & |
625 | 0xffffff; | 625 | 0xffffff; |
@@ -657,8 +657,8 @@ static int remove_promisc_qp(struct mlx4_dev *dev, u8 port, | |||
657 | err = mlx4_WRITE_ENTRY(dev, | 657 | err = mlx4_WRITE_ENTRY(dev, |
658 | entry->index, | 658 | entry->index, |
659 | mailbox); | 659 | mailbox); |
660 | if (err) | 660 | if (err) |
661 | goto out_mailbox; | 661 | goto out_mailbox; |
662 | } | 662 | } |
663 | } | 663 | } |
664 | } | 664 | } |
diff --git a/drivers/net/ethernet/mellanox/mlx4/mr.c b/drivers/net/ethernet/mellanox/mlx4/mr.c index 93195191f45b..395b5463cfd9 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mr.c +++ b/drivers/net/ethernet/mellanox/mlx4/mr.c | |||
@@ -248,7 +248,7 @@ static void mlx4_free_mtt_range(struct mlx4_dev *dev, u32 offset, int order) | |||
248 | offset, order); | 248 | offset, order); |
249 | return; | 249 | return; |
250 | } | 250 | } |
251 | __mlx4_free_mtt_range(dev, offset, order); | 251 | __mlx4_free_mtt_range(dev, offset, order); |
252 | } | 252 | } |
253 | 253 | ||
254 | void mlx4_mtt_cleanup(struct mlx4_dev *dev, struct mlx4_mtt *mtt) | 254 | void mlx4_mtt_cleanup(struct mlx4_dev *dev, struct mlx4_mtt *mtt) |
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c index cd9b2b28df88..8b81114bdc72 100644 --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | |||
@@ -2372,16 +2372,15 @@ static int mpt_free_res(struct mlx4_dev *dev, int slave, int op, int cmd, | |||
2372 | __mlx4_mpt_release(dev, index); | 2372 | __mlx4_mpt_release(dev, index); |
2373 | break; | 2373 | break; |
2374 | case RES_OP_MAP_ICM: | 2374 | case RES_OP_MAP_ICM: |
2375 | index = get_param_l(&in_param); | 2375 | index = get_param_l(&in_param); |
2376 | id = index & mpt_mask(dev); | 2376 | id = index & mpt_mask(dev); |
2377 | err = mr_res_start_move_to(dev, slave, id, | 2377 | err = mr_res_start_move_to(dev, slave, id, |
2378 | RES_MPT_RESERVED, &mpt); | 2378 | RES_MPT_RESERVED, &mpt); |
2379 | if (err) | 2379 | if (err) |
2380 | return err; | ||
2381 | |||
2382 | __mlx4_mpt_free_icm(dev, mpt->key); | ||
2383 | res_end_move(dev, slave, RES_MPT, id); | ||
2384 | return err; | 2380 | return err; |
2381 | |||
2382 | __mlx4_mpt_free_icm(dev, mpt->key); | ||
2383 | res_end_move(dev, slave, RES_MPT, id); | ||
2385 | break; | 2384 | break; |
2386 | default: | 2385 | default: |
2387 | err = -EINVAL; | 2386 | err = -EINVAL; |
@@ -4253,9 +4252,8 @@ int mlx4_UPDATE_QP_wrapper(struct mlx4_dev *dev, int slave, | |||
4253 | (1ULL << MLX4_UPD_QP_PATH_MASK_ETH_SRC_CHECK_MC_LB)) && | 4252 | (1ULL << MLX4_UPD_QP_PATH_MASK_ETH_SRC_CHECK_MC_LB)) && |
4254 | !(dev->caps.flags2 & | 4253 | !(dev->caps.flags2 & |
4255 | MLX4_DEV_CAP_FLAG2_UPDATE_QP_SRC_CHECK_LB)) { | 4254 | MLX4_DEV_CAP_FLAG2_UPDATE_QP_SRC_CHECK_LB)) { |
4256 | mlx4_warn(dev, | 4255 | mlx4_warn(dev, "Src check LB for slave %d isn't supported\n", |
4257 | "Src check LB for slave %d isn't supported\n", | 4256 | slave); |
4258 | slave); | ||
4259 | return -ENOTSUPP; | 4257 | return -ENOTSUPP; |
4260 | } | 4258 | } |
4261 | 4259 | ||