diff options
| author | Muhammad Falak R Wani <falakreyaz@gmail.com> | 2016-05-19 09:54:41 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-05-20 19:50:07 -0400 |
| commit | 5877debe27917dfd7aa8f960c228dbbc1de8282f (patch) | |
| tree | 049b91d1bf2ecce9a53961c964adfc0f09ee7e07 | |
| parent | 7c542772cc5ff061ec3d06658f5d36304bcd5395 (diff) | |
ps3_gelic: use kmemdup
Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c index 743b18266a7c..446ea580ad42 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | |||
| @@ -1616,13 +1616,13 @@ static void gelic_wl_scan_complete_event(struct gelic_wl_info *wl) | |||
| 1616 | target->valid = 1; | 1616 | target->valid = 1; |
| 1617 | target->eurus_index = i; | 1617 | target->eurus_index = i; |
| 1618 | kfree(target->hwinfo); | 1618 | kfree(target->hwinfo); |
| 1619 | target->hwinfo = kzalloc(be16_to_cpu(scan_info->size), | 1619 | target->hwinfo = kmemdup(scan_info, |
| 1620 | be16_to_cpu(scan_info->size), | ||
| 1620 | GFP_KERNEL); | 1621 | GFP_KERNEL); |
| 1621 | if (!target->hwinfo) | 1622 | if (!target->hwinfo) |
| 1622 | continue; | 1623 | continue; |
| 1623 | 1624 | ||
| 1624 | /* copy hw scan info */ | 1625 | /* copy hw scan info */ |
| 1625 | memcpy(target->hwinfo, scan_info, be16_to_cpu(scan_info->size)); | ||
| 1626 | target->essid_len = strnlen(scan_info->essid, | 1626 | target->essid_len = strnlen(scan_info->essid, |
| 1627 | sizeof(scan_info->essid)); | 1627 | sizeof(scan_info->essid)); |
| 1628 | target->rate_len = 0; | 1628 | target->rate_len = 0; |
