aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-11-04 14:00:42 -0500
committerRichard Weinberger <richard@nod.at>2015-11-06 17:26:52 -0500
commit54bcfdf19ec7c2f2788fa76426c91abdc4dab973 (patch)
tree71f95afe9a00c706ceb563f1d2c9089ec433c201
parenta396ce4bd21dd67bcec2aabc05f81fd2fa14f820 (diff)
UBIFS: Delete unnecessary checks before the function call "iput"
The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Richard Weinberger <richard@nod.at>
-rw-r--r--fs/ubifs/recovery.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 2a1f0bc836be..586d59347fff 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -1331,8 +1331,7 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
1331 struct size_entry *e, *n; 1331 struct size_entry *e, *n;
1332 1332
1333 rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) { 1333 rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
1334 if (e->inode) 1334 iput(e->inode);
1335 iput(e->inode);
1336 kfree(e); 1335 kfree(e);
1337 } 1336 }
1338 1337
@@ -1533,8 +1532,7 @@ int ubifs_recover_size(struct ubifs_info *c)
1533 err = fix_size_in_place(c, e); 1532 err = fix_size_in_place(c, e);
1534 if (err) 1533 if (err)
1535 return err; 1534 return err;
1536 if (e->inode) 1535 iput(e->inode);
1537 iput(e->inode);
1538 } 1536 }
1539 } 1537 }
1540 1538