aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-09-14 06:13:06 -0400
committerLinus Walleij <linus.walleij@linaro.org>2016-09-15 08:13:10 -0400
commit49cf2f29acab4ab0f14ff0d574cd4d3a76bdce53 (patch)
tree7b69d7dba728d0b234703e4c812de227dd24fe9f
parent6812f19e17c1ac67774175023824bdcbe9a23674 (diff)
pinctrl: stm32: add IRQ_DOMAIN_HIERARCHY dependency
The newly added irqchip support for the stm32 pinctrl driver uses hierarchical IRQ domains as provided by the NVIC primary irqchip. This works great for any configuration that may be relevant on stm32, but when doing compile-testing (randconfig), we can enable it without NVIC or any other primary irqchip that enables IRQ_DOMAIN_HIERARCHY: drivers/pinctrl/stm32/pinctrl-stm32.c:212:13: error: 'irq_chip_eoi_parent' undeclared here (not in a function) drivers/pinctrl/stm32/pinctrl-stm32.c:213:20: error: 'irq_chip_mask_parent' undeclared here (not in a function) drivers/pinctrl/stm32/pinctrl-stm32.c:214:20: error: 'irq_chip_unmask_parent' undeclared here (not in a function) drivers/pinctrl/stm32/pinctrl-stm32.c:215:20: error: 'irq_chip_set_type_parent' undeclared here (not in a function) This adds a Kconfig dependency to limit compile-testing to configurations that have IRQ_DOMAIN_HIERARCHY already enabled. It's not obvious whether we should use 'depends on' or 'select' here, I think either one works, with 'depends on' being more intuitive, while 'select' would be less likely to cause dependency loops. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 0eb9f683336d ("pinctrl: Add IRQ support to STM32 gpios") Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/pinctrl/stm32/Kconfig4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
index 24bc68308af2..c03dce7a22df 100644
--- a/drivers/pinctrl/stm32/Kconfig
+++ b/drivers/pinctrl/stm32/Kconfig
@@ -10,13 +10,13 @@ config PINCTRL_STM32
10 10
11config PINCTRL_STM32F429 11config PINCTRL_STM32F429
12 bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 12 bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429
13 depends on OF 13 depends on OF && IRQ_DOMAIN_HIERARCHY
14 default MACH_STM32F429 14 default MACH_STM32F429
15 select PINCTRL_STM32 15 select PINCTRL_STM32
16 16
17config PINCTRL_STM32F746 17config PINCTRL_STM32F746
18 bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746 18 bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746
19 depends on OF 19 depends on OF && IRQ_DOMAIN_HIERARCHY
20 default MACH_STM32F746 20 default MACH_STM32F746
21 select PINCTRL_STM32 21 select PINCTRL_STM32
22 22