diff options
author | Marc Zyngier <marc.zyngier@arm.com> | 2017-03-16 14:20:49 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-12 06:41:11 -0400 |
commit | 48f2825abc65943437033adfd05b59e287ea3bfd (patch) | |
tree | d1fec1bc62d4175a439f435f4e8b2de46d9d4356 | |
parent | 8f8de8d2bf6cd0efc49116afd3aa02b64730d74e (diff) |
arm/arm64: KVM: Take mmap_sem in stage2_unmap_vm
commit 90f6e150e44a0dc3883110eeb3ab35d1be42b6bb upstream.
We don't hold the mmap_sem while searching for the VMAs when
we try to unmap each memslot for a VM. Fix this properly to
avoid unexpected results.
Fixes: commit 957db105c997 ("arm/arm64: KVM: Introduce stage2_unmap_vm")
Reviewed-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | arch/arm/kvm/mmu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index a5265edbeeab..089f9df16d49 100644 --- a/arch/arm/kvm/mmu.c +++ b/arch/arm/kvm/mmu.c | |||
@@ -803,6 +803,7 @@ void stage2_unmap_vm(struct kvm *kvm) | |||
803 | int idx; | 803 | int idx; |
804 | 804 | ||
805 | idx = srcu_read_lock(&kvm->srcu); | 805 | idx = srcu_read_lock(&kvm->srcu); |
806 | down_read(¤t->mm->mmap_sem); | ||
806 | spin_lock(&kvm->mmu_lock); | 807 | spin_lock(&kvm->mmu_lock); |
807 | 808 | ||
808 | slots = kvm_memslots(kvm); | 809 | slots = kvm_memslots(kvm); |
@@ -810,6 +811,7 @@ void stage2_unmap_vm(struct kvm *kvm) | |||
810 | stage2_unmap_memslot(kvm, memslot); | 811 | stage2_unmap_memslot(kvm, memslot); |
811 | 812 | ||
812 | spin_unlock(&kvm->mmu_lock); | 813 | spin_unlock(&kvm->mmu_lock); |
814 | up_read(¤t->mm->mmap_sem); | ||
813 | srcu_read_unlock(&kvm->srcu, idx); | 815 | srcu_read_unlock(&kvm->srcu, idx); |
814 | } | 816 | } |
815 | 817 | ||