diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-11 09:21:23 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-11 09:21:23 -0400 |
commit | 3d7a8278fdfdea5be4c647853171a0df5d13c1d3 (patch) | |
tree | b80b6f13899a06e88cd379f60bff1940e7bb9323 | |
parent | 05c0006776374a1013bc30a7daeee3f8017147f2 (diff) |
Revert "pcmcia: add a new resource manager for non ISA systems"
This reverts commit 02b03846bb2befc558bfd0665749d6bb26f4c2f1.
Alan writes:
it seems there is a regression in there for some configuration of I/O
based devices. I'll take a look at it over the next couple of kernel
releases and see what is up then resubmit it with fixes.
Reported-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/pcmcia/Kconfig | 12 | ||||
-rw-r--r-- | drivers/pcmcia/Makefile | 1 | ||||
-rw-r--r-- | drivers/pcmcia/rsrc_pci.c | 172 |
3 files changed, 3 insertions, 182 deletions
diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig index 3bb49252a098..45f67c63d385 100644 --- a/drivers/pcmcia/Kconfig +++ b/drivers/pcmcia/Kconfig | |||
@@ -69,8 +69,7 @@ config YENTA | |||
69 | tristate "CardBus yenta-compatible bridge support" | 69 | tristate "CardBus yenta-compatible bridge support" |
70 | depends on PCI | 70 | depends on PCI |
71 | select CARDBUS if !EXPERT | 71 | select CARDBUS if !EXPERT |
72 | select PCCARD_NONSTATIC if PCMCIA != n && ISA | 72 | select PCCARD_NONSTATIC if PCMCIA != n |
73 | select PCCARD_PCI if PCMCIA !=n && !ISA | ||
74 | ---help--- | 73 | ---help--- |
75 | This option enables support for CardBus host bridges. Virtually | 74 | This option enables support for CardBus host bridges. Virtually |
76 | all modern PCMCIA bridges are CardBus compatible. A "bridge" is | 75 | all modern PCMCIA bridges are CardBus compatible. A "bridge" is |
@@ -110,8 +109,7 @@ config YENTA_TOSHIBA | |||
110 | config PD6729 | 109 | config PD6729 |
111 | tristate "Cirrus PD6729 compatible bridge support" | 110 | tristate "Cirrus PD6729 compatible bridge support" |
112 | depends on PCMCIA && PCI | 111 | depends on PCMCIA && PCI |
113 | select PCCARD_NONSTATIC if PCMCIA != n && ISA | 112 | select PCCARD_NONSTATIC |
114 | select PCCARD_PCI if PCMCIA !=n && !ISA | ||
115 | help | 113 | help |
116 | This provides support for the Cirrus PD6729 PCI-to-PCMCIA bridge | 114 | This provides support for the Cirrus PD6729 PCI-to-PCMCIA bridge |
117 | device, found in some older laptops and PCMCIA card readers. | 115 | device, found in some older laptops and PCMCIA card readers. |
@@ -119,8 +117,7 @@ config PD6729 | |||
119 | config I82092 | 117 | config I82092 |
120 | tristate "i82092 compatible bridge support" | 118 | tristate "i82092 compatible bridge support" |
121 | depends on PCMCIA && PCI | 119 | depends on PCMCIA && PCI |
122 | select PCCARD_NONSTATIC if PCMCIA != n && ISA | 120 | select PCCARD_NONSTATIC |
123 | select PCCARD_PCI if PCMCIA !=n && !ISA | ||
124 | help | 121 | help |
125 | This provides support for the Intel I82092AA PCI-to-PCMCIA bridge device, | 122 | This provides support for the Intel I82092AA PCI-to-PCMCIA bridge device, |
126 | found in some older laptops and more commonly in evaluation boards for the | 123 | found in some older laptops and more commonly in evaluation boards for the |
@@ -291,9 +288,6 @@ config ELECTRA_CF | |||
291 | Say Y here to support the CompactFlash controller on the | 288 | Say Y here to support the CompactFlash controller on the |
292 | PA Semi Electra eval board. | 289 | PA Semi Electra eval board. |
293 | 290 | ||
294 | config PCCARD_PCI | ||
295 | bool | ||
296 | |||
297 | config PCCARD_NONSTATIC | 291 | config PCCARD_NONSTATIC |
298 | bool | 292 | bool |
299 | 293 | ||
diff --git a/drivers/pcmcia/Makefile b/drivers/pcmcia/Makefile index f1a7ca04d89e..27e94b30cf96 100644 --- a/drivers/pcmcia/Makefile +++ b/drivers/pcmcia/Makefile | |||
@@ -12,7 +12,6 @@ obj-$(CONFIG_PCMCIA) += pcmcia.o | |||
12 | pcmcia_rsrc-y += rsrc_mgr.o | 12 | pcmcia_rsrc-y += rsrc_mgr.o |
13 | pcmcia_rsrc-$(CONFIG_PCCARD_NONSTATIC) += rsrc_nonstatic.o | 13 | pcmcia_rsrc-$(CONFIG_PCCARD_NONSTATIC) += rsrc_nonstatic.o |
14 | pcmcia_rsrc-$(CONFIG_PCCARD_IODYN) += rsrc_iodyn.o | 14 | pcmcia_rsrc-$(CONFIG_PCCARD_IODYN) += rsrc_iodyn.o |
15 | pcmcia_rsrc-$(CONFIG_PCCARD_PCI) += rsrc_pci.o | ||
16 | obj-$(CONFIG_PCCARD) += pcmcia_rsrc.o | 15 | obj-$(CONFIG_PCCARD) += pcmcia_rsrc.o |
17 | 16 | ||
18 | 17 | ||
diff --git a/drivers/pcmcia/rsrc_pci.c b/drivers/pcmcia/rsrc_pci.c deleted file mode 100644 index 8934d3c01f80..000000000000 --- a/drivers/pcmcia/rsrc_pci.c +++ /dev/null | |||
@@ -1,172 +0,0 @@ | |||
1 | #include <linux/slab.h> | ||
2 | #include <linux/module.h> | ||
3 | #include <linux/kernel.h> | ||
4 | |||
5 | #include <pcmcia/ss.h> | ||
6 | #include <pcmcia/cistpl.h> | ||
7 | #include "cs_internal.h" | ||
8 | |||
9 | |||
10 | struct pcmcia_align_data { | ||
11 | unsigned long mask; | ||
12 | unsigned long offset; | ||
13 | }; | ||
14 | |||
15 | static resource_size_t pcmcia_align(void *align_data, | ||
16 | const struct resource *res, | ||
17 | resource_size_t size, resource_size_t align) | ||
18 | { | ||
19 | struct pcmcia_align_data *data = align_data; | ||
20 | resource_size_t start; | ||
21 | |||
22 | start = (res->start & ~data->mask) + data->offset; | ||
23 | if (start < res->start) | ||
24 | start += data->mask + 1; | ||
25 | return start; | ||
26 | } | ||
27 | |||
28 | static struct resource *find_io_region(struct pcmcia_socket *s, | ||
29 | unsigned long base, int num, | ||
30 | unsigned long align) | ||
31 | { | ||
32 | struct resource *res = pcmcia_make_resource(0, num, IORESOURCE_IO, | ||
33 | dev_name(&s->dev)); | ||
34 | struct pcmcia_align_data data; | ||
35 | int ret; | ||
36 | |||
37 | data.mask = align - 1; | ||
38 | data.offset = base & data.mask; | ||
39 | |||
40 | ret = pci_bus_alloc_resource(s->cb_dev->bus, res, num, 1, | ||
41 | base, 0, pcmcia_align, &data); | ||
42 | if (ret != 0) { | ||
43 | kfree(res); | ||
44 | res = NULL; | ||
45 | } | ||
46 | return res; | ||
47 | } | ||
48 | |||
49 | static int res_pci_find_io(struct pcmcia_socket *s, unsigned int attr, | ||
50 | unsigned int *base, unsigned int num, | ||
51 | unsigned int align, struct resource **parent) | ||
52 | { | ||
53 | int i, ret = 0; | ||
54 | |||
55 | /* Check for an already-allocated window that must conflict with | ||
56 | * what was asked for. It is a hack because it does not catch all | ||
57 | * potential conflicts, just the most obvious ones. | ||
58 | */ | ||
59 | for (i = 0; i < MAX_IO_WIN; i++) { | ||
60 | if (!s->io[i].res) | ||
61 | continue; | ||
62 | |||
63 | if (!*base) | ||
64 | continue; | ||
65 | |||
66 | if ((s->io[i].res->start & (align-1)) == *base) | ||
67 | return -EBUSY; | ||
68 | } | ||
69 | |||
70 | for (i = 0; i < MAX_IO_WIN; i++) { | ||
71 | struct resource *res = s->io[i].res; | ||
72 | unsigned int try; | ||
73 | |||
74 | if (res && (res->flags & IORESOURCE_BITS) != | ||
75 | (attr & IORESOURCE_BITS)) | ||
76 | continue; | ||
77 | |||
78 | if (!res) { | ||
79 | if (align == 0) | ||
80 | align = 0x10000; | ||
81 | |||
82 | res = s->io[i].res = find_io_region(s, *base, num, | ||
83 | align); | ||
84 | if (!res) | ||
85 | return -EINVAL; | ||
86 | |||
87 | *base = res->start; | ||
88 | s->io[i].res->flags = | ||
89 | ((res->flags & ~IORESOURCE_BITS) | | ||
90 | (attr & IORESOURCE_BITS)); | ||
91 | s->io[i].InUse = num; | ||
92 | *parent = res; | ||
93 | return 0; | ||
94 | } | ||
95 | |||
96 | /* Try to extend top of window */ | ||
97 | try = res->end + 1; | ||
98 | if ((*base == 0) || (*base == try)) { | ||
99 | ret = adjust_resource(s->io[i].res, res->start, | ||
100 | resource_size(res) + num); | ||
101 | if (ret) | ||
102 | continue; | ||
103 | *base = try; | ||
104 | s->io[i].InUse += num; | ||
105 | *parent = res; | ||
106 | return 0; | ||
107 | } | ||
108 | |||
109 | /* Try to extend bottom of window */ | ||
110 | try = res->start - num; | ||
111 | if ((*base == 0) || (*base == try)) { | ||
112 | ret = adjust_resource(s->io[i].res, | ||
113 | res->start - num, | ||
114 | resource_size(res) + num); | ||
115 | if (ret) | ||
116 | continue; | ||
117 | *base = try; | ||
118 | s->io[i].InUse += num; | ||
119 | *parent = res; | ||
120 | return 0; | ||
121 | } | ||
122 | } | ||
123 | return -EINVAL; | ||
124 | } | ||
125 | |||
126 | static struct resource *res_pci_find_mem(u_long base, u_long num, | ||
127 | u_long align, int low, struct pcmcia_socket *s) | ||
128 | { | ||
129 | struct resource *res = pcmcia_make_resource(0, num, IORESOURCE_MEM, | ||
130 | dev_name(&s->dev)); | ||
131 | struct pcmcia_align_data data; | ||
132 | unsigned long min; | ||
133 | int ret; | ||
134 | |||
135 | if (align < 0x20000) | ||
136 | align = 0x20000; | ||
137 | data.mask = align - 1; | ||
138 | data.offset = base & data.mask; | ||
139 | |||
140 | min = 0; | ||
141 | if (!low) | ||
142 | min = 0x100000UL; | ||
143 | |||
144 | ret = pci_bus_alloc_resource(s->cb_dev->bus, | ||
145 | res, num, 1, min, 0, | ||
146 | pcmcia_align, &data); | ||
147 | |||
148 | if (ret != 0) { | ||
149 | kfree(res); | ||
150 | res = NULL; | ||
151 | } | ||
152 | return res; | ||
153 | } | ||
154 | |||
155 | |||
156 | static int res_pci_init(struct pcmcia_socket *s) | ||
157 | { | ||
158 | if (!s->cb_dev || (!s->features & SS_CAP_PAGE_REGS)) { | ||
159 | dev_err(&s->dev, "not supported by res_pci\n"); | ||
160 | return -EOPNOTSUPP; | ||
161 | } | ||
162 | return 0; | ||
163 | } | ||
164 | |||
165 | struct pccard_resource_ops pccard_nonstatic_ops = { | ||
166 | .validate_mem = NULL, | ||
167 | .find_io = res_pci_find_io, | ||
168 | .find_mem = res_pci_find_mem, | ||
169 | .init = res_pci_init, | ||
170 | .exit = NULL, | ||
171 | }; | ||
172 | EXPORT_SYMBOL(pccard_nonstatic_ops); | ||