diff options
author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2014-12-02 18:10:53 -0500 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2015-02-02 12:57:45 -0500 |
commit | 3d30079c3a9000504cf71e4e8dd94619070dc4f3 (patch) | |
tree | 63d0d379c8505308ee6e9f36ddcb614d196f9212 | |
parent | 91c40f24faadd977ee9209fee6a760e72a50d19c (diff) |
scsi: merge consecutive seq_puts calls
Consecutive seq_puts calls with literal strings may be replaced by a
single call, saving a little .text.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r-- | drivers/scsi/advansys.c | 43 | ||||
-rw-r--r-- | drivers/scsi/atp870u.c | 5 | ||||
-rw-r--r-- | drivers/scsi/dc395x.c | 4 | ||||
-rw-r--r-- | drivers/scsi/pcmcia/nsp_cs.c | 4 |
4 files changed, 21 insertions, 35 deletions
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 9cdad1de9ae3..c91a39916d90 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c | |||
@@ -2903,11 +2903,9 @@ static void asc_prt_adv_bios(struct seq_file *m, struct Scsi_Host *shost) | |||
2903 | * the BIOS code segment base address. | 2903 | * the BIOS code segment base address. |
2904 | */ | 2904 | */ |
2905 | if (boardp->bios_signature != 0x55AA) { | 2905 | if (boardp->bios_signature != 0x55AA) { |
2906 | seq_puts(m, "Disabled or Pre-3.1\n"); | 2906 | seq_puts(m, "Disabled or Pre-3.1\n" |
2907 | seq_puts(m, | 2907 | "BIOS either disabled or Pre-3.1. If it is pre-3.1, then a newer version\n" |
2908 | "BIOS either disabled or Pre-3.1. If it is pre-3.1, then a newer version\n"); | 2908 | "can be found at the ConnectCom FTP site: ftp://ftp.connectcom.net/pub\n"); |
2909 | seq_puts(m, | ||
2910 | "can be found at the ConnectCom FTP site: ftp://ftp.connectcom.net/pub\n"); | ||
2911 | } else { | 2909 | } else { |
2912 | major = (boardp->bios_version >> 12) & 0xF; | 2910 | major = (boardp->bios_version >> 12) & 0xF; |
2913 | minor = (boardp->bios_version >> 8) & 0xF; | 2911 | minor = (boardp->bios_version >> 8) & 0xF; |
@@ -2923,9 +2921,8 @@ static void asc_prt_adv_bios(struct seq_file *m, struct Scsi_Host *shost) | |||
2923 | */ | 2921 | */ |
2924 | if (major < 3 || (major <= 3 && minor < 1) || | 2922 | if (major < 3 || (major <= 3 && minor < 1) || |
2925 | (major <= 3 && minor <= 1 && letter < ('I' - 'A'))) { | 2923 | (major <= 3 && minor <= 1 && letter < ('I' - 'A'))) { |
2926 | seq_puts(m, | 2924 | seq_puts(m, "Newer version of ROM BIOS is available at the ConnectCom FTP site:\n" |
2927 | "Newer version of ROM BIOS is available at the ConnectCom FTP site:\n"); | 2925 | "ftp://ftp.connectcom.net/pub\n"); |
2928 | seq_puts(m, "ftp://ftp.connectcom.net/pub\n"); | ||
2929 | } | 2926 | } |
2930 | } | 2927 | } |
2931 | } | 2928 | } |
@@ -3071,27 +3068,23 @@ static void asc_prt_asc_board_eeprom(struct seq_file *m, struct Scsi_Host *shost | |||
3071 | seq_puts(m, " Target ID: "); | 3068 | seq_puts(m, " Target ID: "); |
3072 | for (i = 0; i <= ASC_MAX_TID; i++) | 3069 | for (i = 0; i <= ASC_MAX_TID; i++) |
3073 | seq_printf(m, " %d", i); | 3070 | seq_printf(m, " %d", i); |
3074 | seq_puts(m, "\n"); | ||
3075 | 3071 | ||
3076 | seq_puts(m, " Disconnects: "); | 3072 | seq_puts(m, "\n Disconnects: "); |
3077 | for (i = 0; i <= ASC_MAX_TID; i++) | 3073 | for (i = 0; i <= ASC_MAX_TID; i++) |
3078 | seq_printf(m, " %c", | 3074 | seq_printf(m, " %c", |
3079 | (ep->disc_enable & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); | 3075 | (ep->disc_enable & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); |
3080 | seq_puts(m, "\n"); | ||
3081 | 3076 | ||
3082 | seq_puts(m, " Command Queuing: "); | 3077 | seq_puts(m, "\n Command Queuing: "); |
3083 | for (i = 0; i <= ASC_MAX_TID; i++) | 3078 | for (i = 0; i <= ASC_MAX_TID; i++) |
3084 | seq_printf(m, " %c", | 3079 | seq_printf(m, " %c", |
3085 | (ep->use_cmd_qng & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); | 3080 | (ep->use_cmd_qng & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); |
3086 | seq_puts(m, "\n"); | ||
3087 | 3081 | ||
3088 | seq_puts(m, " Start Motor: "); | 3082 | seq_puts(m, "\n Start Motor: "); |
3089 | for (i = 0; i <= ASC_MAX_TID; i++) | 3083 | for (i = 0; i <= ASC_MAX_TID; i++) |
3090 | seq_printf(m, " %c", | 3084 | seq_printf(m, " %c", |
3091 | (ep->start_motor & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); | 3085 | (ep->start_motor & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); |
3092 | seq_puts(m, "\n"); | ||
3093 | 3086 | ||
3094 | seq_puts(m, " Synchronous Transfer:"); | 3087 | seq_puts(m, "\n Synchronous Transfer:"); |
3095 | for (i = 0; i <= ASC_MAX_TID; i++) | 3088 | for (i = 0; i <= ASC_MAX_TID; i++) |
3096 | seq_printf(m, " %c", | 3089 | seq_printf(m, " %c", |
3097 | (ep->init_sdtr & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); | 3090 | (ep->init_sdtr & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); |
@@ -3410,10 +3403,9 @@ static void asc_prt_asc_board_info(struct seq_file *m, struct Scsi_Host *shost) | |||
3410 | i, | 3403 | i, |
3411 | (v->use_tagged_qng & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); | 3404 | (v->use_tagged_qng & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); |
3412 | } | 3405 | } |
3413 | seq_puts(m, "\n"); | ||
3414 | 3406 | ||
3415 | /* Current number of commands waiting for a device. */ | 3407 | /* Current number of commands waiting for a device. */ |
3416 | seq_puts(m, " Command Queue Pending:"); | 3408 | seq_puts(m, "\n Command Queue Pending:"); |
3417 | for (i = 0; i <= ASC_MAX_TID; i++) { | 3409 | for (i = 0; i <= ASC_MAX_TID; i++) { |
3418 | if ((chip_scsi_id == i) || | 3410 | if ((chip_scsi_id == i) || |
3419 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { | 3411 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { |
@@ -3421,10 +3413,9 @@ static void asc_prt_asc_board_info(struct seq_file *m, struct Scsi_Host *shost) | |||
3421 | } | 3413 | } |
3422 | seq_printf(m, " %X:%u", i, v->cur_dvc_qng[i]); | 3414 | seq_printf(m, " %X:%u", i, v->cur_dvc_qng[i]); |
3423 | } | 3415 | } |
3424 | seq_puts(m, "\n"); | ||
3425 | 3416 | ||
3426 | /* Current limit on number of commands that can be sent to a device. */ | 3417 | /* Current limit on number of commands that can be sent to a device. */ |
3427 | seq_puts(m, " Command Queue Limit:"); | 3418 | seq_puts(m, "\n Command Queue Limit:"); |
3428 | for (i = 0; i <= ASC_MAX_TID; i++) { | 3419 | for (i = 0; i <= ASC_MAX_TID; i++) { |
3429 | if ((chip_scsi_id == i) || | 3420 | if ((chip_scsi_id == i) || |
3430 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { | 3421 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { |
@@ -3432,10 +3423,9 @@ static void asc_prt_asc_board_info(struct seq_file *m, struct Scsi_Host *shost) | |||
3432 | } | 3423 | } |
3433 | seq_printf(m, " %X:%u", i, v->max_dvc_qng[i]); | 3424 | seq_printf(m, " %X:%u", i, v->max_dvc_qng[i]); |
3434 | } | 3425 | } |
3435 | seq_puts(m, "\n"); | ||
3436 | 3426 | ||
3437 | /* Indicate whether the device has returned queue full status. */ | 3427 | /* Indicate whether the device has returned queue full status. */ |
3438 | seq_puts(m, " Command Queue Full:"); | 3428 | seq_puts(m, "\n Command Queue Full:"); |
3439 | for (i = 0; i <= ASC_MAX_TID; i++) { | 3429 | for (i = 0; i <= ASC_MAX_TID; i++) { |
3440 | if ((chip_scsi_id == i) || | 3430 | if ((chip_scsi_id == i) || |
3441 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { | 3431 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { |
@@ -3447,9 +3437,8 @@ static void asc_prt_asc_board_info(struct seq_file *m, struct Scsi_Host *shost) | |||
3447 | else | 3437 | else |
3448 | seq_printf(m, " %X:N", i); | 3438 | seq_printf(m, " %X:N", i); |
3449 | } | 3439 | } |
3450 | seq_puts(m, "\n"); | ||
3451 | 3440 | ||
3452 | seq_puts(m, " Synchronous Transfer:"); | 3441 | seq_puts(m, "\n Synchronous Transfer:"); |
3453 | for (i = 0; i <= ASC_MAX_TID; i++) { | 3442 | for (i = 0; i <= ASC_MAX_TID; i++) { |
3454 | if ((chip_scsi_id == i) || | 3443 | if ((chip_scsi_id == i) || |
3455 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { | 3444 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { |
@@ -3555,9 +3544,8 @@ static void asc_prt_adv_board_info(struct seq_file *m, struct Scsi_Host *shost) | |||
3555 | i, | 3544 | i, |
3556 | (tagqng_able & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); | 3545 | (tagqng_able & ADV_TID_TO_TIDMASK(i)) ? 'Y' : 'N'); |
3557 | } | 3546 | } |
3558 | seq_puts(m, "\n"); | ||
3559 | 3547 | ||
3560 | seq_puts(m, " Queue Limit:"); | 3548 | seq_puts(m, "\n Queue Limit:"); |
3561 | for (i = 0; i <= ADV_MAX_TID; i++) { | 3549 | for (i = 0; i <= ADV_MAX_TID; i++) { |
3562 | if ((chip_scsi_id == i) || | 3550 | if ((chip_scsi_id == i) || |
3563 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { | 3551 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { |
@@ -3569,9 +3557,8 @@ static void asc_prt_adv_board_info(struct seq_file *m, struct Scsi_Host *shost) | |||
3569 | 3557 | ||
3570 | seq_printf(m, " %X:%d", i, lrambyte); | 3558 | seq_printf(m, " %X:%d", i, lrambyte); |
3571 | } | 3559 | } |
3572 | seq_puts(m, "\n"); | ||
3573 | 3560 | ||
3574 | seq_puts(m, " Command Pending:"); | 3561 | seq_puts(m, "\n Command Pending:"); |
3575 | for (i = 0; i <= ADV_MAX_TID; i++) { | 3562 | for (i = 0; i <= ADV_MAX_TID; i++) { |
3576 | if ((chip_scsi_id == i) || | 3563 | if ((chip_scsi_id == i) || |
3577 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { | 3564 | ((boardp->init_tidmask & ADV_TID_TO_TIDMASK(i)) == 0)) { |
diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index 0b0246716646..0836433e3a2d 100644 --- a/drivers/scsi/atp870u.c +++ b/drivers/scsi/atp870u.c | |||
@@ -3101,9 +3101,8 @@ static const char *atp870u_info(struct Scsi_Host *notused) | |||
3101 | 3101 | ||
3102 | static int atp870u_show_info(struct seq_file *m, struct Scsi_Host *HBAptr) | 3102 | static int atp870u_show_info(struct seq_file *m, struct Scsi_Host *HBAptr) |
3103 | { | 3103 | { |
3104 | seq_puts(m, "ACARD AEC-671X Driver Version: 2.6+ac\n"); | 3104 | seq_puts(m, "ACARD AEC-671X Driver Version: 2.6+ac\n\n" |
3105 | seq_puts(m, "\n"); | 3105 | "Adapter Configuration:\n"); |
3106 | seq_puts(m, "Adapter Configuration:\n"); | ||
3107 | seq_printf(m, " Base IO: %#.4lx\n", HBAptr->io_port); | 3106 | seq_printf(m, " Base IO: %#.4lx\n", HBAptr->io_port); |
3108 | seq_printf(m, " IRQ: %d\n", HBAptr->irq); | 3107 | seq_printf(m, " IRQ: %d\n", HBAptr->irq); |
3109 | return 0; | 3108 | return 0; |
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index 3a55ea24aa0b..48c79f935b45 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c | |||
@@ -4623,8 +4623,8 @@ static int dc395x_show_info(struct seq_file *m, struct Scsi_Host *host) | |||
4623 | unsigned long flags; | 4623 | unsigned long flags; |
4624 | int dev; | 4624 | int dev; |
4625 | 4625 | ||
4626 | seq_puts(m, DC395X_BANNER " PCI SCSI Host Adapter\n"); | 4626 | seq_puts(m, DC395X_BANNER " PCI SCSI Host Adapter\n" |
4627 | seq_puts(m, " Driver Version " DC395X_VERSION "\n"); | 4627 | " Driver Version " DC395X_VERSION "\n"); |
4628 | 4628 | ||
4629 | DC395x_LOCK_IO(acb->scsi_host, flags); | 4629 | DC395x_LOCK_IO(acb->scsi_host, flags); |
4630 | 4630 | ||
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index bf883a672781..acf558a0bd79 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c | |||
@@ -1375,8 +1375,8 @@ static int nsp_show_info(struct seq_file *m, struct Scsi_Host *host) | |||
1375 | hostno = host->host_no; | 1375 | hostno = host->host_no; |
1376 | data = (nsp_hw_data *)host->hostdata; | 1376 | data = (nsp_hw_data *)host->hostdata; |
1377 | 1377 | ||
1378 | seq_puts(m, "NinjaSCSI status\n\n"); | 1378 | seq_puts(m, "NinjaSCSI status\n\n" |
1379 | seq_puts(m, "Driver version: $Revision: 1.23 $\n"); | 1379 | "Driver version: $Revision: 1.23 $\n"); |
1380 | seq_printf(m, "SCSI host No.: %d\n", hostno); | 1380 | seq_printf(m, "SCSI host No.: %d\n", hostno); |
1381 | seq_printf(m, "IRQ: %d\n", host->irq); | 1381 | seq_printf(m, "IRQ: %d\n", host->irq); |
1382 | seq_printf(m, "IO: 0x%lx-0x%lx\n", host->io_port, host->io_port + host->n_io_port - 1); | 1382 | seq_printf(m, "IO: 0x%lx-0x%lx\n", host->io_port, host->io_port + host->n_io_port - 1); |