hwmon: (core) fix resource leak on devm_kcalloc failure

If dev_kcalloc fails to allocate hw_dev->groups then the current
exit path is a direct return, causing a leak of resources such
as hwdev and ida is not removed.  Fix this by exiting via the
free_hwmon exit path that performs the necessary resource cleanup.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

1 files changed, 4 insertions, 2 deletions

diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index adae6848ffb2..a74c075a30ec 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -536,8 +536,10 @@ __hwmon_device_register(struct device *dev, const char *name, void *drvdata,
 
                 hwdev->groups = devm_kcalloc(dev, ngroups, sizeof(*groups),
                                              GFP_KERNEL);
-                if (!hwdev->groups)
-                        return ERR_PTR(-ENOMEM);
+                if (!hwdev->groups) {
+                        err = -ENOMEM;
+                        goto free_hwmon;
+                }
 
                 attrs = __hwmon_create_attrs(dev, drvdata, chip);
                 if (IS_ERR(attrs)) {