aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTina Ruchandani <ruchandani.tina@gmail.com>2016-03-21 01:59:11 -0400
committerStefan Richter <stefanr@s5r6.in-berlin.de>2016-03-22 10:14:30 -0400
commit384fbb96f9268eee0b703b39cb07557403bd9aac (patch)
tree39d50c38d0e6954f12e852f7f4e15ff56a91c30d
parente38e5ce81c3ed79dd48fc1801134e8812558c389 (diff)
firewire: nosy: Replace timeval with timespec64
'struct timeval' uses a 32 bit field for its 'seconds' value which will overflow in year 2038 and beyond. This patch replaces the use of timeval in nosy.c with timespec64 which doesn't suffer from y2038 issue. The code is correct as is - since it is only using the microseconds portion of timeval. However, this patch does the replacement as part of a larger effort to remove all instances of 'struct timeval' from the kernel (that would help identify cases where the code is actually broken). Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r--drivers/firewire/nosy.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
index 8a46077129ac..631c977b0da5 100644
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -446,14 +446,16 @@ static void
446bus_reset_irq_handler(struct pcilynx *lynx) 446bus_reset_irq_handler(struct pcilynx *lynx)
447{ 447{
448 struct client *client; 448 struct client *client;
449 struct timeval tv; 449 struct timespec64 ts64;
450 u32 timestamp;
450 451
451 do_gettimeofday(&tv); 452 ktime_get_real_ts64(&ts64);
453 timestamp = ts64.tv_nsec / NSEC_PER_USEC;
452 454
453 spin_lock(&lynx->client_list_lock); 455 spin_lock(&lynx->client_list_lock);
454 456
455 list_for_each_entry(client, &lynx->client_list, link) 457 list_for_each_entry(client, &lynx->client_list, link)
456 packet_buffer_put(&client->buffer, &tv.tv_usec, 4); 458 packet_buffer_put(&client->buffer, &timestamp, 4);
457 459
458 spin_unlock(&lynx->client_list_lock); 460 spin_unlock(&lynx->client_list_lock);
459} 461}