diff options
author | Sylwester Nawrocki <s.nawrocki@samsung.com> | 2012-07-24 11:06:26 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-07-30 18:23:17 -0400 |
commit | 31ce54f6aeb70ecf1b8e758236955dfad1b1e398 (patch) | |
tree | 72a99d2b1c22ac28d9fb813c722398a59b734674 | |
parent | a516d08fa6afb703ba508ccc55656d037c5b9e2e (diff) |
[media] s5p-fimc: Use switch statement for better readability
Use switch statement rather than multiple 'else if'.
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/video/s5p-fimc/fimc-reg.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/drivers/media/video/s5p-fimc/fimc-reg.c b/drivers/media/video/s5p-fimc/fimc-reg.c index 74a2fba2c543..0e3eb9ce4f98 100644 --- a/drivers/media/video/s5p-fimc/fimc-reg.c +++ b/drivers/media/video/s5p-fimc/fimc-reg.c | |||
@@ -667,7 +667,8 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, | |||
667 | FIMC_REG_CIGCTRL_SELCAM_MIPI | FIMC_REG_CIGCTRL_CAMIF_SELWB | | 667 | FIMC_REG_CIGCTRL_SELCAM_MIPI | FIMC_REG_CIGCTRL_CAMIF_SELWB | |
668 | FIMC_REG_CIGCTRL_SELCAM_MIPI_A | FIMC_REG_CIGCTRL_CAM_JPEG); | 668 | FIMC_REG_CIGCTRL_SELCAM_MIPI_A | FIMC_REG_CIGCTRL_CAM_JPEG); |
669 | 669 | ||
670 | if (cam->bus_type == FIMC_MIPI_CSI2) { | 670 | switch (cam->bus_type) { |
671 | case FIMC_MIPI_CSI2: | ||
671 | cfg |= FIMC_REG_CIGCTRL_SELCAM_MIPI; | 672 | cfg |= FIMC_REG_CIGCTRL_SELCAM_MIPI; |
672 | 673 | ||
673 | if (cam->mux_id == 0) | 674 | if (cam->mux_id == 0) |
@@ -691,14 +692,15 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, | |||
691 | tmp |= (csis_data_alignment == 32) << 8; | 692 | tmp |= (csis_data_alignment == 32) << 8; |
692 | 693 | ||
693 | writel(tmp, fimc->regs + FIMC_REG_CSIIMGFMT); | 694 | writel(tmp, fimc->regs + FIMC_REG_CSIIMGFMT); |
694 | 695 | break; | |
695 | } else if (cam->bus_type == FIMC_ITU_601 || | 696 | case FIMC_ITU_601...FIMC_ITU_656: |
696 | cam->bus_type == FIMC_ITU_656) { | ||
697 | if (cam->mux_id == 0) /* ITU-A, ITU-B: 0, 1 */ | 697 | if (cam->mux_id == 0) /* ITU-A, ITU-B: 0, 1 */ |
698 | cfg |= FIMC_REG_CIGCTRL_SELCAM_ITU_A; | 698 | cfg |= FIMC_REG_CIGCTRL_SELCAM_ITU_A; |
699 | } else if (cam->bus_type == FIMC_LCD_WB) { | 699 | break; |
700 | case FIMC_LCD_WB: | ||
700 | cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB; | 701 | cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB; |
701 | } else { | 702 | break; |
703 | default: | ||
702 | v4l2_err(vid_cap->vfd, "Invalid camera bus type selected\n"); | 704 | v4l2_err(vid_cap->vfd, "Invalid camera bus type selected\n"); |
703 | return -EINVAL; | 705 | return -EINVAL; |
704 | } | 706 | } |