diff options
author | Colin Ian King <colin.king@canonical.com> | 2016-05-05 18:39:33 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-05-08 23:32:59 -0400 |
commit | 25a54342fde903b6abc2680594cf3e4864686339 (patch) | |
tree | 89be78b0f2e402ca1932aac7155ecea580f4560b | |
parent | 810810ffb2f6d46365d0790bbe77698a5534393a (diff) |
tools: bpf_jit_disasm: check for klogctl failure
klogctl can fail and return -ve len, so check for this and
return NULL to avoid passing a (size_t)-1 to malloc.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | tools/net/bpf_jit_disasm.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/net/bpf_jit_disasm.c b/tools/net/bpf_jit_disasm.c index 5b3241340945..544b05a53b70 100644 --- a/tools/net/bpf_jit_disasm.c +++ b/tools/net/bpf_jit_disasm.c | |||
@@ -98,6 +98,9 @@ static char *get_klog_buff(unsigned int *klen) | |||
98 | char *buff; | 98 | char *buff; |
99 | 99 | ||
100 | len = klogctl(CMD_ACTION_SIZE_BUFFER, NULL, 0); | 100 | len = klogctl(CMD_ACTION_SIZE_BUFFER, NULL, 0); |
101 | if (len < 0) | ||
102 | return NULL; | ||
103 | |||
101 | buff = malloc(len); | 104 | buff = malloc(len); |
102 | if (!buff) | 105 | if (!buff) |
103 | return NULL; | 106 | return NULL; |