aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-12-28 09:20:45 -0500
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2016-01-25 12:15:38 -0500
commit2050d14c6ea23ea7b50b5cc7d05dbf645705cf70 (patch)
tree01c6cadd16b86b0115c7409c676343c0c7e51665
parentc2e5c951c2d10536a9f17647f3440e5f9f639d8b (diff)
[media] tuners: Refactoring for m88rs6000t_sleep()
This issue was detected by using the Coccinelle software. 1. Let us return directly if a call of the regmap_write() function failed. 2. Delete the jump label "err" then. 3. Return zero as a constant at the end. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r--drivers/media/tuners/m88rs6000t.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/media/tuners/m88rs6000t.c b/drivers/media/tuners/m88rs6000t.c
index 504bfbc4027a..9f3e0fd4cad9 100644
--- a/drivers/media/tuners/m88rs6000t.c
+++ b/drivers/media/tuners/m88rs6000t.c
@@ -461,13 +461,12 @@ static int m88rs6000t_sleep(struct dvb_frontend *fe)
461 dev_dbg(&dev->client->dev, "%s:\n", __func__); 461 dev_dbg(&dev->client->dev, "%s:\n", __func__);
462 462
463 ret = regmap_write(dev->regmap, 0x07, 0x6d); 463 ret = regmap_write(dev->regmap, 0x07, 0x6d);
464 if (ret) 464 if (ret) {
465 goto err;
466 usleep_range(5000, 10000);
467err:
468 if (ret)
469 dev_dbg(&dev->client->dev, "failed=%d\n", ret); 465 dev_dbg(&dev->client->dev, "failed=%d\n", ret);
470 return ret; 466 return ret;
467 }
468 usleep_range(5000, 10000);
469 return 0;
471} 470}
472 471
473static int m88rs6000t_get_frequency(struct dvb_frontend *fe, u32 *frequency) 472static int m88rs6000t_get_frequency(struct dvb_frontend *fe, u32 *frequency)